From: Warner Losh <imp@bsdimp.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Gleb Popov <arrowd@freebsd.org>, Kyle Evans <kevans@freebsd.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Konrad Witaszczyk <def@freebsd.org>,
Jessica Clarke <jrtc27@freebsd.org>,
Brad Smith <brad@comstyle.com>
Subject: Re: [PATCH 13/22] bsd-user/bsd-file.h: Implementation details for the filesystem calls
Date: Sat, 26 Feb 2022 09:24:48 -0700 [thread overview]
Message-ID: <CANCZdfpiBNTygi77SzE2vy34+0sjPqHdaoYz7dZMBSkgOBb+tw@mail.gmail.com> (raw)
In-Reply-To: <021f966e-b664-b27f-f24a-fc6dc9f960bb@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 626 bytes --]
On Tue, Feb 1, 2022 at 10:43 AM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 2/1/22 22:14, Warner Losh wrote:
> > +#ifndef BSD_FILE_H_
> > +#define BSD_FILE_H_
> > +
> > +#include <sys/types.h>
> > +#include <sys/mount.h>
> > +#include <sys/uio.h>
> > +#include <fcntl.h>
> > +#include <poll.h>
> > +#include <stdio.h>
> > +#include <stdlib.h>
> > +#include <unistd.h>
>
> Many of these should be done by "qemu/osdep.h" already. Otherwise I
> question putting them
> into this header, as opposed to as needed by other syscall handling c
> files.
>
Indeed. None of these are needed here. I've removed them.
[-- Attachment #2: Type: text/html, Size: 1101 bytes --]
next prev parent reply other threads:[~2022-02-26 16:26 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 11:14 [PATCH 00/22] bsd-user: Start upstreaming the system calls Warner Losh
2022-02-01 11:14 ` [PATCH 01/22] bsd-user/main.c: Drop syscall flavor arg -bsd Warner Losh
2022-02-01 15:54 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 02/22] bsd-user/x86_64/target_arch_cpu.h: int $80 never was a BSD system call on amd64 Warner Losh
2022-02-01 15:57 ` Richard Henderson
2022-02-01 16:19 ` Kyle Evans
2022-02-01 11:14 ` [PATCH 03/22] bsd-user/x86_64/target_arch_cpu.h: Remove openbsd syscall Warner Losh
2022-02-01 16:22 ` Kyle Evans
2022-02-01 23:13 ` Warner Losh
2022-02-01 17:27 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 04/22] bsd-user/i386/target_arch_cpu.h: " Warner Losh
2022-02-01 16:24 ` Kyle Evans
2022-02-01 17:29 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 05/22] bsd-user/arm/target_arch_cpu.h: Only support FreeBSD sys calls Warner Losh
2022-02-01 16:32 ` Kyle Evans
2022-02-01 23:19 ` Warner Losh
2022-02-01 17:31 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 06/22] bsd-user/arm/target_arch_thread.h: Assume a FreeBSD target Warner Losh
2022-02-01 16:33 ` Kyle Evans
2022-02-01 17:34 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 07/22] bsd-user/x86_64/target_arch_thread.h: " Warner Losh
2022-02-01 16:36 ` Kyle Evans
2022-02-01 17:34 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 08/22] bsd-user: Remove bsd_type Warner Losh
2022-02-01 16:34 ` Kyle Evans
2022-02-01 17:35 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 09/22] bsd-user/freebsd/os-syscall.c: Move syscall processing here Warner Losh
2022-02-01 16:18 ` Kyle Evans
2022-02-01 17:37 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 10/22] bsd-user: Move system call building to os-syscall.c Warner Losh
2022-02-01 17:38 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 11/22] bsd-user/sycall.c: Now obsolete, remove Warner Losh
2022-02-01 16:35 ` Kyle Evans
2022-02-01 17:38 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 12/22] bsd-user/freebsd/os-syscall.c: Add get_errno and host_to_target_errno Warner Losh
2022-02-01 16:35 ` Kyle Evans
2022-02-01 17:39 ` Richard Henderson
2022-02-01 23:27 ` Warner Losh
2022-02-01 11:14 ` [PATCH 13/22] bsd-user/bsd-file.h: Implementation details for the filesystem calls Warner Losh
2022-02-01 16:47 ` Kyle Evans
2022-02-01 17:43 ` Richard Henderson
2022-02-01 23:55 ` Warner Losh
2022-02-26 16:24 ` Warner Losh [this message]
2022-02-01 11:14 ` [PATCH 14/22] bsd-user/freebsd/os-syscall.c: lock_iovec Warner Losh
2022-02-01 16:46 ` Kyle Evans
2022-02-01 21:16 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 15/22] bsd-user/freebsd/os-syscall.c: unlock_iovec Warner Losh
2022-02-01 16:37 ` Kyle Evans
2022-02-01 21:29 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 16/22] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate Warner Losh
2022-02-01 21:31 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 17/22] bsd-user: introduce target.h Warner Losh
2022-02-01 16:39 ` Kyle Evans
2022-02-01 21:32 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 18/22] bsd-user: Define target_arg64 Warner Losh
2022-02-01 16:41 ` Kyle Evans
2022-02-01 21:33 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 19/22] bsd-user: Add safe system call macros Warner Losh
2022-02-01 21:33 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 20/22] bsd-user/bsd-file.h: Add implementations for read, pread, readv and preadv Warner Losh
2022-02-01 21:37 ` Richard Henderson
2022-02-02 3:02 ` Warner Losh
2022-02-01 11:14 ` [PATCH 21/22] bsd-user/bsd-file.h: Meat of the write system calls Warner Losh
2022-02-01 21:38 ` Richard Henderson
2022-02-01 11:14 ` [PATCH 22/22] bsd-user/freebsd/os-syscall.c: Implement exit Warner Losh
2022-02-01 16:48 ` Kyle Evans
2022-02-01 21:39 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANCZdfpiBNTygi77SzE2vy34+0sjPqHdaoYz7dZMBSkgOBb+tw@mail.gmail.com \
--to=imp@bsdimp.com \
--cc=arrowd@freebsd.org \
--cc=brad@comstyle.com \
--cc=def@freebsd.org \
--cc=jrtc27@freebsd.org \
--cc=kevans@freebsd.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).