From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21765C83F01 for ; Wed, 30 Aug 2023 14:59:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbMea-0001vx-SN; Wed, 30 Aug 2023 10:58:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbMeY-0001vC-Gi for qemu-devel@nongnu.org; Wed, 30 Aug 2023 10:58:42 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbMeV-0001o5-Qo for qemu-devel@nongnu.org; Wed, 30 Aug 2023 10:58:42 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-98377c5d53eso736819166b.0 for ; Wed, 30 Aug 2023 07:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1693407518; x=1694012318; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rlER/J8YB532KhzSLw22hT3a4ef/Pi6m9PU+LLsj0JM=; b=hH6ovB8NRPY6cRu6UXmvKVvbkvFOgS3HDfMkShyDrgtAzpyeE3przu9syJI/1Xcxcp CsAa1CdLh6OF4ZHptR1bw0lapq87AkuPFcxMM7HrxJuQOATVBrFZff6B2m+YIoWXN0Ba ntvw/5s+hCh/oyo5i6pNn035T7nbRB1yx4Dm2+wAu5SAJIo6F7wPkQJlro+aIb4nwgAO m93TbWscdzYNw0D0Q+zIm+MkMNaQYdwofpxJA+nbUd5tlyXk81rw+pL4eA2UFBUkU8HI 9VMtuOTAwAWeYix1R8o8HMMteMI9IWQ+61MNFThebcFCQjJLQZi02Uvo4Cg8srqjwEwh Ua8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693407518; x=1694012318; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rlER/J8YB532KhzSLw22hT3a4ef/Pi6m9PU+LLsj0JM=; b=Z+JFJH7BG599JMY6Ma8pPnsicoUj1hYPpgFOjFlyPJBBFqX23Is0IUsc5oghnvX9Py lvyzacTvmxpBD26gca25R8xvkfCKYd4wUzQ9jOQvCeSoyVqpf0+PUgEKd8/clJDijcXr CcIA396/JiP5YiTfp69poE83YkW5kVOllUTUp3aWtn4rrR3vitBtdwTlZQnubcbbSj+c f/woTTuoFKXDam7U/mnKGQ7rGHRqq0fkKVNyU2/mdgkiNWtpdIJ6XZ1maEm+tSKN9+RW BSCttbWjnTCVZLZpj09a1Tx+fUvShQm037fROZ3N53i3VViJaFG2eyn5mNXw7tbbLbhy XZLw== X-Gm-Message-State: AOJu0YxIA+j5SLjBmdspR5FPNNwCkd1givoXVOY5E0Ha6jliQrx/EMB2 ekk1fxB8KcIT29zPVka6QPBgMbuA4F4lUwB9SFCz0Q== X-Google-Smtp-Source: AGHT+IGCfjv5FzbmPM3c7RYZcJrY6qBSJBvVj0G5o20+rmI1Q8md+xYzMHanAChncT8Ui7fZlRamlK77u3nRbBKUpcA= X-Received: by 2002:a17:906:3145:b0:9a5:7c4c:5799 with SMTP id e5-20020a170906314500b009a57c4c5799mr1768102eje.58.1693407517907; Wed, 30 Aug 2023 07:58:37 -0700 (PDT) MIME-Version: 1.0 References: <20230830144743.53770-1-imp@bsdimp.com> In-Reply-To: From: Warner Losh Date: Wed, 30 Aug 2023 08:58:26 -0600 Message-ID: Subject: Re: [PATCH v3] bsd-user: Move PRAGMA_DISABLE_PACKED_WARNING etc to qemu.h To: Peter Maydell Cc: qemu-devel@nongnu.org, =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Wainer dos Santos Moschetta , Beraldo Leal , Thomas Huth , Laurent Vivier , Kyle Evans Content-Type: multipart/alternative; boundary="00000000000090b43e06042529ed" Received-SPF: none client-ip=2a00:1450:4864:20::629; envelope-from=wlosh@bsdimp.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --00000000000090b43e06042529ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 30, 2023 at 8:55=E2=80=AFAM Peter Maydell wrote: > On Wed, 30 Aug 2023 at 15:51, Warner Losh wrote: > > > > For the moment, move PRAGMA_DISABLE_PACKED_WARNING and > > PRAGMA_ENABLE_PACKED_WARNING back to bsd-user/qemu.h. > > > > Of course, these should be in compiler.h, but that interferes with too > > many things at the moment, so take one step back to unbreak clang > > linux-user builds first. Use the exact same version that's in > > linux-user/qemu.h since that's what should be in compiler.h. > > --- > > bsd-user/qemu.h | 27 +++++++++++++++++++++++++++ > > include/qemu/compiler.h | 30 ------------------------------ > > 2 files changed, 27 insertions(+), 30 deletions(-) > > Yeah, let's un-break CI first and then think about a neater > thing afterwards. > Yea. And in 2 days I'll have minutes again and in 7 I'll be past a deadline at $WORK and have time to setup local gitlab CI... but trying to play whack-a-mole with this w/o either is going to take days... > Reviewed-by: Peter Maydell > > thanks > -- PMM > --00000000000090b43e06042529ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Aug 30, 2023 at 8:55=E2=80=AF= AM Peter Maydell <peter.mayd= ell@linaro.org> wrote:
On Wed, 30 Aug 2023 at 15:51, Warner Losh <imp@bsdimp.com> wrote:
>
> For the moment, move PRAGMA_DISABLE_PACKED_WARNING and
> PRAGMA_ENABLE_PACKED_WARNING back to bsd-user/qemu.h.
>
> Of course, these should be in compiler.h, but that interferes with too=
> many things at the moment, so take one step back to unbreak clang
> linux-user builds first. Use the exact same version that's in
> linux-user/qemu.h since that's what should be in compiler.h.
> ---
>=C2=A0 bsd-user/qemu.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 27 ++++++++++= +++++++++++++++++
>=C2=A0 include/qemu/compiler.h | 30 ------------------------------
>=C2=A0 2 files changed, 27 insertions(+), 30 deletions(-)

Yeah, let's un-break CI first and then think about a neater
thing afterwards.

Yea. And in 2 days I&= #39;ll have minutes again and in 7 I'll be past a deadline
at= $WORK and have time to setup=C2=A0local gitlab CI... but trying to play wh= ack-a-mole
with this w/o either is going to take days...
=C2=A0
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
--00000000000090b43e06042529ed--