From: Warner Losh <imp@bsdimp.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "QEMU Developers" <qemu-devel@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Ed Maste" <emaste@freebsd.org>, "Li-Wen Hsu" <lwhsu@freebsd.org>,
"Kyle Evans" <kevans@freebsd.org>,
"Brad Smith" <brad@comstyle.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH] tests/vm/freebsd: Add additional library paths for libfdt
Date: Mon, 16 Oct 2023 11:00:46 -0600 [thread overview]
Message-ID: <CANCZdfquj7K6ED0SWC1v+wQOPLmXYVBbf4n37gS0nEuGemaaGA@mail.gmail.com> (raw)
In-Reply-To: <20231016161053.39150-1-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
On Mon, Oct 16, 2023, 10:11 AM Thomas Huth <thuth@redhat.com> wrote:
> libfdt is installed in /usr/local on FreeBSD, and since this
> library does not have a pkg-config file, we have to specify the
> paths manually. This way we can avoid that Meson has to recompile
> the dtc subproject each time.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/vm/freebsd | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
Reviewed-by: Warner Losh <imp@bsdimp.com>
diff --git a/tests/vm/freebsd b/tests/vm/freebsd
> index ac51376c82..b581bd17fb 100755
> --- a/tests/vm/freebsd
> +++ b/tests/vm/freebsd
> @@ -38,8 +38,9 @@ class FreeBSDVM(basevm.BaseVM):
> cd $(mktemp -d /home/qemu/qemu-test.XXXXXX);
> mkdir src build; cd src;
> tar -xf /dev/vtbd1;
> - cd ../build
> - ../src/configure --python=python3.9 {configure_opts};
> + cd ../build;
> + ../src/configure --python=python3.9
> --extra-ldflags=-L/usr/local/lib \
> + --extra-cflags=-I/usr/local/include
> {configure_opts};
> gmake --output-sync -j{jobs} {target} {verbose};
> """
>
> --
> 2.41.0
>
>
[-- Attachment #2: Type: text/html, Size: 1951 bytes --]
prev parent reply other threads:[~2023-10-16 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:10 [PATCH] tests/vm/freebsd: Add additional library paths for libfdt Thomas Huth
2023-10-16 17:00 ` Warner Losh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANCZdfquj7K6ED0SWC1v+wQOPLmXYVBbf4n37gS0nEuGemaaGA@mail.gmail.com \
--to=imp@bsdimp.com \
--cc=alex.bennee@linaro.org \
--cc=brad@comstyle.com \
--cc=david@gibson.dropbear.id.au \
--cc=emaste@freebsd.org \
--cc=kevans@freebsd.org \
--cc=lwhsu@freebsd.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).