From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B8BCCDB474 for ; Mon, 16 Oct 2023 17:02:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qsQy7-0003xV-2f; Mon, 16 Oct 2023 13:01:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qsQxn-0003pm-Qe for qemu-devel@nongnu.org; Mon, 16 Oct 2023 13:01:08 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qsQxi-0000zX-PN for qemu-devel@nongnu.org; Mon, 16 Oct 2023 13:01:07 -0400 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9be3b66f254so401246466b.3 for ; Mon, 16 Oct 2023 10:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1697475658; x=1698080458; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CECr3R7l9X0fzW2sz6jBGmGM27qaeqeVydCyXSY1P/M=; b=iei0YPtseMwyCIN6+RxBrm0RL7U3P6dHztZlBOO/iMfYg97kLwI2rSW6tV3/u2qM4B FaQI2oX/gJ7+y6L2dZ35eR4rJMxurCpHEobXt10QLCVhKaPb5mNeAgW1ZSvvPavP5HYi Cg4JwCvJLFRcifz6RxIyN4f8QXx97ug3Ercb+/hF9zM780pRFoRGNg2Ve20QjGeT8a7n XlIRgNyspDhvkXM7a95sq1bTBETYFAgoojuPB6eztxCS7xzDKRdrk6BYk0JrxCIMz4uY TGMxssEzwrWE1pxe3+0IE1WKt5zoINuvdtPIA03GLc2ZRJ8L0nrcgz97giE4oAe3E16A IRRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697475658; x=1698080458; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CECr3R7l9X0fzW2sz6jBGmGM27qaeqeVydCyXSY1P/M=; b=oxlg8/h7UATizBIx/eKj7F2BpRjdNCjvLyYUz7GWU2uY+RgBp3d5cOgRkfYc+2499G mTgLnIDeGM4ezLT7tRJbyIqQtMmWeda3LfiE9B7kl7EKfl5UoSAaVBlwBnE0UGH/4jqW VJj1lViq9hJwMzADHp9HtVUgLNS/ZJbk28ag/3p27capJenV1hztWpMooL7OZyJGG0In PcclJorakBvOGPKgTPHRVPKKQk34TEypKiIbSa5j+NR7arsTQf13xWJzjK36x60JxXU6 xgVTceQkE0bPIYbZYkDDlOBv+jWrBWYr7JcFBroeAuOZP0ptImYIkZ9X23FFYBSnlkDi 5JXg== X-Gm-Message-State: AOJu0YwBBfkyAPQ4ovAThLO2osUuKVuBrbFD2CZEvZ+rezYlLD1TOOB3 RY2lDLweuSmnJ0oRHcsBiYJStRfykfbrfjTDmAGCugL1q0mt/FXyl1s= X-Google-Smtp-Source: AGHT+IFm1eg2YJZyBojB0Bn3SDZHiEmRNCVU8Mj9pzL142pj9f2lsxD07+f6Llq5WlxhSoCoxtpOfUYQy1Dx76cFC+Q= X-Received: by 2002:a17:907:77c9:b0:9b2:6d09:847c with SMTP id kz9-20020a17090777c900b009b26d09847cmr27562730ejc.10.1697475658257; Mon, 16 Oct 2023 10:00:58 -0700 (PDT) MIME-Version: 1.0 References: <20231016161053.39150-1-thuth@redhat.com> In-Reply-To: <20231016161053.39150-1-thuth@redhat.com> From: Warner Losh Date: Mon, 16 Oct 2023 11:00:46 -0600 Message-ID: Subject: Re: [PATCH] tests/vm/freebsd: Add additional library paths for libfdt To: Thomas Huth Cc: QEMU Developers , =?UTF-8?B?QWxleCBCZW5uw6ll?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Ed Maste , Li-Wen Hsu , Kyle Evans , Brad Smith , Paolo Bonzini , David Gibson Content-Type: multipart/alternative; boundary="000000000000a040b50607d859f6" Received-SPF: none client-ip=2a00:1450:4864:20::62f; envelope-from=wlosh@bsdimp.com; helo=mail-ej1-x62f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --000000000000a040b50607d859f6 Content-Type: text/plain; charset="UTF-8" On Mon, Oct 16, 2023, 10:11 AM Thomas Huth wrote: > libfdt is installed in /usr/local on FreeBSD, and since this > library does not have a pkg-config file, we have to specify the > paths manually. This way we can avoid that Meson has to recompile > the dtc subproject each time. > > Signed-off-by: Thomas Huth > --- > tests/vm/freebsd | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Reviewed-by: Warner Losh diff --git a/tests/vm/freebsd b/tests/vm/freebsd > index ac51376c82..b581bd17fb 100755 > --- a/tests/vm/freebsd > +++ b/tests/vm/freebsd > @@ -38,8 +38,9 @@ class FreeBSDVM(basevm.BaseVM): > cd $(mktemp -d /home/qemu/qemu-test.XXXXXX); > mkdir src build; cd src; > tar -xf /dev/vtbd1; > - cd ../build > - ../src/configure --python=python3.9 {configure_opts}; > + cd ../build; > + ../src/configure --python=python3.9 > --extra-ldflags=-L/usr/local/lib \ > + --extra-cflags=-I/usr/local/include > {configure_opts}; > gmake --output-sync -j{jobs} {target} {verbose}; > """ > > -- > 2.41.0 > > --000000000000a040b50607d859f6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Oct 16, 2023, 10:11 AM Thomas Huth <thuth@redhat.com> wrote:
libfdt is installed in /usr/local on FreeBSD, and= since this
library does not have a pkg-config file, we have to specify the
paths manually. This way we can avoid that Meson has to recompile
the dtc subproject each time.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
=C2=A0tests/vm/freebsd | 5 +++--
=C2=A01 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Warner Lo= sh <imp@bsdimp.com>

diff --git a/tests/vm/freebsd b/tests/vm/freebsd
index ac51376c82..b581bd17fb 100755
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -38,8 +38,9 @@ class FreeBSDVM(basevm.BaseVM):
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cd $(mktemp -d /home/qemu/qemu-test.XXXXX= X);
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mkdir src build; cd src;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tar -xf /dev/vtbd1;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 cd ../build
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 ../src/configure --python=3Dpython3.9 {configu= re_opts};
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 cd ../build;
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 ../src/configure --python=3Dpython3.9=C2=A0 --= extra-ldflags=3D-L/usr/local/lib \
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0--extra-cflags=3D-I/usr/local/include {configure_opts}; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gmake --output-sync -j{jobs} {target} {ve= rbose};
=C2=A0 =C2=A0 =C2=A0"""

--
2.41.0

--000000000000a040b50607d859f6--