From: Warner Losh <imp@bsdimp.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: fam@euphon.net, "Daniel P. Berrange" <berrange@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
aurelien@aurel32.net
Subject: Re: [RFC PATCH 2/3] tests/tcg/sha1: remove endian include
Date: Tue, 3 Aug 2021 07:55:22 -0600 [thread overview]
Message-ID: <CANCZdfr+LLSiXZcmUHyNJNuLkb60StWJpWwtvQw2GY3+TwoHrw@mail.gmail.com> (raw)
In-Reply-To: <20210803110237.1051032-3-alex.bennee@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1026 bytes --]
On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <alex.bennee@linaro.org> wrote:
> This doesn't exist in BSD world and doesn't seem to be needed by
> either.
>
Sys/endian.h is common. FreeBSD has endian.h, but others don't.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Warner Losh <imp@bsdimp.com>
>
Acked by: Warner Losh <imp@bsdimp.com>
> ---
> tests/tcg/multiarch/sha1.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c
> index 87bfbcdf52..0081bd7657 100644
> --- a/tests/tcg/multiarch/sha1.c
> +++ b/tests/tcg/multiarch/sha1.c
> @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context);
> void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t
> len);
> void SHA1Final(unsigned char digest[20], SHA1_CTX* context);
> /* ================ end of sha1.h ================ */
> -#include <endian.h>
>
> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 -
> (bits))))
>
> --
> 2.30.2
>
>
[-- Attachment #2: Type: text/html, Size: 2027 bytes --]
next prev parent reply other threads:[~2021-08-03 13:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 11:02 [RFC PATCH 0/3] check-tcg hacks for BSD Alex Bennée
2021-08-03 11:02 ` [RFC PATCH 1/3] configure: don't override the selected host test compiler if defined Alex Bennée
2021-08-03 11:02 ` [RFC PATCH 2/3] tests/tcg/sha1: remove endian include Alex Bennée
2021-08-03 13:55 ` Warner Losh [this message]
2021-08-03 14:20 ` Warner Losh
2021-08-03 11:02 ` [RFC PATCH 3/3] tests/tcg: commit Makefile atrocities in the name of portability Alex Bennée
2021-09-14 16:03 ` Warner Losh
2021-09-17 14:34 ` Alex Bennée
2021-09-17 15:08 ` Warner Losh
2021-09-17 16:41 ` Alex Bennée
2021-09-17 17:23 ` Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANCZdfr+LLSiXZcmUHyNJNuLkb60StWJpWwtvQw2GY3+TwoHrw@mail.gmail.com \
--to=imp@bsdimp.com \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=fam@euphon.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).