From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3EBC4338F for ; Tue, 3 Aug 2021 13:56:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01A8D60EC0 for ; Tue, 3 Aug 2021 13:56:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 01A8D60EC0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAuuQ-0000oW-U7 for qemu-devel@archiver.kernel.org; Tue, 03 Aug 2021 09:56:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53968) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAutO-0007x4-72 for qemu-devel@nongnu.org; Tue, 03 Aug 2021 09:55:38 -0400 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]:42634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAutM-0005hX-Hb for qemu-devel@nongnu.org; Tue, 03 Aug 2021 09:55:37 -0400 Received: by mail-qt1-x82e.google.com with SMTP id h27so13937318qtu.9 for ; Tue, 03 Aug 2021 06:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AkG34daRftz3GJaJHI20SVUkXJkCanFLV1GLvG9rgJs=; b=TxTHSKnq6YZYTwV1VX7BOEir9r5FK3+xTvkNs2GziejqINp8z2XD5ObRsFU7oFmNNW hkjgeN4/oDxKSkAhyMlG/S3UJyHlo6DRycAu2uVSHmx7IYrwQRFBoqXHEQ/nekyjmfFe MzFarVhk9YbFeBE1kLIws7ppabv/CRVMOgTkZeh4/Hc0/wZbf8eejjSy2Ez/LEApvMlP 1FwtN/bO8+iG4eoXyEBPSPeY1PUHfECO8ZzVj9bEzYc5edDBUS4hwGXAEj7NGGs8QS1l CLTbJ2tcvP3YffOoSM2dGvQt4S52UXbhMUhbBOfSwHmsNfOgcYy77bOtNesy80D4DaLO vmfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AkG34daRftz3GJaJHI20SVUkXJkCanFLV1GLvG9rgJs=; b=WitS8RznaXmylpMuhDUE36VqukHuqIdCeOE/6b5NWJCHAttXy8zS49QF1EH0AZYBKU VTEM5lMvC29g7mip2D8e49sb96CTv3E/kAkGCJsyelIF9vm1lLuHUj/amx4rshKESHNx yYwqgqzJgKMAsueE9wdYsN6efRMBAPVmka1Tl9UJ3e6If58537FjoTZUksN+f0xYtl+l etBrdnNvSTClpnXhgr50WGX8DIAKzzSJ7d+D/KLzb1mk8Hht+Jio2lCRZ6IxfH/SIljy p30ikASn3C80jIuAqidNHMLOI25x07qmC4KPT0NI84jlGAJYjMwtqP77L9GYmzwrSoab vf8Q== X-Gm-Message-State: AOAM533wZv/kz9qwbCMLp+Guvz2vxep1DQ6dd7As1gHsYZcTKiYt1lMG fdnrnPhiknD8TqhH78yh9PXr+RKVdMxztEQx6i2Qtw== X-Google-Smtp-Source: ABdhPJwF/NddDAUv4hTRNlA0DcqslQU3Y9UyFVNE0j+zKbcrH9yMJ6f1ag2xzIsOo/FNdfnSOHPOjxFg2IT1SFMaQqo= X-Received: by 2002:ac8:6645:: with SMTP id j5mr18429721qtp.244.1627998934698; Tue, 03 Aug 2021 06:55:34 -0700 (PDT) MIME-Version: 1.0 References: <20210803110237.1051032-1-alex.bennee@linaro.org> <20210803110237.1051032-3-alex.bennee@linaro.org> In-Reply-To: <20210803110237.1051032-3-alex.bennee@linaro.org> From: Warner Losh Date: Tue, 3 Aug 2021 07:55:22 -0600 Message-ID: Subject: Re: [RFC PATCH 2/3] tests/tcg/sha1: remove endian include To: =?UTF-8?B?QWxleCBCZW5uw6ll?= Content-Type: multipart/alternative; boundary="00000000000032a3e205c8a80a86" Received-SPF: none client-ip=2607:f8b0:4864:20::82e; envelope-from=wlosh@bsdimp.com; helo=mail-qt1-x82e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, "Daniel P. Berrange" , QEMU Developers , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini , aurelien@aurel32.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000032a3e205c8a80a86 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Aug 3, 2021, 5:02 AM Alex Benn=C3=A9e wrot= e: > This doesn't exist in BSD world and doesn't seem to be needed by > either. > Sys/endian.h is common. FreeBSD has endian.h, but others don't. Signed-off-by: Alex Benn=C3=A9e > Cc: Warner Losh > Acked by: Warner Losh > --- > tests/tcg/multiarch/sha1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c > index 87bfbcdf52..0081bd7657 100644 > --- a/tests/tcg/multiarch/sha1.c > +++ b/tests/tcg/multiarch/sha1.c > @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); > void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t > len); > void SHA1Final(unsigned char digest[20], SHA1_CTX* context); > /* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D end of sha1.h =3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */ > -#include > > #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - > (bits)))) > > -- > 2.30.2 > > --00000000000032a3e205c8a80a86 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Aug 3, 2021, 5:02 AM Alex Benn=C3=A9e <alex.bennee@linaro.org> wrote:=
This doesn't exist in BSD worl= d and doesn't seem to be needed by
either.

Sys/endian.h is common. FreeBSD has endian.h, but others don't.= =C2=A0

Signed-off-by: Alex Benn=C3=A9e <alex.bennee@linaro.org>
Cc: Warner Losh <imp@bsdimp.com>

Acked by: Warner Losh <imp@bsdimp.com>
---
=C2=A0tests/tcg/multiarch/sha1.c | 1 -
=C2=A01 file changed, 1 deletion(-)

diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c
index 87bfbcdf52..0081bd7657 100644
--- a/tests/tcg/multiarch/sha1.c
+++ b/tests/tcg/multiarch/sha1.c
@@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context);
=C2=A0void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_= t len);
=C2=A0void SHA1Final(unsigned char digest[20], SHA1_CTX* context);
=C2=A0/* =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D end of sha1.h =3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D */
-#include <endian.h>

=C2=A0#define rol(value, bits) (((value) << (bits)) | ((value) >&g= t; (32 - (bits))))

--
2.30.2

--00000000000032a3e205c8a80a86--