From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D0E2C83F01 for ; Wed, 30 Aug 2023 13:26:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbLCx-0005iO-FS; Wed, 30 Aug 2023 09:26:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbLCv-0005i2-Jx for qemu-devel@nongnu.org; Wed, 30 Aug 2023 09:26:05 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbLCs-0003zf-KO for qemu-devel@nongnu.org; Wed, 30 Aug 2023 09:26:05 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9a2a4a5472dso187101766b.1 for ; Wed, 30 Aug 2023 06:26:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20221208.gappssmtp.com; s=20221208; t=1693401961; x=1694006761; darn=nongnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=D1NjUvmYK8LsJnjhMqaCCXXiJ27ExEkNbMVG0096ujI=; b=a5rErTPeF/T99LXXmDS0PRhs+/EQvfaOVxtJk8uubiODIPNeXZnXRNQ3oYfO/lB9c0 WyOhvpZbnR6LnebgPQ4Jb1u/5Pr0ckxc/5FI4wiJ4oQ2sBfaqMaBeyR3JyUUa3ooHP0h r2tuF8IE07Lw9emt7lI81t5CwnOWS2FwZJ5W6mXO2PQp5Ro065a1alscOwnZen6LchAe 0pJ4h/peu3kRarl7J3jdGBf9XsUIBlnbfN2FzKKUrjl+uBLVOip7XwWbBLnZCbqZk7Pp 4PXX5v4dxWQp+WfVd0Cz6H0rZjlu8hnn8gGw73L5TUz8+MbGtCtx72t3/VWVPK6+W/1n qjUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693401961; x=1694006761; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D1NjUvmYK8LsJnjhMqaCCXXiJ27ExEkNbMVG0096ujI=; b=Mz14RGFTs3xRfCaFwPno9+oSmdbH3jqeH+iTdQhFj4c8IgkpmzHsIsucjue9C3YR7T 3qBBwaG0+XSRpV6efB1Wvy2xfu0pCpIZ3zTcZsDXDQ2RydLzVhenLVw4w6SQQyhEngVm eaQhvCAxR6SL/Kg29FDDOUbVmKIyOoWEHOtoS7dcnhobujlBo3ViZ0oafsCFCY0p8DLO xK8sVv8w8KJmN6dLIcMIt3JuQAHCj6ijjWSRctJR9Oq30/3XHkq+zEvdbjblpOvX1K7p PBrXf1MDkJz5BMRNqAx3RCxR6Kq2aCDCgMwkdkWHf4yY0vavgeHExsboIlg4VN3nr25w Nsyw== X-Gm-Message-State: AOJu0YyP2wlWOD0Ycrdgcqxz6ikOThtAhu3bM02z/tsfCj8giGLJBHBu UOyxvQVqLkHDZbKdulgN6cOBLc5f42igBW8L3OUcxQ== X-Google-Smtp-Source: AGHT+IE7sf99tmPvQ8Hgk1u/6OAmusgLOQCdwpBe4cZtfgJZFgoZ1N0Rh0RsmQSonCPxft76KWWb4Hu6sDP2xVhNMkQ= X-Received: by 2002:a17:907:980c:b0:9a1:c32c:a69c with SMTP id ji12-20020a170907980c00b009a1c32ca69cmr6287596ejc.17.1693401960595; Wed, 30 Aug 2023 06:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20230830022205.57878-1-imp@bsdimp.com> In-Reply-To: From: Warner Losh Date: Wed, 30 Aug 2023 07:25:48 -0600 Message-ID: Subject: Re: [PULL 0/1] Quick fix patches To: Stefan Hajnoczi Cc: QEMU Developers , Laurent Vivier , Thomas Huth , Beraldo Leal , Wainer dos Santos Moschetta , =?UTF-8?B?QWxleCBCZW5uw6ll?= , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="00000000000052dcd1060423de69" Received-SPF: none client-ip=2a00:1450:4864:20::62e; envelope-from=wlosh@bsdimp.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --00000000000052dcd1060423de69 Content-Type: text/plain; charset="UTF-8" On Wed, Aug 30, 2023, 7:16 AM Stefan Hajnoczi wrote: > Hi, > The patch introduces the following build failure: > > cc -m64 -mcx16 -Isubprojects/libvhost-user/libvhost-user.a.p > -Isubprojects/libvhost-user -I../subprojects/libvhost-user > -fdiagnostics-color=auto -Wall -Winvalid-pch -Werror -std=gnu99 -O2 -g > -Wsign-compare -Wdeclaration-after-statement -Wstrict-aliasing > -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -fno-strict-aliasing > -fno-common -fwrapv -fPIE -pthread -D_GNU_SOURCE -MD -MQ > subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o -MF > subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o.d -o > subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o -c > ../subprojects/libvhost-user/libvhost-user.c > In file included from ../subprojects/libvhost-user/include/atomic.h:18, > from ../subprojects/libvhost-user/libvhost-user.c:53: > ../subprojects/libvhost-user/include/compiler.h:38:40: error: missing > binary operator before token "(" > 38 | #if defined(__clang__) && __has_warning("-Waddress-of-packed-member") > | ^ > > https://gitlab.com/qemu-project/qemu/-/jobs/4981576093 Looks like the macros should be removed there too... but I don't know about the subproject tree. Can I submit to it the same way? And for a quick fix... maybe I just move it back to bsd-user/qemu.h until I have more minutes and can test things better or fund the time to setup a Linux build box for docker... Warner > Stefan > --00000000000052dcd1060423de69 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Aug 30, 2023, 7:16 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:
Hi,
The patch introduces the following build failure:

cc -m64 -mcx16 -Isubprojects/libvhost-user/libvhost-user.a.p
-Isubprojects/libvhost-user -I../subprojects/libvhost-user
-fdiagnostics-color=3Dauto -Wall -Winvalid-pch -Werror -std=3Dgnu99 -O2 -g<= br> -Wsign-compare -Wdeclaration-after-statement -Wstrict-aliasing
-D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -fno-strict-aliasing
-fno-common -fwrapv -fPIE -pthread -D_GNU_SOURCE -MD -MQ
subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o -MF
subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o.d -o
subprojects/libvhost-user/libvhost-user.a.p/libvhost-user.c.o -c
../subprojects/libvhost-user/libvhost-user.c
In file included from ../subprojects/libvhost-user/include/atomic.h:18,
from ../subprojects/libvhost-user/libvhost-user.c:53:
../subprojects/libvhost-user/include/compiler.h:38:40: error: missing
binary operator before token "("
38 | #if defined(__clang__) && __has_warning("-Waddress-of-pac= ked-member")
| ^

https://gitlab.com/qemu-project/qem= u/-/jobs/4981576093

Looks like the macros should be removed there too...=C2= =A0 but I don't know about the subproject tree. Can I submit to it the = same way?

And for a quic= k fix... maybe I just move it back to bsd-user/qemu.h until I have more min= utes and can test things better or fund the time to setup a Linux build box= for docker...

Warner


Stefan
--00000000000052dcd1060423de69--