From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3087C433F5 for ; Thu, 2 Sep 2021 20:11:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59FF26109E for ; Thu, 2 Sep 2021 20:11:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 59FF26109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLt40-0005G4-FJ for qemu-devel@archiver.kernel.org; Thu, 02 Sep 2021 16:11:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLt26-00036G-CW for qemu-devel@nongnu.org; Thu, 02 Sep 2021 16:09:58 -0400 Received: from mail-ua1-x92a.google.com ([2607:f8b0:4864:20::92a]:36468) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mLt23-0000xS-G1 for qemu-devel@nongnu.org; Thu, 02 Sep 2021 16:09:58 -0400 Received: by mail-ua1-x92a.google.com with SMTP id x23so1576203uav.3 for ; Thu, 02 Sep 2021 13:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yy/dcYFGhKpu0ptaayrsqN44d0c/Beh6cldZRRjkueo=; b=LAWjq4VjLaMEZLOYnO/2vAI5sTFiOgEwDOOMTHHjQ+i3iFx5K3nBw4Xj1zaSbq80Ka hZOq595bqGDGMLAfW+/TREThUJs/cOJhxnuctnCQ1wZfIjIPIawR3tijX5SiPmbO247g kkCXFxG49IBOa9HDRksTrqPK8rDI3xkLjbzrRO3cqgXdcqsLd2GFapRJ6ABb49atdxeZ CKM6JX1ObcTOuY0B9yscIQW0p13uVlRqzY/FfGV8XtexDzWEGHqTinmH2Q63M9M9SKhw 9VaSZvtO4tdYN0HEa2Nci2y/2n3PcIaRlCsHjlukt6FPai9xWH6odrwTPe4BaWu0pwWt nY+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yy/dcYFGhKpu0ptaayrsqN44d0c/Beh6cldZRRjkueo=; b=HTjfTXMgr5yZ3PktW5qMTGZ089l4kcWPhWyrzxAYVjWxhyHLnnHrkT8R7GVPjuW6R0 UEc7LDFWCoZywZa1J3cArvnePAsbw+4fDVOZMpKzWJTRNrpeQ9Sl+qF9TGrXUnu4OYce KYu+7fF7ZgejPFM36dc3iK8vYrXgJCexUaxMdjrCH7actsjKYHb+c+fB+3PS2g3kuOD8 Q5LASByHs8A3thjdncK/0HNh8i240yVxzrFXdBuzBQEfEzJnSETbGRNDze288TZXs9MT c43IV652rzKhSy0g9N7vQ2R2yfTVRFuKAc6xelPuIEPjgNrAFfRdKUjKVHvHzksQJ+iU QJAA== X-Gm-Message-State: AOAM531ISvYyUOUAA+n+9xdk8qzoFWowJ7Wsn1dAiU0NLFdyyzhPyR7J oIWKrV1os9Kk1cSnBXByxzt1zMqH0Vv3rbOskOuJpQ== X-Google-Smtp-Source: ABdhPJwusm2ibjguQg+1Na4VfwKxEG65kNOFcGOyaci9y44319h7E8Zd9ICQKkQ7ZDu8Q30CaprVyzSWCLlhwkTlXr4= X-Received: by 2002:ab0:3413:: with SMTP id z19mr24593uap.39.1630613393374; Thu, 02 Sep 2021 13:09:53 -0700 (PDT) MIME-Version: 1.0 References: <20210902151715.383678-1-f4bug@amsat.org> <20210902151715.383678-2-f4bug@amsat.org> In-Reply-To: <20210902151715.383678-2-f4bug@amsat.org> From: Warner Losh Date: Thu, 2 Sep 2021 14:09:42 -0600 Message-ID: Subject: Re: [PATCH 01/24] target/xtensa: Restrict do_transaction_failed() to sysemu To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="000000000000140ed505cb08c417" Received-SPF: none client-ip=2607:f8b0:4864:20::92a; envelope-from=wlosh@bsdimp.com; helo=mail-ua1-x92a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Bin Meng , Mark Cave-Ayland , QEMU Developers , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Marek Vasut , Yoshinori Sato , qemu-ppc , Artyom Tarasenko , Aleksandar Rikalo , Eduardo Habkost , Kyle Evans , Richard Henderson , Greg Kurz , qemu-arm , Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Chris Wulff , Laurent Vivier , Palmer Dabbelt , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000140ed505cb08c417 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 2, 2021 at 9:17 AM Philippe Mathieu-Daud=C3=A9 wrote: > The do_transaction_failed() is restricted to system emulation since > commit cbc183d2d9f ("cpu: move cc->transaction_failed to tcg_ops"). > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > Reviewed-by: Warner Losh > --- > target/xtensa/cpu.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu.h > index 2345cb59c79..1e0cb1535ca 100644 > --- a/target/xtensa/cpu.h > +++ b/target/xtensa/cpu.h > @@ -568,10 +568,12 @@ bool xtensa_cpu_tlb_fill(CPUState *cs, vaddr > address, int size, > bool probe, uintptr_t retaddr); > void xtensa_cpu_do_interrupt(CPUState *cpu); > bool xtensa_cpu_exec_interrupt(CPUState *cpu, int interrupt_request); > +#ifndef CONFIG_USER_ONLY > void xtensa_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr, > vaddr addr, > unsigned size, MMUAccessType > access_type, > int mmu_idx, MemTxAttrs attrs, > MemTxResult response, uintptr_t > retaddr); > +#endif /* !CONFIG_USER_ONLY */ > void xtensa_cpu_dump_state(CPUState *cpu, FILE *f, int flags); > hwaddr xtensa_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr); > void xtensa_count_regs(const XtensaConfig *config, > -- > 2.31.1 > > --000000000000140ed505cb08c417 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Sep 2, 2021 at 9:17 AM Philip= pe Mathieu-Daud=C3=A9 <f4bug@amsat.or= g> wrote:
The do_transaction_failed() is restricted to system emulation since
commit cbc183d2d9f ("cpu: move cc->transaction_failed to tcg_ops&qu= ot;).

Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>

<= /div>
Reviewed-by: Warner Losh <im= p@bsdimp.com>
=C2=A0
---
=C2=A0target/xtensa/cpu.h | 2 ++
=C2=A01 file changed, 2 insertions(+)

diff --git a/target/xtensa/cpu.h b/target/xtensa/cpu.h
index 2345cb59c79..1e0cb1535ca 100644
--- a/target/xtensa/cpu.h
+++ b/target/xtensa/cpu.h
@@ -568,10 +568,12 @@ bool xtensa_cpu_tlb_fill(CPUState *cs, vaddr address,= int size,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 bool probe, uintptr_t retaddr);
=C2=A0void xtensa_cpu_do_interrupt(CPUState *cpu);
=C2=A0bool xtensa_cpu_exec_interrupt(CPUState *cpu, int interrupt_request);=
+#ifndef CONFIG_USER_ONLY
=C2=A0void xtensa_cpu_do_transaction_failed(CPUState *cs, hwaddr physaddr, = vaddr addr,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned = size, MMUAccessType access_type,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0int mmu_i= dx, MemTxAttrs attrs,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0MemTxResu= lt response, uintptr_t retaddr);
+#endif /* !CONFIG_USER_ONLY */
=C2=A0void xtensa_cpu_dump_state(CPUState *cpu, FILE *f, int flags);
=C2=A0hwaddr xtensa_cpu_get_phys_page_debug(CPUState *cpu, vaddr addr);
=C2=A0void xtensa_count_regs(const XtensaConfig *config,
--
2.31.1

--000000000000140ed505cb08c417--