From: Warner Losh <imp@bsdimp.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Konrad Witaszczyk <def@freebsd.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Kyle Evans <kevans@freebsd.org>,
Jessica Clarke <jrtc27@freebsd.org>
Subject: Re: [PATCH v2 14/40] bsd-user/arm/target_arch_cpu.h: Use force_sig_fault for EXCP_UDEF
Date: Thu, 27 Jan 2022 08:40:14 -0700 [thread overview]
Message-ID: <CANCZdfrViur=kLPYpZQPpAKjHLvohZXe35q1v+T1AFSFZjSiMw@mail.gmail.com> (raw)
In-Reply-To: <8d876840-8743-0e8b-c477-ca8a6e067d8c@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Wed, Jan 26, 2022 at 11:27 PM Richard Henderson <
richard.henderson@linaro.org> wrote:
> On 1/25/22 12:29, Warner Losh wrote:
> > + case EXCP_NOCP:
> > + case EXCP_INVSTATE:
> > + /*
> > + * See arm/arm/undefined.c undefinedinstruction();
> > + *
> > + * A number of details aren't emulated (they likely don't
> matter):
> > + * o Misaligned PC generates ILL_ILLADR
>
> As I mentioned, misaligned pc will not come here for qemu.
> In the Arm ARM, see aarch32/functions/registers/BXWritePC:
>
> // For branches to an unaligned PC counter in A32 state, the processor
> takes the branch
> // and does one of:
> // * Forces the address to be aligned
> // * Leaves the PC unaligned, meaning the target generates a PC Alignment
> fault.
>
> The hardware will either refuse to allow bit 1 to be set when bit 0 is
> clear, OR it will
> generate a PREFETCH_DATA_ABORT for Alignment.
>
> QEMU will do the latter.
>
Ah, right. I'd meant to update the comments and it slipped my mind. I'll
note
that this can't happen in qemu.
>
> Otherwise,
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
Thanks for this (and all the other) review and feedback.
Warner
> r~
>
[-- Attachment #2: Type: text/html, Size: 2189 bytes --]
next prev parent reply other threads:[~2022-01-27 16:44 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 1:29 [PATCH v2 00/40] bsd-user: upstream our signal implementation Warner Losh
2022-01-25 1:29 ` [PATCH v2 01/40] bsd-user: Complete FreeBSD siginfo Warner Losh
2022-01-27 5:43 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 02/40] bsd-user: Create setup_sigframe_arch to setup sigframe context Warner Losh
2022-01-27 5:45 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 03/40] bsd-user/arm/signal.c: Implement setup_sigframe_arch for arm Warner Losh
2022-01-27 5:56 ` Richard Henderson
2022-01-27 16:42 ` Warner Losh
2022-01-25 1:29 ` [PATCH v2 04/40] bsd-user/arm/signal.c: get_mcontext should zero vfp data Warner Losh
2022-01-27 5:59 ` Richard Henderson
2022-01-27 15:44 ` Warner Losh
2022-01-25 1:29 ` [PATCH v2 05/40] bsd-user: Remove vestiges of signal queueing code Warner Losh
2022-01-27 6:16 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 06/40] bsd-user: Bring in docs from linux-user for signal_pending Warner Losh
2022-01-27 6:16 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 07/40] bsd-user/arm/target_arch_cpu.h: Move EXCP_ATOMIC to match linux-user Warner Losh
2022-01-25 1:29 ` [PATCH v2 08/40] bsd-user/signal.c: implement force_sig_fault Warner Losh
2022-01-25 1:29 ` [PATCH v2 09/40] bsd-user/signal-common.h: Move signal functions prototypes to here Warner Losh
2022-01-27 6:17 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 10/40] bsd-user/signal.c: Implement cpu_loop_exit_sigsegv Warner Losh
2022-01-25 1:29 ` [PATCH v2 11/40] bsd-user/signal.c: implement cpu_loop_exit_sigbus Warner Losh
2022-01-25 1:29 ` [PATCH v2 12/40] bsd-user/arm/arget_arch_cpu.h: Move EXCP_DEBUG and EXCP_BKPT together Warner Losh
2022-01-25 1:29 ` [PATCH v2 13/40] bsd-user/arm/target_arch_cpu.h: Correct code pointer Warner Losh
2022-01-25 1:29 ` [PATCH v2 14/40] bsd-user/arm/target_arch_cpu.h: Use force_sig_fault for EXCP_UDEF Warner Losh
2022-01-27 6:27 ` Richard Henderson
2022-01-27 15:40 ` Warner Losh [this message]
2022-01-25 1:29 ` [PATCH v2 15/40] bsd-user/arm/target_arch_cpu.h: Implement data faults Warner Losh
2022-01-25 1:29 ` [PATCH v2 16/40] bsd-user/signal.c: implement abstract target / host signal translation Warner Losh
2022-01-27 6:29 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 17/40] bsd-user/signal.c: Implement signal_init() Warner Losh
2022-01-25 1:29 ` [PATCH v2 18/40] bsd-user/signal.c: Add si_type argument to queue_signal Warner Losh
2022-01-27 6:38 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 19/40] bsd-user/host/arm/host-signal.h: Implement host_signal_* Warner Losh
2022-01-27 6:38 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 20/40] bsd-user/host/i386/host-signal.h: " Warner Losh
2022-01-25 1:29 ` [PATCH v2 21/40] bsd-user/host/x86_64/host-signal.h: " Warner Losh
2022-01-25 1:29 ` [PATCH v2 22/40] bsd-user: Add host signals to the build Warner Losh
2022-01-25 1:29 ` [PATCH v2 23/40] bsd-user: Add trace events for bsd-user Warner Losh
2022-01-25 1:29 ` [PATCH v2 24/40] bsd-user/signal.c: host_to_target_siginfo_noswap Warner Losh
2022-01-27 7:40 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 25/40] bsd-user/signal.c: Implement rewind_if_in_safe_syscall Warner Losh
2022-01-25 1:29 ` [PATCH v2 26/40] bsd-user/signal.c: Implement host_signal_handler Warner Losh
2022-01-27 7:42 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 27/40] bsd-user/strace.c: print_taken_signal Warner Losh
2022-01-25 1:29 ` [PATCH v2 28/40] bsd-user/signal.c: Implement dump_core_and_abort Warner Losh
2022-01-25 1:29 ` [PATCH v2 29/40] bsd-user/signal.c: Fill in queue_signal Warner Losh
2022-01-27 7:44 ` Richard Henderson
2022-01-27 15:34 ` Warner Losh
2022-01-25 1:29 ` [PATCH v2 30/40] bsd-user/signal.c: sigset manipulation routines Warner Losh
2022-01-27 7:45 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 31/40] bsd-user/signal.c: setup_frame Warner Losh
2022-01-27 7:47 ` Richard Henderson
2022-01-27 15:30 ` Warner Losh
2022-01-25 1:29 ` [PATCH v2 32/40] bsd-user/signal.c: handle_pending_signal Warner Losh
2022-01-27 7:51 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 33/40] bsd-user/signal.c: tswap_siginfo Warner Losh
2022-01-27 7:52 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 34/40] bsd-user/signal.c: process_pending_signals Warner Losh
2022-01-27 7:54 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 35/40] bsd-user/signal.c: implement do_sigreturn Warner Losh
2022-01-27 23:05 ` Warner Losh
2022-01-25 1:29 ` [PATCH v2 36/40] bsd-user/signal.c: implement do_sigaction Warner Losh
2022-01-27 22:46 ` Warner Losh
2022-01-28 10:37 ` Peter Maydell
2022-01-25 1:29 ` [PATCH v2 37/40] bsd-user/signal.c: do_sigaltstack Warner Losh
2022-01-27 8:00 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 38/40] MAINTAINERS: Add tests/vm/*bsd to the list to get reviews on Warner Losh
2022-01-27 8:00 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 39/40] bsd-user: Rename arg name for target_cpu_reset to env Warner Losh
2022-01-27 8:00 ` Richard Henderson
2022-01-25 1:29 ` [PATCH v2 40/40] bsd-user/freebsd/target_os_ucontext.h: Prefer env as arg name for CPUArchState args Warner Losh
2022-01-27 8:00 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANCZdfrViur=kLPYpZQPpAKjHLvohZXe35q1v+T1AFSFZjSiMw@mail.gmail.com' \
--to=imp@bsdimp.com \
--cc=def@freebsd.org \
--cc=jrtc27@freebsd.org \
--cc=kevans@freebsd.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).