Re: [PATCH] user: Mark cpu_loop() with noreturn attribute

[Warner Losh <imp@bsdimp.com>]

[-- Attachment #1: Type: text/plain, Size: 1560 bytes --]

On Sat, Sep 4, 2021 at 6:04 PM Philippe Mathieu-Daudé <f4bug@amsat.org>
wrote:

> cpu_loop() never exits, so mark it with QEMU_NORETURN.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  bsd-user/qemu.h   | 2 +-
>  linux-user/qemu.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-By: Warner Losh <imp@bsdimp.com>


diff --git a/bsd-user/qemu.h b/bsd-user/qemu.h
> index c02e8a5ca1a..05bee7aefe5 100644
> --- a/bsd-user/qemu.h
> +++ b/bsd-user/qemu.h
> @@ -155,7 +155,7 @@ abi_long do_openbsd_syscall(void *cpu_env, int num,
> abi_long arg1,
>                              abi_long arg5, abi_long arg6);
>  void gemu_log(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
>  extern THREAD CPUState *thread_cpu;
> -void cpu_loop(CPUArchState *env);
> +void QEMU_NORETURN cpu_loop(CPUArchState *env);
>  char *target_strerror(int err);
>  int get_osversion(void);
>  void fork_start(void);
> diff --git a/linux-user/qemu.h b/linux-user/qemu.h
> index 3b0b6b75fe8..5b2c764ae78 100644
> --- a/linux-user/qemu.h
> +++ b/linux-user/qemu.h
> @@ -236,7 +236,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
> arg1,
>                      abi_long arg5, abi_long arg6, abi_long arg7,
>                      abi_long arg8);
>  extern __thread CPUState *thread_cpu;
> -void cpu_loop(CPUArchState *env);
> +void QEMU_NORETURN cpu_loop(CPUArchState *env);
>  const char *target_strerror(int err);
>  int get_osversion(void);
>  void init_qemu_uname_release(void);
> --
> 2.31.1
>
>

[-- Attachment #2: Type: text/html, Size: 2258 bytes --]