From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kernellwp@gmail.com>) id 1bk1BJ-0001Z9-E8
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:48:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kernellwp@gmail.com>) id 1bk1BE-00027s-Cl
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:48:16 -0400
Received: from mail-wm0-f65.google.com ([74.125.82.65]:35849)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kernellwp@gmail.com>) id 1bk1BE-00027f-5o
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 23:48:12 -0400
Received: by mail-wm0-f65.google.com with SMTP id b184so521438wma.3
	for <qemu-devel@nongnu.org>; Tue, 13 Sep 2016 20:48:12 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20160914034051.GD15357@lemon>
References: <1473822299-6302-1-git-send-email-wanpeng.li@hotmail.com>
	<20160914032140.19908.55883@ex-std-node742.prod.rhcloud.com>
	<20160914034051.GD15357@lemon>
From: Wanpeng Li <kernellwp@gmail.com>
Date: Wed, 14 Sep 2016 11:47:10 +0800
Message-ID: <CANRm+CzhW5snhw2KiArfT5OF0ziWJnMeOqcSMuVQtNxspGECpw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is
 split
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Eduardo Habkost <ehabkost@redhat.com>, kvm <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Radim Krcmar <rkrcmar@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Wanpeng Li <wanpeng.li@hotmail.com>

2016-09-14 11:40 GMT+08:00 Fam Zheng <famz@redhat.com>:
> On Tue, 09/13 20:21, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
>> Hi,
>>
>> Your series seems to have some coding style problems. See output below for
>> more information:
>>
>> Type: series
>> Message-id: 1473822299-6302-1-git-send-email-wanpeng.li@hotmail.com
>> Subject: [Qemu-devel] [PATCH] pc: apic: fix touch LAPIC when irqchip is split
>>
>> === TEST SCRIPT BEGIN ===
>> #!/bin/bash
>>
>> BASE=base
>> n=1
>> total=$(git log --oneline $BASE.. | wc -l)
>> failed=0
>>
>> # Useful git options
>> git config --local diff.renamelimit 0
>> git config --local diff.renames True
>>
>> commits="$(git log --format=%H --reverse $BASE..)"
>> for c in $commits; do
>>     echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
>>     if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
>>         failed=1
>>         echo
>>     fi
>>     n=$((n+1))
>> done
>>
>> exit $failed
>> === TEST SCRIPT END ===
>>
>> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
>> Switched to a new branch 'test'
>> 9bcacc6 pc: apic: fix touch LAPIC when irqchip is split
>>
>> === OUTPUT BEGIN ===
>> Checking PATCH 1/1: pc: apic: fix touch LAPIC when irqchip is split...
>> ERROR: suspect code indent for conditional statements (4, 9)
>> #90: FILE: hw/i386/pc.c:164:
>> +    if (!kvm_irqchip_in_kernel()) {
>> +         intno = apic_get_interrupt(cpu->apic_state);
>        ^^^^^
> Should be 4 spaces here.
>
>>
>> ERROR: suspect code indent for conditional statements (9, 13)
>> #92: FILE: hw/i386/pc.c:166:
>> +         if (intno >= 0) {
>> +             return intno;
>
> Then this and later will be indented back by 1 column.

You are right, thanks Fam.

Regards,
Wanpeng Li