From: Ricardo Ribalda <ribalda@chromium.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-devel@nongnu.org, Andrea Righi <andrea.righi@canonical.com>
Subject: Re: [PATCH v3 1/3] tests/acpi: pc: allow DSDT acpi table changes
Date: Fri, 28 Jun 2024 19:06:23 +0200 [thread overview]
Message-ID: <CANiDSCv0CoR1vZJ0WXt6=84HBXRC_y2E6AAXANMLLThonCpK2w@mail.gmail.com> (raw)
In-Reply-To: <20240628132542.47b5a137@imammedo.users.ipa.redhat.com>
Hi Igor
On Fri, 28 Jun 2024 at 13:25, Igor Mammedov <imammedo@redhat.com> wrote:
>
> On Fri, 7 Jun 2024 14:17:24 +0000
> Ricardo Ribalda <ribalda@chromium.org> wrote:
>
> > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> > ---
> > tests/qtest/bios-tables-test-allowed-diff.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index dfb8523c8b..b2c2c10cbc 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1 +1,2 @@
> > /* List of comma-separated changed AML files to ignore */
> > +"tests/data/acpi/pc/DSDT",
>
> that's no enough, a lot more tables expected blobs are affected by
> the next patch.
>
Sorry about that, I did not realise that the check was quitting after
the first different file was found.
will post a new version soon
Thanks!
>
> before posting, make sure that 'make check-qtest' passes fine
>
--
Ricardo Ribalda
next prev parent reply other threads:[~2024-06-28 17:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 14:17 [PATCH v3 0/3] hw/i386/acpi: Pre-compute the _PRT table Ricardo Ribalda
2024-06-07 14:17 ` [PATCH v3 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
2024-06-28 11:25 ` Igor Mammedov
2024-06-28 17:06 ` Ricardo Ribalda [this message]
2024-06-07 14:17 ` [PATCH v3 2/3] hw/i386/acpi-build: Return a pre-computed _PRT table Ricardo Ribalda
2024-06-28 11:23 ` Igor Mammedov
2024-06-07 14:17 ` [PATCH v3 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiDSCv0CoR1vZJ0WXt6=84HBXRC_y2E6AAXANMLLThonCpK2w@mail.gmail.com' \
--to=ribalda@chromium.org \
--cc=andrea.righi@canonical.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).