qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Fix WinXP ISO boot using the dc390/am53C974 SCSI device
@ 2024-09-24 13:24 Ricardo Ribalda
  2024-09-24 13:24 ` [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Ricardo Ribalda @ 2024-09-24 13:24 UTC (permalink / raw)
  To: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Marcel Apfelbaum,
	Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-devel,
	Mark Cave-Ayland
  Cc: Ricardo Ribalda

Mark Cave-Ayland reported that after landing the pre-computed _PRT, the
above mentioned testcase failed to pass.

It seems that it is due to WinXP not handling properly a variable
package. Let's replace it.


Unfortunately, the ASL diff is not the best (or I cannot produce
something better):

12c12
<  *     Length           0x00003917 (14615)
---
>  *     Length           0x00003914 (14612)
14c14
<  *     Checksum         0xD9
---
>  *     Checksum         0x09

Diff v1:
  - Add assert(), Thanks Igor

Ricardo Ribalda (3):
  tests/acpi: pc: allow DSDT acpi table changes
  hw/i386/acpi-build: return a non-var package from _PRT()
  tests/acpi: pc: update golden masters for DSDT

 hw/i386/acpi-build.c                 |   3 ++-
 tests/data/acpi/x86/pc/DSDT          | Bin 8527 -> 8526 bytes
 tests/data/acpi/x86/pc/DSDT.acpierst | Bin 8438 -> 8437 bytes
 tests/data/acpi/x86/pc/DSDT.acpihmat | Bin 9852 -> 9851 bytes
 tests/data/acpi/x86/pc/DSDT.bridge   | Bin 15398 -> 15397 bytes
 tests/data/acpi/x86/pc/DSDT.cphp     | Bin 8991 -> 8990 bytes
 tests/data/acpi/x86/pc/DSDT.dimmpxm  | Bin 10181 -> 10180 bytes
 tests/data/acpi/x86/pc/DSDT.hpbridge | Bin 8478 -> 8477 bytes
 tests/data/acpi/x86/pc/DSDT.hpbrroot | Bin 5034 -> 5033 bytes
 tests/data/acpi/x86/pc/DSDT.ipmikcs  | Bin 8599 -> 8598 bytes
 tests/data/acpi/x86/pc/DSDT.memhp    | Bin 9886 -> 9885 bytes
 tests/data/acpi/x86/pc/DSDT.nohpet   | Bin 8385 -> 8384 bytes
 tests/data/acpi/x86/pc/DSDT.numamem  | Bin 8533 -> 8532 bytes
 tests/data/acpi/x86/pc/DSDT.roothp   | Bin 12320 -> 12319 bytes
 tests/data/acpi/x86/q35/DSDT.cxl     | Bin 13148 -> 13146 bytes
 tests/data/acpi/x86/q35/DSDT.viot    | Bin 14615 -> 14612 bytes
 16 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.46.0.792.g87dc391469-goog



^ permalink raw reply	[flat|nested] 11+ messages in thread
* [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes
@ 2024-06-07  8:58 Ricardo Ribalda
  2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
  0 siblings, 1 reply; 11+ messages in thread
From: Ricardo Ribalda @ 2024-06-07  8:58 UTC (permalink / raw)
  To: Michael S. Tsirkin, Igor Mammedov, Ani Sinha, Marcel Apfelbaum,
	Paolo Bonzini, Richard Henderson, Eduardo Habkost, qemu-devel,
	Andrea Righi
  Cc: Ricardo Ribalda

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 tests/qtest/bios-tables-test-allowed-diff.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..b2c2c10cbc 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@
 /* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT",
-- 
2.45.2.505.gda0bf45e8d-goog



^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-11-04 14:22 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 13:24 [PATCH v2 0/3] Fix WinXP ISO boot using the dc390/am53C974 SCSI device Ricardo Ribalda
2024-09-24 13:24 ` [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
2024-09-24 14:11   ` Igor Mammedov
2024-09-24 13:24 ` [PATCH v2 2/3] hw/i386/acpi-build: return a non-var package from _PRT() Ricardo Ribalda
2024-09-24 13:24 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
2024-09-24 14:22   ` Igor Mammedov
2024-11-04 13:46   ` Michael S. Tsirkin
2024-11-04 14:00     ` Ricardo Ribalda
2024-11-04 14:21       ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2024-06-07  8:58 [PATCH v2 1/3] tests/acpi: pc: allow DSDT acpi table changes Ricardo Ribalda
2024-06-07  8:58 ` [PATCH v2 3/3] tests/acpi: pc: update golden masters for DSDT Ricardo Ribalda
2024-06-07  9:33   ` Michael S. Tsirkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).