* [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name
@ 2018-11-07 21:51 Alistair Francis
2018-11-08 2:38 ` Palmer Dabbelt
2018-11-08 18:58 ` Palmer Dabbelt
0 siblings, 2 replies; 5+ messages in thread
From: Alistair Francis @ 2018-11-07 21:51 UTC (permalink / raw)
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, palmer@sifive.com
Cc: Alistair Francis, alistair23@gmail.com
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
---
hw/riscv/virt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 4a137a503c..2b38f89070 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -240,6 +240,7 @@ static void *create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap,
qemu_fdt_setprop_cells(fdt, nodename, "reg",
0x0, memmap[VIRT_TEST].base,
0x0, memmap[VIRT_TEST].size);
+ g_free(nodename);
nodename = g_strdup_printf("/uart@%lx",
(long)memmap[VIRT_UART0].base);
--
2.19.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name
2018-11-07 21:51 [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name Alistair Francis
@ 2018-11-08 2:38 ` Palmer Dabbelt
2018-11-08 18:37 ` Alistair Francis
2018-11-08 18:58 ` Palmer Dabbelt
1 sibling, 1 reply; 5+ messages in thread
From: Palmer Dabbelt @ 2018-11-08 2:38 UTC (permalink / raw)
Cc: qemu-devel, qemu-riscv, Alistair Francis, alistair23
On Wed, 07 Nov 2018 13:51:45 PST (-0800), Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> hw/riscv/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 4a137a503c..2b38f89070 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -240,6 +240,7 @@ static void *create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap,
> qemu_fdt_setprop_cells(fdt, nodename, "reg",
> 0x0, memmap[VIRT_TEST].base,
> 0x0, memmap[VIRT_TEST].size);
> + g_free(nodename);
>
> nodename = g_strdup_printf("/uart@%lx",
> (long)memmap[VIRT_UART0].base);
> --
> 2.19.1
Thanks. I got a bit behind this week so I didn't send the pre-PR, but I indent
to send a PR tomorrow. That PR currently only contains this patch.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name
2018-11-08 2:38 ` Palmer Dabbelt
@ 2018-11-08 18:37 ` Alistair Francis
2018-11-08 18:50 ` Palmer Dabbelt
0 siblings, 1 reply; 5+ messages in thread
From: Alistair Francis @ 2018-11-08 18:37 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: Alistair Francis, qemu-devel@nongnu.org Developers, qemu-riscv
On Wed, Nov 7, 2018 at 6:38 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>
> On Wed, 07 Nov 2018 13:51:45 PST (-0800), Alistair Francis wrote:
> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> > ---
> > hw/riscv/virt.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> > index 4a137a503c..2b38f89070 100644
> > --- a/hw/riscv/virt.c
> > +++ b/hw/riscv/virt.c
> > @@ -240,6 +240,7 @@ static void *create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap,
> > qemu_fdt_setprop_cells(fdt, nodename, "reg",
> > 0x0, memmap[VIRT_TEST].base,
> > 0x0, memmap[VIRT_TEST].size);
> > + g_free(nodename);
> >
> > nodename = g_strdup_printf("/uart@%lx",
> > (long)memmap[VIRT_UART0].base);
> > --
> > 2.19.1
>
> Thanks. I got a bit behind this week so I didn't send the pre-PR, but I indent
> to send a PR tomorrow. That PR currently only contains this patch.
There should be two patches. One for spike and one for the virt machine.
Alistair
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name
2018-11-08 18:37 ` Alistair Francis
@ 2018-11-08 18:50 ` Palmer Dabbelt
0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-11-08 18:50 UTC (permalink / raw)
To: alistair23; +Cc: Alistair Francis, qemu-devel, qemu-riscv
On Thu, 08 Nov 2018 10:37:28 PST (-0800), alistair23@gmail.com wrote:
> On Wed, Nov 7, 2018 at 6:38 PM Palmer Dabbelt <palmer@sifive.com> wrote:
>>
>> On Wed, 07 Nov 2018 13:51:45 PST (-0800), Alistair Francis wrote:
>> > Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
>> > ---
>> > hw/riscv/virt.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
>> > index 4a137a503c..2b38f89070 100644
>> > --- a/hw/riscv/virt.c
>> > +++ b/hw/riscv/virt.c
>> > @@ -240,6 +240,7 @@ static void *create_fdt(RISCVVirtState *s, const struct MemmapEntry *memmap,
>> > qemu_fdt_setprop_cells(fdt, nodename, "reg",
>> > 0x0, memmap[VIRT_TEST].base,
>> > 0x0, memmap[VIRT_TEST].size);
>> > + g_free(nodename);
>> >
>> > nodename = g_strdup_printf("/uart@%lx",
>> > (long)memmap[VIRT_UART0].base);
>> > --
>> > 2.19.1
>>
>> Thanks. I got a bit behind this week so I didn't send the pre-PR, but I indent
>> to send a PR tomorrow. That PR currently only contains this patch.
>
> There should be two patches. One for spike and one for the virt machine.
Oh, sorry about that -- I thought they were the same patch!
Peter: let me know if you want me to submit a new copy of this PR with both
patches or a follow-on PR. Sorry for the noise!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name
2018-11-07 21:51 [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name Alistair Francis
2018-11-08 2:38 ` Palmer Dabbelt
@ 2018-11-08 18:58 ` Palmer Dabbelt
1 sibling, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-11-08 18:58 UTC (permalink / raw)
To: Alistair Francis; +Cc: qemu-devel, qemu-riscv, alistair23
On Wed, Nov 7, 2018 at 1:52 PM Alistair Francis <Alistair.Francis@wdc.com>
wrote:
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> hw/riscv/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
> index 4a137a503c..2b38f89070 100644
> --- a/hw/riscv/virt.c
> +++ b/hw/riscv/virt.c
> @@ -240,6 +240,7 @@ static void *create_fdt(RISCVVirtState *s, const
> struct MemmapEntry *memmap,
> qemu_fdt_setprop_cells(fdt, nodename, "reg",
> 0x0, memmap[VIRT_TEST].base,
> 0x0, memmap[VIRT_TEST].size);
> + g_free(nodename);
>
> nodename = g_strdup_printf("/uart@%lx",
> (long)memmap[VIRT_UART0].base);
> --
> 2.19.1
>
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-08 19:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-07 21:51 [Qemu-devel] [PATCH for 3.1 v1 1/1] hw/riscv/virt: Free the test device tree node name Alistair Francis
2018-11-08 2:38 ` Palmer Dabbelt
2018-11-08 18:37 ` Alistair Francis
2018-11-08 18:50 ` Palmer Dabbelt
2018-11-08 18:58 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).