From: "Philippe Mathieu-Daudé" <philmd@fungible.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"David Daney" <david.daney@fungible.com>,
"Marcin Nowakowski" <marcin.nowakowski@fungible.com>
Subject: Re: [PATCH] disas/mips: Fix branch displacement for BEQZC and BNEZC
Date: Fri, 14 Oct 2022 13:17:54 +0200 [thread overview]
Message-ID: <CANsZoG9JZd+JQNNMDkCAg-LoJcYsSOTmeWon1ZN6P8Ew0OBp2g@mail.gmail.com> (raw)
In-Reply-To: <423f0bd9-8c43-46fb-04a5-292e8385b69a@linaro.org>
On Thu, Oct 13, 2022 at 9:26 PM Richard Henderson
<richard.henderson@linaro.org> wrote:
> On 10/14/22 07:52, Philippe Mathieu-Daudé wrote:
> > + /* Sign extend the displacement with 21 bits. */
> > + delta = l & 0x1FFFFF;
> > + if (delta & 0x100000) {
> > + delta |= ~0x1FFFFF;
> > + }
Note this follows the style of this file, ...
> delta = sextract32(l, 0, 21);
... but I agree using sextract() makes it easier to review. I'll respin.
prev parent reply other threads:[~2022-10-14 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 14:52 [PATCH] disas/mips: Fix branch displacement for BEQZC and BNEZC Philippe Mathieu-Daudé
2022-10-13 19:26 ` Richard Henderson
2022-10-14 11:17 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANsZoG9JZd+JQNNMDkCAg-LoJcYsSOTmeWon1ZN6P8Ew0OBp2g@mail.gmail.com \
--to=philmd@fungible.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=david.daney@fungible.com \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=marcin.nowakowski@fungible.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).