From: Austin Conatser <austin@amass.space>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com
Subject: [PATCH] hw/i386/amd_iommu: Fix remapping of APIC registers
Date: Sun, 3 Apr 2022 20:19:07 -0400 [thread overview]
Message-ID: <CAO7oc52NECtz_0xQgyezgp9A-J-9Vvv8xUP92aTizCHKh550fA@mail.gmail.com> (raw)
Changes the check from only allowing the APIC base address to
allowing the entire APIC address space.
Signed-off-by: Austin Conatser <austin@amass.space>
---
hw/i386/amd_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c
index ea8eaeb330..61b7416d50 100644
--- a/hw/i386/amd_iommu.c
+++ b/hw/i386/amd_iommu.c
@@ -1248,7 +1248,7 @@ static int amdvi_int_remap_msi(AMDVIState *iommu,
return -AMDVI_IR_ERR;
}
- if ((origin->address & AMDVI_MSI_ADDR_LO_MASK) != APIC_DEFAULT_ADDRESS) {
+ if (!amdvi_is_interrupt_addr(origin->address & AMDVI_MSI_ADDR_LO_MASK)) {
trace_amdvi_err("MSI is not from IOAPIC.");
return -AMDVI_IR_ERR;
}
--
2.34.1
reply other threads:[~2022-04-04 0:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO7oc52NECtz_0xQgyezgp9A-J-9Vvv8xUP92aTizCHKh550fA@mail.gmail.com \
--to=austin@amass.space \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).