From: Patrick Venture <venture@google.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org, kfting@nuvoton.com, wuhaotsh@google.com
Subject: Re: [PATCH] hw/gpio: npcm7xx: fixup out-of-bounds access
Date: Wed, 26 Feb 2025 08:16:25 -0800 [thread overview]
Message-ID: <CAO=notzbY3wR+=gKeCS70ZpMAzhPZ-M4MHTF0MBP-GKMWXf_UQ@mail.gmail.com> (raw)
In-Reply-To: <f4b1dfc6-5265-400b-8842-349668c8e972@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 945 bytes --]
On Tue, Feb 25, 2025 at 11:04 PM Philippe Mathieu-Daudé <philmd@linaro.org>
wrote:
> On 26/2/25 03:46, Patrick Venture wrote:
> > The reg isn't validated to be a possible register before
> > it's dereferenced for one case. The mmio space registered
> > for the gpio device is 4KiB but there aren't that many
> > registers in the struct.
> >
> > Google-Bug-Id: 397469048
> > Change-Id: I2fb8d0d3d41422baab22e8fc7e9fadd0f2ee7068
>
> ^ Both lines are irrelevant on mainstream git history, otherwise:
>
Thanks, sorry, I was in a hurry last night to send this out and forgot to
strip them.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Cc: qemu-stable@nongnu.org
> Fixes: 526dbbe0874 ("hw/gpio: Add GPIO model for Nuvoton NPCM7xx")
>
> > Signed-off-by: Patrick Venture <venture@google.com>
> > ---
> > hw/gpio/npcm7xx_gpio.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
[-- Attachment #2: Type: text/html, Size: 1717 bytes --]
next prev parent reply other threads:[~2025-02-26 16:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 2:46 [PATCH] hw/gpio: npcm7xx: fixup out-of-bounds access Patrick Venture
2025-02-26 7:03 ` Philippe Mathieu-Daudé
2025-02-26 16:16 ` Patrick Venture [this message]
2025-03-03 14:11 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO=notzbY3wR+=gKeCS70ZpMAzhPZ-M4MHTF0MBP-GKMWXf_UQ@mail.gmail.com' \
--to=venture@google.com \
--cc=kfting@nuvoton.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wuhaotsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).