From: Roman Kiryanov <rkir@google.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: "Felix Wu" <flwu@google.com>,
qemu-devel@nongnu.org, peter.maydell@linaro.org,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: Re: [PATCH 1/1] include/qemu: Provide a C++ compatible version of typeof_strip_qual
Date: Mon, 24 Jun 2024 19:32:00 -0700 [thread overview]
Message-ID: <CAOGAQeq0b3_g80k5xa-6f+XPkv6C=nfMLkJt=X3-6FD_d3sJUA@mail.gmail.com> (raw)
In-Reply-To: <8e54bd41-9a7e-4b1e-ad99-33de1615374c@linaro.org>
Hi Philippe, thank you for looking.
On Mon, Jun 24, 2024 at 7:27 PM Philippe Mathieu-Daudé
<philmd@linaro.org> wrote:
> In particular this patch seems contained well enough
> to be carried in forks were C++ _is_ used.
Will you agree to take #ifdef __cplusplus and #error to the QEMU side
in atomic.h and
we will keep atomic.hpp on our side? The error message looks better
when atomic.hpp
is somewhere near.
Regards,
Roman.
next prev parent reply other threads:[~2024-06-25 2:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 20:56 [PATCH 1/1] include/qemu: Provide a C++ compatible version of typeof_strip_qual Felix Wu
2024-06-25 2:26 ` Philippe Mathieu-Daudé
2024-06-25 2:32 ` Roman Kiryanov [this message]
2024-06-25 6:05 ` Paolo Bonzini
2024-06-25 6:19 ` Philippe Mathieu-Daudé
2024-06-25 9:27 ` Peter Maydell
2024-06-25 10:16 ` Peter Maydell
2024-06-25 10:31 ` Daniel P. Berrangé
2024-06-25 6:07 ` Thomas Huth
2024-06-25 7:52 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOGAQeq0b3_g80k5xa-6f+XPkv6C=nfMLkJt=X3-6FD_d3sJUA@mail.gmail.com' \
--to=rkir@google.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=flwu@google.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).