qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: 858585 jemmy <jemmy858585@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, dgilbert@redhat.com,
	Fam Zheng <famz@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	quintela@redhat.com
Subject: Re: [Qemu-devel] migrate -b problems
Date: Wed, 12 Apr 2017 17:51:23 +0800	[thread overview]
Message-ID: <CAOGPPbfkZ5qJC-YkeBs+LLdn88VTvij_Xk8_FEpaNmg_pyXVVA@mail.gmail.com> (raw)
In-Reply-To: <20170412091819.GB4955@noname.str.redhat.com>

it this bug?
https://bugs.launchpad.net/qemu/+bug/1681688

On Wed, Apr 12, 2017 at 5:18 PM, Kevin Wolf <kwolf@redhat.com> wrote:
> Hi all,
>
> after getting assertion failure reports for block migration in the last
> minute, we just hacked around it by commenting out op blocker assertions
> for the 2.9 release, but now we need to see how to fix things properly.
> Luckily, get_maintainer.pl doesn't report me, but only you. :-)
>
> The main problem I see with the block migration code (on the
> destination) is that it abuses the BlockBackend that belongs to the
> guest device to make its own writes to the image file. If the guest
> isn't allowed to write to the image (which it now isn't during incoming
> migration since it would conflict with the newer style of block
> migration using an NBD server), writing to this BlockBackend doesn't
> work any more.
>
> So what should really happen is that incoming block migration creates
> its own BlockBackend for writing to the image. Now we don't want to do
> this anew for every incoming block, but ideally we'd just create all
> necessary BlockBackends upfront and then keep using them throughout the
> whole migration. Is there a way to get some setup/teardown callbacks
> at the start/end of the migration that could initialise and free such
> global data?
>
> The other problem with block migration is that is uses a BlockBackend
> name to identify which device is migrated. However, there can be images
> that are not attached to any BlockBackend, or if it is, the BlockBackend
> might be anonymous, so this doesn't work. I suppose changing the field
> to "device name if available, node-name otherwise" would solve this.
>
> Kevin
>

  reply	other threads:[~2017-04-12  9:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12  9:18 [Qemu-devel] migrate -b problems Kevin Wolf
2017-04-12  9:51 ` 858585 jemmy [this message]
2017-04-18 14:40   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-18 12:22 ` [Qemu-devel] " Juan Quintela
2017-04-18 14:47 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-04-18 15:32   ` Kevin Wolf
2017-04-19  9:14     ` Stefan Hajnoczi
2017-04-19 11:13     ` Dr. David Alan Gilbert
2017-04-19 11:18       ` Juan Quintela
2017-04-19 11:20         ` Dr. David Alan Gilbert
2017-04-19 11:55           ` Juan Quintela
2017-04-19 12:32       ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOGPPbfkZ5qJC-YkeBs+LLdn88VTvij_Xk8_FEpaNmg_pyXVVA@mail.gmail.com \
    --to=jemmy858585@gmail.com \
    --cc=dgilbert@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).