From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3TDL-000363-6i for qemu-devel@nongnu.org; Mon, 20 Aug 2012 10:44:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3TDF-0001PK-PV for qemu-devel@nongnu.org; Mon, 20 Aug 2012 10:44:23 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]:61658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3TDF-0001P4-Jp for qemu-devel@nongnu.org; Mon, 20 Aug 2012 10:44:17 -0400 Received: by vcbgb23 with SMTP id gb23so4810132vcb.4 for ; Mon, 20 Aug 2012 07:44:16 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <50323926.8000205@redhat.com> References: <1345453404-15244-1-git-send-email-mc@linux.vnet.ibm.com> <50323926.8000205@redhat.com> Date: Mon, 20 Aug 2012 22:44:16 +0800 Message-ID: From: McPacino Content-Type: multipart/alternative; boundary=f46d043890c54af01004c7b38bc3 Subject: Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: stefanha@linux.vnet.ibm.com, zwanp@cn.ibm.com, linuxram@us.ibm.com, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Cong Meng --f46d043890c54af01004c7b38bc3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =E5=9C=A8 2012-8-20 =E4=B8=8B=E5=8D=889:18=EF=BC=8C"Paolo Bonzini" =E5=86=99=E9=81=93=EF=BC=9A > > Il 20/08/2012 11:03, Cong Meng ha scritto: > > Each virtio scsi HBA has global request queue limits. But the passthrough > > LUNs (scsi-generic) come from different host HBAs may have different request > > queue limits. If the guest sends commands that exceed the host limits, the > > commands will be rejected by host HAB. > > > > To address this issue, this patch adds a per-LUN parameter query via the control > > queue, and defines some parameter query types. The driver can query and set the > > needed per-LUN parameters if the device enables this feature. > > > > Signed-off-by: Cong Meng > > -- > > virtio-spec.lyx | 218 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 files changed, 218 insertions(+), 0 deletions(-) > > Do you have kernel and QEMU patches for this? That would help me > evaluate whether the interface is the correct one. > yes,I have a demo. I will post it after I polish it tomorrow. > In any case, I'd rather have a single command returning all three values > (VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you need just > one. I intend to seperat them one by one. As there is opportunity that other new parameters are needed for other features. Thanks. Cong. > > Paolo > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization --f46d043890c54af01004c7b38bc3 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


=E5=9C=A8 2012-8-20 =E4=B8=8B=E5=8D=889:18=EF=BC=8C"Paolo Bonzini"= ; <pbonzini@redhat.com>=E5= =86=99=E9=81=93=EF=BC=9A
>
> Il 20/08/2012 11:03, Cong Meng ha scritto:
> > Each virtio scsi HBA has global request queue limits. But the pas= sthrough
> > LUNs (scsi-generic) come from different host HBAs may have differ= ent request
> > queue limits. If the guest sends commands that exceed the host li= mits, the
> > commands will be rejected by host HAB.
> >
> > To address this issue, this patch adds a per-LUN parameter query = via the control
> > queue, and defines some parameter query types. The driver can que= ry and set the
> > needed per-LUN parameters if the device enables this feature.
> >
> > Signed-off-by: Cong Meng <mc@linux.vnet.ibm.com>
> > --
> > =C2=A0virtio-spec.lyx | =C2=A0218 +++++++++++++++++++++++++++++++= ++++++++++++++++++++++++
> > =C2=A01 files changed, 218 insertions(+), 0 deletions(-)
>
> Do you have kernel and QEMU patches for this? =C2=A0That would help me=
> evaluate whether the interface is the correct one.
>
yes,I have a demo. I will post it after I polish it tomorrow.

> In any case, I'd rather have a single command retur= ning all three values
> (VIRTIO_SCSI_T_LUN_QUEUE_PARAMS), since it's unlikely that you nee= d just
> one.

I intend to seperat them one by one. As there is opportunity= that other new parameters are needed for other features.

Thanks.
Cong.

>
> Paolo
> _______________________________________________
> Virtualization mailing list
> Virtualiz= ation@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization

--f46d043890c54af01004c7b38bc3--