From: Yongji Xie <elohimes@gmail.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Xie Yongji <xieyongji@baidu.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/5] virtio: Set "start_on_kick" for legacy devices
Date: Wed, 5 Jun 2019 15:16:28 +0800 [thread overview]
Message-ID: <CAONzpcaw_KbtW5Y1KQd_Mo-gYPtydxRLwRVh0sUkk9a7BUQ+qw@mail.gmail.com> (raw)
In-Reply-To: <20190605091401.5177daca@bahia.lab.toulouse-stg.fr.ibm.com>
On Wed, 5 Jun 2019 at 15:14, Greg Kurz <groug@kaod.org> wrote:
>
> On Wed, 5 Jun 2019 14:49:34 +0800
> Yongji Xie <elohimes@gmail.com> wrote:
>
> > On Wed, 5 Jun 2019 at 14:42, Greg Kurz <groug@kaod.org> wrote:
> > >
> > > On Tue, 4 Jun 2019 15:34:56 +0800
> > > elohimes@gmail.com wrote:
> > >
> > > > From: Xie Yongji <xieyongji@baidu.com>
> > > >
> > > > Besides virtio 1.0 transitional devices, we should also
> > > > set "start_on_kick" flag for legacy devices (virtio 0.9).
> > > >
> > > > Signed-off-by: Xie Yongji <xieyongji@baidu.com>
> > > > ---
> > >
> > > Patch looks good but it would be even better if applied
> > > earlier so that it doesn't revert lines added by the
> > > previous patch...
> > >
> >
> > Fine with me. Will do it in v3.
> >
>
> Hold on before posting, I've just learned about hw_compat_4_0_1 while
> reviewing patch 5... need so more time to understand the impact.
>
Sure.
Thanks,
Yongji
next prev parent reply other threads:[~2019-06-05 7:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 7:34 [Qemu-devel] [PATCH v2 0/5] virtio: fix some issues of "started" and "start_on_kick" flag elohimes
2019-06-04 7:34 ` [Qemu-devel] [PATCH v2 1/5] virtio: Set "start_on_kick" on virtio_set_features() elohimes
2019-06-04 7:34 ` [Qemu-devel] [PATCH v2 2/5] virtio: Set "start_on_kick" for legacy devices elohimes
2019-06-05 6:42 ` Greg Kurz
2019-06-05 6:49 ` Yongji Xie
2019-06-05 7:14 ` Greg Kurz
2019-06-05 7:16 ` Yongji Xie [this message]
2019-06-04 7:34 ` [Qemu-devel] [PATCH v2 3/5] virtio: Make sure we get correct state of device on handle_aio_output() elohimes
2019-06-04 7:34 ` [Qemu-devel] [PATCH v2 4/5] virtio: Don't change "started" flag on virtio_vmstate_change() elohimes
2019-06-04 7:34 ` [Qemu-devel] [PATCH v2 5/5] virtio: add "use-started" property elohimes
2019-06-05 8:59 ` Greg Kurz
2019-06-05 9:14 ` Yongji Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAONzpcaw_KbtW5Y1KQd_Mo-gYPtydxRLwRVh0sUkk9a7BUQ+qw@mail.gmail.com \
--to=elohimes@gmail.com \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=xieyongji@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).