From: Kenta Ishiguro <kentaishiguro@slowstart.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message
Date: Mon, 20 Jul 2020 18:55:38 +0900 [thread overview]
Message-ID: <CAORMuQ4-CSP1sdzutdCvLNLo=_jUjBmw6NLZvr21yW44vKT0Lw@mail.gmail.com> (raw)
In-Reply-To: <8df96035-ee99-85b2-0d98-65f4996e4aae@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
No, it didn't.
I just checked the usage of this API and I found this inconsistent error
message.
On Mon, Jul 20, 2020 at 6:31 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> On 7/17/20 2:35 PM, Kenta Ishiguro wrote:
> > Fix a typo in an error message for KVM_SET_IRQCHIP ioctl:
> > "KVM_GET_IRQCHIP" should be "KVM_SET_IRQCHIP".
> >
> > Signed-off-by: Kenta Ishiguro <kentaishiguro@slowstart.org>
> > ---
> > hw/i386/kvm/ioapic.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
> > index 4ba8e47251..c5528df942 100644
> > --- a/hw/i386/kvm/ioapic.c
> > +++ b/hw/i386/kvm/ioapic.c
> > @@ -97,7 +97,7 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
> >
> > ret = kvm_vm_ioctl(kvm_state, KVM_SET_IRQCHIP, &chip);
> > if (ret < 0) {
> > - fprintf(stderr, "KVM_GET_IRQCHIP failed: %s\n", strerror(ret));
> > + fprintf(stderr, "KVM_SET_IRQCHIP failed: %s\n", strerror(ret));
> > abort();
>
> 9 years later this abort seems violent. Kenta, did it fired for you?
>
> > }
> > }
> >
>
> Fixes: a39c1d47ac ("kvm: x86: Add user space part for in-kernel IOAPIC")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
>
[-- Attachment #2: Type: text/html, Size: 1929 bytes --]
next prev parent reply other threads:[~2020-07-20 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 12:35 [PATCH] hw/i386/kvm/ioapic.c: fix typo in error message Kenta Ishiguro
2020-07-20 8:24 ` Stefano Garzarella
2020-07-20 9:31 ` Philippe Mathieu-Daudé
2020-07-20 9:55 ` Kenta Ishiguro [this message]
2020-07-21 1:01 ` Li Qiang
2020-09-01 7:00 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAORMuQ4-CSP1sdzutdCvLNLo=_jUjBmw6NLZvr21yW44vKT0Lw@mail.gmail.com' \
--to=kentaishiguro@slowstart.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).