From: Ed Swierk <eswierk@skyportsystems.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
qemu-devel@nongnu.org, libvir-list@redhat.com,
marcandre.lureau@redhat.com, Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected
Date: Tue, 31 Jan 2017 14:03:44 -0800 [thread overview]
Message-ID: <CAO_EM_ndhE1ibyHRyE3D_jSjs0PbX1wmetYTP6rvY_AM4Un8-Q@mail.gmail.com> (raw)
In-Reply-To: <d659ecc7-34a4-aad5-69c1-36ba4aff3d15@redhat.com>
On Tue, Jan 31, 2017 at 7:34 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 31/01/2017 04:39, Daniel P. Berrange wrote:
>> I don't think so - retrying in this way is pointless IMHO - it is just
>> going to get the same result on every retry on 99% of occassions.
>
> Just to provide the full context, the retry happens even if you get
> EAGAIN, and in that case it does makes sense.
>
> But if the pty is disconnected I agree it should discard the data.
Thanks for the feedback. Please refer to this proposed patch:
http://patchwork.ozlabs.org/patch/721974/ .
--Ed
prev parent reply other threads:[~2017-01-31 22:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 1:07 [Qemu-devel] char: Logging serial pty output when disconnected Ed Swierk
2017-01-27 9:40 ` [Qemu-devel] [libvirt] " Daniel P. Berrange
2017-01-31 4:58 ` Ed Swierk
2017-01-31 9:39 ` Daniel P. Berrange
2017-01-31 15:34 ` Paolo Bonzini
2017-01-31 22:03 ` Ed Swierk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAO_EM_ndhE1ibyHRyE3D_jSjs0PbX1wmetYTP6rvY_AM4Un8-Q@mail.gmail.com \
--to=eswierk@skyportsystems.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).