From: andrzej zaborowski <balrogg@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] "qemu -device ?" segfaults
Date: Thu, 23 Feb 2012 09:57:01 +0100 [thread overview]
Message-ID: <CAOq732JL81stn=U3o6bT4eicQidd=W+jaHdVUaNi9OetOtdSJQ@mail.gmail.com> (raw)
In-Reply-To: <m3hayisznu.fsf@blackfin.pond.sub.org>
On 23 February 2012 09:48, Markus Armbruster <armbru@redhat.com> wrote:
> andrzej zaborowski <balrogg@gmail.com> writes:
>
>> On 23 February 2012 09:20, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>> $subject says all, which pretty much breaks libvirt-managed qemu ...
>>
>> Also "device_add nonexistent-device" in the monitor gives a rather
>> unhelpful message:
>>
>> Parameter 'driver' expects device type
>
> "-device foo" is really shorthand for "-device driver=foo". And deep
> down in the bowels of qdev, where the error get reported, the value of
> parameter "driver" gets treated like any other parameter's value: if
> it's not within ACCEPTABLE-SET, complain "Parameter 'NAME' expected
> ACCEPTABLE-SET".
Yeah, I looked at this code, perhaps "'INPUT' is not a valid
'ACCEPTABLE-SET'" would be more helpful. In my message I was talking
about the monitor command though. Something like "you typoed in the
device name" should be reported by the human readable monitor.
Cheers
prev parent reply other threads:[~2012-02-23 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 8:20 [Qemu-devel] "qemu -device ?" segfaults Gerd Hoffmann
2012-02-23 8:23 ` Gerd Hoffmann
2012-02-23 8:23 ` Peter Maydell
2012-02-23 8:52 ` Gerd Hoffmann
2012-02-23 8:25 ` andrzej zaborowski
2012-02-23 8:48 ` Markus Armbruster
2012-02-23 8:57 ` andrzej zaborowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOq732JL81stn=U3o6bT4eicQidd=W+jaHdVUaNi9OetOtdSJQ@mail.gmail.com' \
--to=balrogg@gmail.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).