From: andrzej zaborowski <balrogg@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2 09/18] omap_gpmc: Fix handling of FIFOTHRESHOLDSTATUS bit
Date: Sat, 17 Sep 2011 03:22:17 +0200 [thread overview]
Message-ID: <CAOq732JPvVd4f9ZqFqKoqw1B7WWAec_koKnShjwKg+jgDx422g@mail.gmail.com> (raw)
In-Reply-To: <1314550628-26869-11-git-send-email-peter.maydell@linaro.org>
On 28 August 2011 18:56, Peter Maydell <peter.maydell@linaro.org> wrote:
> The OMAP3 TRM is inconsistent about whether the GPMC FIFOTHRESHOLDSTATUS
> bit should be set when FIFOPOINTER > FIFOTHRESHOLD or when it is >=
> FIFOTHRESHOLD. Apparently the underlying functional spec from which
> the TRM was created states that the behaviour is ">=", and this also
> makes more conceptual sense.
It would be good to have a comment about this in the code.
Cheers
next prev parent reply other threads:[~2011-09-17 1:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-28 16:56 [Qemu-devel] [PATCH v2 00/18] onenand, omap_gpmc fixes, features Peter Maydell
2011-08-28 16:56 ` Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 01/18] hw/sysbus: Add sysbus_mmio_get_region() Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 02/18] hw/onenand: Remove unnecessary argument from onenand_command() Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 03/18] hw/onenand: Qdevify Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 04/18] hw/onenand: Minor spacing fixes Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 05/18] omap_gpmc: Clean up omap_gpmc_attach MemoryRegion conversion Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 06/18] omap_gpmc: Refactor omap_gpmc_cs_map and omap_gpmc_cs_unmap Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 07/18] omap_gpmc: GPMC_IRQSTATUS is write-one-to-clear Peter Maydell
2011-09-17 1:08 ` andrzej zaborowski
2011-09-17 15:47 ` Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 08/18] omap_gpmc: Wire up the GPMC IRQ correctly Peter Maydell
2011-08-28 16:56 ` [Qemu-devel] [PATCH v2 09/18] omap_gpmc: Fix handling of FIFOTHRESHOLDSTATUS bit Peter Maydell
2011-09-17 1:22 ` andrzej zaborowski [this message]
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 10/18] omap_gpmc: Take omap_mpu_state* in omap_gpmc_init Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 11/18] omap_gpmc: Calculate revision from OMAP model Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 12/18] omap_gpmc: Reindent misindented switch statements Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 13/18] omap_gpmc: Support NAND devices Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 14/18] hw/omap.h: Add OMAP 3630 to omap_mpu_model enumeration Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 15/18] omap_gpmc: Accept a zero mask field on omap3630 Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 16/18] omap_gpmc: Pull prefetch engine data into sub-struct Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 17/18] omap: Wire up the DMA request line to the GPMC Peter Maydell
2011-08-28 16:57 ` [Qemu-devel] [PATCH v2 18/18] omap_gpmc: Implement prefetch engine Peter Maydell
2011-08-30 6:27 ` [Qemu-devel] [PATCH v2 00/18] onenand, omap_gpmc fixes, features Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOq732JPvVd4f9ZqFqKoqw1B7WWAec_koKnShjwKg+jgDx422g@mail.gmail.com \
--to=balrogg@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).