From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4jbn-0000gn-CW for qemu-devel@nongnu.org; Fri, 16 Sep 2011 21:22:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4jbm-0002uM-BL for qemu-devel@nongnu.org; Fri, 16 Sep 2011 21:22:19 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:50948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4jbm-0002ts-4U for qemu-devel@nongnu.org; Fri, 16 Sep 2011 21:22:18 -0400 Received: by pzk1 with SMTP id 1so3538163pzk.1 for ; Fri, 16 Sep 2011 18:22:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1314550628-26869-11-git-send-email-peter.maydell@linaro.org> References: <1314550628-26869-1-git-send-email-peter.maydell@linaro.org> <1314550628-26869-11-git-send-email-peter.maydell@linaro.org> Date: Sat, 17 Sep 2011 03:22:17 +0200 Message-ID: From: andrzej zaborowski Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 09/18] omap_gpmc: Fix handling of FIFOTHRESHOLDSTATUS bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Edgar E. Iglesias" , qemu-devel@nongnu.org, patches@linaro.org On 28 August 2011 18:56, Peter Maydell wrote: > The OMAP3 TRM is inconsistent about whether the GPMC FIFOTHRESHOLDSTATUS > bit should be set when FIFOPOINTER > FIFOTHRESHOLD or when it is >= > FIFOTHRESHOLD. Apparently the underlying functional spec from which > the TRM was created states that the behaviour is ">=", and this also > makes more conceptual sense. It would be good to have a comment about this in the code. Cheers