qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] hw/input/hid: Fix some wrong hid usage mappings.
@ 2017-11-21 21:43 Tao Wu
  2017-11-21 22:18 ` no-reply
  0 siblings, 1 reply; 6+ messages in thread
From: Tao Wu @ 2017-11-21 21:43 UTC (permalink / raw)
  To: qemu-devel; +Cc: kraxel, Tao Wu

There are some wrong hid usage mapping in hid_usage_keys table.
It can be confirmed with "sendkey" command in monitor and verify
the behavior in guest OS.
This CL fixed some wrong hid usage mapping for these keys:

kp_equals kp_comma audiomute volumedown volumeup power

There still are some wrong mapping left in hid_usage_keys table, but
they are not as important as above keys. The list of left buggy keys:

open paste ro hiragana henkan yen again props undo front audioprev audionext
calculator audioplay audiostop cut find sleep ac_refresh stop ac_forward
ac_back help copy

Signed-off-by: Tao Wu <lepton@google.com>
---
 hw/input/hid.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/hw/input/hid.c b/hw/input/hid.c
index 0d049ff61c..08a0f07bbf 100644
--- a/hw/input/hid.c
+++ b/hw/input/hid.c
@@ -47,24 +47,24 @@ static const uint8_t hid_usage_keys[0x100] = {
     0x3f, 0x40, 0x41, 0x42, 0x43, 0x53, 0x47, 0x5f,
     0x60, 0x61, 0x56, 0x5c, 0x5d, 0x5e, 0x57, 0x59,
     0x5a, 0x5b, 0x62, 0x63, 0x46, 0x00, 0x64, 0x44,
-    0x45, 0x68, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
+    0x45, 0x67, 0x69, 0x6a, 0x6b, 0x6c, 0x6d, 0x6e,
     0xe8, 0xe9, 0x71, 0x72, 0x73, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x85, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65,
+    0x00, 0x00, 0x00, 0x00, 0x00, 0xe3, 0x85, 0x65,
 
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x58, 0xe4, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0x00, 0x00, 0x54, 0x00, 0x46,
+    0x7f, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x81, 0x00,
+    0x80, 0x00, 0x00, 0x00, 0x00, 0x54, 0x00, 0x46,
     0xe6, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x48, 0x48, 0x4a,
     0x52, 0x4b, 0x00, 0x50, 0x00, 0x4f, 0x00, 0x4d,
     0x51, 0x4e, 0x49, 0x4c, 0x00, 0x00, 0x00, 0x00,
-    0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x00, 0x00,
+    0x00, 0x00, 0x00, 0xe3, 0xe7, 0x65, 0x66, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
     0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
-- 
2.15.0.448.gf294e3d99a-goog

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-12-07  6:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-21 21:43 [Qemu-devel] [PATCH] hw/input/hid: Fix some wrong hid usage mappings Tao Wu
2017-11-21 22:18 ` no-reply
2017-11-21 22:42   ` Tao Wu(吴涛@Eng)
2017-11-28 17:31     ` Tao Wu(吴涛@Eng)
2017-12-05  3:42       ` Tao Wu(吴涛@Eng)
2017-12-07  6:58         ` Tao Wu(吴涛@Eng)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).