qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dave Airlie <airlied@gmail.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] vfio-pci: Fix Nvidia MSI ACK through 0x88000 quirk
Date: Tue, 12 Nov 2013 08:56:28 +1000	[thread overview]
Message-ID: <CAPM=9txeyzMuVQS0YPWs6bxe2Mfr_on4oTrs4bRvVLT=Z4G4wg@mail.gmail.com> (raw)
In-Reply-To: <1384209137.22415.57.camel@ul30vt.home>

On Tue, Nov 12, 2013 at 8:32 AM, Alex Williamson
<alex.williamson@redhat.com> wrote:
> On Tue, 2013-11-12 at 07:55 +1000, Dave Airlie wrote:
>> On Tue, Nov 12, 2013 at 7:43 AM, Alex Williamson
>> <alex.williamson@redhat.com> wrote:
>> > When MSI is enabled on Nvidia GeForce cards the driver seems to
>> > acknowledge the interrupt by writing a 0xff byte to the MSI capability
>> > ID register using the PCI config space mirror at offset 0x88000 from
>> > BAR0.  Without this, the device will only fire a single interrupt.
>> > VFIO handles the PCI capability ID/next registers as virtual w/o write
>> > support, so any write through config space is currently dropped.  Add
>> > a check for this and allow the write through the BAR window.  The
>> > registers are read-only anyway.
>>
>> This is only half the truth, I'm afraid if I'm right its much worse than that.
>>
>> At least on some GPUs the MSI ack is done via PCI config space itself,
>> and on some its done via the mirror, and yes it matters on some cards
>> which way it works.
>
> I was hoping that wouldn't be the case since it seems fairly universal
> that PCI config space access should be considered slow and avoided for
> things like this.  But, I suppose with MMConfig it's no worse than
> device MMIO space.

For reference dig around in here

http://www.mail-archive.com/nouveau@lists.freedesktop.org/msg14437.html

nvidia commented on it as well, it may be they require the slowness or
just some other coherency issue.

Dave.

      reply	other threads:[~2013-11-11 22:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 21:43 [Qemu-devel] [PATCH] vfio-pci: Fix Nvidia MSI ACK through 0x88000 quirk Alex Williamson
2013-11-11 21:55 ` Dave Airlie
2013-11-11 22:32   ` Alex Williamson
2013-11-11 22:56     ` Dave Airlie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPM=9txeyzMuVQS0YPWs6bxe2Mfr_on4oTrs4bRvVLT=Z4G4wg@mail.gmail.com' \
    --to=airlied@gmail.com \
    --cc=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).