From: Konstantin Kostiuk <kkostiuk@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, philmd@linaro.org, michael.roth@amd.com
Subject: Re: [PATCH 3/3] qerror: QERR_QGA_COMMAND_FAILED is no longer used, drop
Date: Tue, 14 May 2024 20:39:39 +0300 [thread overview]
Message-ID: <CAPMcbCoaK=YwWFTzvw3Ao99SA54csAr7w+iSaC-_Xx6ExKBnBA@mail.gmail.com> (raw)
In-Reply-To: <20240514105829.729342-4-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
On Tue, May 14, 2024 at 1:58 PM Markus Armbruster <armbru@redhat.com> wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qapi/qmp/qerror.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
> index 00b18e9082..390590bb81 100644
> --- a/include/qapi/qmp/qerror.h
> +++ b/include/qapi/qmp/qerror.h
> @@ -29,9 +29,6 @@
> #define QERR_PROPERTY_VALUE_OUT_OF_RANGE \
> "Property %s.%s doesn't take value %" PRId64 " (minimum: %" PRId64 ",
> maximum: %" PRId64 ")"
>
> -#define QERR_QGA_COMMAND_FAILED \
> - "Guest agent command failed, error was '%s'"
> -
> #define QERR_UNSUPPORTED \
> "this feature or command is not currently supported"
>
> --
> 2.45.0
>
>
[-- Attachment #2: Type: text/html, Size: 1369 bytes --]
prev parent reply other threads:[~2024-05-14 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 10:58 [PATCH 0/3] error: Eliminate QERR_QGA_COMMAND_FAILED Markus Armbruster
2024-05-14 10:58 ` [PATCH 1/3] qga-win32: Improve guest-set-user-password, guest-file-open errors Markus Armbruster
2024-05-14 13:16 ` Philippe Mathieu-Daudé
2024-05-14 17:38 ` Konstantin Kostiuk
2024-05-14 10:58 ` [PATCH 2/3] qga: Shorten several error messages Markus Armbruster
2024-05-14 11:02 ` Markus Armbruster
2024-05-14 13:17 ` Philippe Mathieu-Daudé
2024-05-14 17:39 ` Konstantin Kostiuk
2024-05-14 10:58 ` [PATCH 3/3] qerror: QERR_QGA_COMMAND_FAILED is no longer used, drop Markus Armbruster
2024-05-14 13:17 ` Philippe Mathieu-Daudé
2024-05-14 17:39 ` Konstantin Kostiuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPMcbCoaK=YwWFTzvw3Ao99SA54csAr7w+iSaC-_Xx6ExKBnBA@mail.gmail.com' \
--to=kkostiuk@redhat.com \
--cc=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).