From: Konstantin Kostiuk <kkostiuk@redhat.com>
To: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
Cc: qemu-devel@nongnu.org, den@virtuozzo.com,
marcandre.lureau@gmail.com, Stefan Weil <sw@weilnetz.de>
Subject: Re: [PATCH v2 0/2] qga: improve "syslog" domain logging
Date: Fri, 16 Dec 2022 17:36:39 +0200 [thread overview]
Message-ID: <CAPMcbCq+omZgpouJ-hbescMe+PSk4wFaxtaPb2Zyob2L12dEfg@mail.gmail.com> (raw)
In-Reply-To: <6730d84c-5b2b-d902-9f17-16ef33708544@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
Thanks.
You are right. I tested another command and don't see logs in the event
viewer.
PR was sent.
On Fri, Dec 16, 2022 at 5:27 PM Andrey Drobyshev <
andrey.drobyshev@virtuozzo.com> wrote:
> On 12/16/22 12:01, Konstantin Kostiuk wrote:
> > Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com
> > <mailto:kkostiuk@redhat.com>>
> > Tested-by: Konstantin Kostiuk <kkostiuk@redhat.com
> > <mailto:kkostiuk@redhat.com>>
> >
> >
> > Hi Andrey,
> > Do you expect Event Viewer to be empty by default in the current
> > implementation?
> > Currently, all logs that we write in the guest agent do not have
> > "syslog" domain
> > so we will have logs only in file.
> >
> > [...]
>
> Do they not really? For instance, I see quite a few such calls in the
> implementation of guest commands:
>
> # grep 'slog(' qga/commands-win32.c | wc -l
> 21
>
> They just need to be triggered. For instance, if I build QGA with these
> patches applied, run it in a VM make a fsfreeze call:
>
> # virsh domfsfreeze win2k16-qga-win
> Froze 2 filesystem(s)
>
> then I see the message "guest-fsfreeze called" in the event log.
>
>
[-- Attachment #2: Type: text/html, Size: 1892 bytes --]
prev parent reply other threads:[~2022-12-16 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 17:38 [PATCH v2 0/2] qga: improve "syslog" domain logging Andrey Drobyshev via
2022-11-29 17:38 ` [PATCH v2 1/2] qga-win: add logging to Windows event log Andrey Drobyshev via
2022-11-30 7:00 ` Marc-André Lureau
2023-01-23 17:28 ` Stefan Weil via
2023-01-23 19:38 ` Andrey Drobyshev
2023-01-23 20:44 ` Denis V. Lunev
2023-01-23 20:52 ` Stefan Weil via
2023-01-26 17:50 ` Andrey Drobyshev
2022-11-29 17:38 ` [PATCH v2 2/2] qga: map GLib log levels to system levels Andrey Drobyshev via
2022-12-12 12:18 ` [PATCH v2 0/2] qga: improve "syslog" domain logging Andrey Drobyshev
2022-12-12 12:29 ` Konstantin Kostiuk
2022-12-16 10:01 ` Konstantin Kostiuk
2022-12-16 15:28 ` Andrey Drobyshev
2022-12-16 15:36 ` Konstantin Kostiuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPMcbCq+omZgpouJ-hbescMe+PSk4wFaxtaPb2Zyob2L12dEfg@mail.gmail.com \
--to=kkostiuk@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).