qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Kostiuk <kkostiuk@redhat.com>
To: Kfir Manor <kfir@daynix.com>
Cc: qemu-devel@nongnu.org, Yan Vugenfirer <yan@daynix.com>
Subject: Re: [PATCH] qga/linux: add usb support to guest-get-fsinfo
Date: Mon, 23 Jan 2023 14:27:53 +0200	[thread overview]
Message-ID: <CAPMcbCqNRA+7_00BhQZSjiAEvoWRK6dbprwUdkuc3P-qZaj-GQ@mail.gmail.com> (raw)
In-Reply-To: <20230122153307.1050593-1-kfir@daynix.com>

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

Hi Kfir,

You missed adding the Signed-off-by line to the patch.
Please resend.

Best Regards,
Konstantin Kostiuk.


On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor <kfir@daynix.com> wrote:

> ---
>  qga/commands-posix.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index ebd33a643c..aab9d3bd50 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
>                         g_str_equal(driver, "sym53c8xx") ||
>                         g_str_equal(driver, "virtio-pci") ||
>                         g_str_equal(driver, "ahci") ||
> -                       g_str_equal(driver, "nvme"))) {
> +                       g_str_equal(driver, "nvme") ||
> +                       g_str_equal(driver, "xhci_hcd") ||
> +                       g_str_equal(driver, "ehci-pci"))) {
>              break;
>          }
>
> @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
>          }
>      } else if (strcmp(driver, "nvme") == 0) {
>          disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> +    } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> "xhci_hcd") == 0) {
> +        disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
>      } else {
>          g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
>          goto cleanup;
> --
> 2.38.1
>
>

[-- Attachment #2: Type: text/html, Size: 2301 bytes --]

  parent reply	other threads:[~2023-01-23 12:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-22 15:33 [PATCH] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
2023-01-23 12:20 ` Konstantin Kostiuk
2023-01-23 12:27 ` Konstantin Kostiuk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-23 13:07 Kfir Manor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPMcbCqNRA+7_00BhQZSjiAEvoWRK6dbprwUdkuc3P-qZaj-GQ@mail.gmail.com \
    --to=kkostiuk@redhat.com \
    --cc=kfir@daynix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).