* [PATCH] qga/linux: add usb support to guest-get-fsinfo
@ 2023-01-22 15:33 Kfir Manor
2023-01-23 12:20 ` Konstantin Kostiuk
2023-01-23 12:27 ` Konstantin Kostiuk
0 siblings, 2 replies; 4+ messages in thread
From: Kfir Manor @ 2023-01-22 15:33 UTC (permalink / raw)
To: qemu-devel, Konstantin Kostiuk, Michael Roth; +Cc: Yan Vugenfirer
---
qga/commands-posix.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ebd33a643c..aab9d3bd50 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
g_str_equal(driver, "sym53c8xx") ||
g_str_equal(driver, "virtio-pci") ||
g_str_equal(driver, "ahci") ||
- g_str_equal(driver, "nvme"))) {
+ g_str_equal(driver, "nvme") ||
+ g_str_equal(driver, "xhci_hcd") ||
+ g_str_equal(driver, "ehci-pci"))) {
break;
}
@@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
}
} else if (strcmp(driver, "nvme") == 0) {
disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
+ } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, "xhci_hcd") == 0) {
+ disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
} else {
g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
goto cleanup;
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qga/linux: add usb support to guest-get-fsinfo
2023-01-22 15:33 [PATCH] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
@ 2023-01-23 12:20 ` Konstantin Kostiuk
2023-01-23 12:27 ` Konstantin Kostiuk
1 sibling, 0 replies; 4+ messages in thread
From: Konstantin Kostiuk @ 2023-01-23 12:20 UTC (permalink / raw)
To: Kfir Manor; +Cc: qemu-devel, Michael Roth, Yan Vugenfirer
[-- Attachment #1: Type: text/plain, Size: 1401 bytes --]
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor <kfir@daynix.com> wrote:
> ---
> qga/commands-posix.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index ebd33a643c..aab9d3bd50 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
> g_str_equal(driver, "sym53c8xx") ||
> g_str_equal(driver, "virtio-pci") ||
> g_str_equal(driver, "ahci") ||
> - g_str_equal(driver, "nvme"))) {
> + g_str_equal(driver, "nvme") ||
> + g_str_equal(driver, "xhci_hcd") ||
> + g_str_equal(driver, "ehci-pci"))) {
> break;
> }
>
> @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
> }
> } else if (strcmp(driver, "nvme") == 0) {
> disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> "xhci_hcd") == 0) {
> + disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
> } else {
> g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
> goto cleanup;
> --
> 2.38.1
>
>
[-- Attachment #2: Type: text/html, Size: 2090 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qga/linux: add usb support to guest-get-fsinfo
2023-01-22 15:33 [PATCH] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
2023-01-23 12:20 ` Konstantin Kostiuk
@ 2023-01-23 12:27 ` Konstantin Kostiuk
1 sibling, 0 replies; 4+ messages in thread
From: Konstantin Kostiuk @ 2023-01-23 12:27 UTC (permalink / raw)
To: Kfir Manor; +Cc: qemu-devel, Yan Vugenfirer
[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]
Hi Kfir,
You missed adding the Signed-off-by line to the patch.
Please resend.
Best Regards,
Konstantin Kostiuk.
On Sun, Jan 22, 2023 at 5:33 PM Kfir Manor <kfir@daynix.com> wrote:
> ---
> qga/commands-posix.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index ebd33a643c..aab9d3bd50 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
> g_str_equal(driver, "sym53c8xx") ||
> g_str_equal(driver, "virtio-pci") ||
> g_str_equal(driver, "ahci") ||
> - g_str_equal(driver, "nvme"))) {
> + g_str_equal(driver, "nvme") ||
> + g_str_equal(driver, "xhci_hcd") ||
> + g_str_equal(driver, "ehci-pci"))) {
> break;
> }
>
> @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> *syspath,
> }
> } else if (strcmp(driver, "nvme") == 0) {
> disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> "xhci_hcd") == 0) {
> + disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
> } else {
> g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
> goto cleanup;
> --
> 2.38.1
>
>
[-- Attachment #2: Type: text/html, Size: 2301 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] qga/linux: add usb support to guest-get-fsinfo
@ 2023-01-23 13:07 Kfir Manor
0 siblings, 0 replies; 4+ messages in thread
From: Kfir Manor @ 2023-01-23 13:07 UTC (permalink / raw)
To: qemu-devel, Konstantin Kostiuk, Michael Roth; +Cc: Yan Vugenfirer
Signed-off-by: Kfir Manor <kfir@daynix.com>
---
qga/commands-posix.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index ebd33a643c..aab9d3bd50 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
g_str_equal(driver, "sym53c8xx") ||
g_str_equal(driver, "virtio-pci") ||
g_str_equal(driver, "ahci") ||
- g_str_equal(driver, "nvme"))) {
+ g_str_equal(driver, "nvme") ||
+ g_str_equal(driver, "xhci_hcd") ||
+ g_str_equal(driver, "ehci-pci"))) {
break;
}
@@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const *syspath,
}
} else if (strcmp(driver, "nvme") == 0) {
disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
+ } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, "xhci_hcd") == 0) {
+ disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
} else {
g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
goto cleanup;
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-23 13:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-22 15:33 [PATCH] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
2023-01-23 12:20 ` Konstantin Kostiuk
2023-01-23 12:27 ` Konstantin Kostiuk
-- strict thread matches above, loose matches on Subject: below --
2023-01-23 13:07 Kfir Manor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).