From: Konstantin Kostiuk <kkostiuk@redhat.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH] guest-agent: document allow-rpcs in config file section
Date: Fri, 19 Jul 2024 11:51:00 +0300 [thread overview]
Message-ID: <CAPMcbCrcSBNN7fiP7ga0kZLbB+0Ucb9H5Q7Fd1yx0oM5U29mFg@mail.gmail.com> (raw)
In-Reply-To: <20240718140407.444160-1-t.lamprecht@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
On Thu, Jul 18, 2024 at 5:05 PM Thomas Lamprecht <t.lamprecht@proxmox.com>
wrote:
> While the `allow-rpcs` option is documented in the CLI options
> section, it was missing in the section about the configuration file
> syntax.
>
> And while it's mentioned that "the list of keys follows the command line
> options", having `block-rpcs` there but not `allow-rpcs` seems like
> being a potential source of confusion; and as it's cheap to add let's
> just do so.
>
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> ---
> docs/interop/qemu-ga.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
> index 72fb75a6f5..dd4245ece8 100644
> --- a/docs/interop/qemu-ga.rst
> +++ b/docs/interop/qemu-ga.rst
> @@ -131,6 +131,7 @@ fsfreeze-hook string
> statedir string
> verbose boolean
> block-rpcs string list
> +allow-rpcs string list
> ============= ===========
>
> See also
> --
> 2.39.2
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1589 bytes --]
prev parent reply other threads:[~2024-07-19 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 14:04 [PATCH] guest-agent: document allow-rpcs in config file section Thomas Lamprecht
2024-07-19 8:51 ` Konstantin Kostiuk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPMcbCrcSBNN7fiP7ga0kZLbB+0Ucb9H5Q7Fd1yx0oM5U29mFg@mail.gmail.com \
--to=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).