* [PATCH] guest-agent: document allow-rpcs in config file section
@ 2024-07-18 14:04 Thomas Lamprecht
2024-07-19 8:51 ` Konstantin Kostiuk
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Lamprecht @ 2024-07-18 14:04 UTC (permalink / raw)
To: qemu-devel; +Cc: Michael Roth, Konstantin Kostiuk
While the `allow-rpcs` option is documented in the CLI options
section, it was missing in the section about the configuration file
syntax.
And while it's mentioned that "the list of keys follows the command line
options", having `block-rpcs` there but not `allow-rpcs` seems like
being a potential source of confusion; and as it's cheap to add let's
just do so.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
docs/interop/qemu-ga.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
index 72fb75a6f5..dd4245ece8 100644
--- a/docs/interop/qemu-ga.rst
+++ b/docs/interop/qemu-ga.rst
@@ -131,6 +131,7 @@ fsfreeze-hook string
statedir string
verbose boolean
block-rpcs string list
+allow-rpcs string list
============= ===========
See also
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] guest-agent: document allow-rpcs in config file section
2024-07-18 14:04 [PATCH] guest-agent: document allow-rpcs in config file section Thomas Lamprecht
@ 2024-07-19 8:51 ` Konstantin Kostiuk
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Kostiuk @ 2024-07-19 8:51 UTC (permalink / raw)
To: Thomas Lamprecht; +Cc: qemu-devel, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1085 bytes --]
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
On Thu, Jul 18, 2024 at 5:05 PM Thomas Lamprecht <t.lamprecht@proxmox.com>
wrote:
> While the `allow-rpcs` option is documented in the CLI options
> section, it was missing in the section about the configuration file
> syntax.
>
> And while it's mentioned that "the list of keys follows the command line
> options", having `block-rpcs` there but not `allow-rpcs` seems like
> being a potential source of confusion; and as it's cheap to add let's
> just do so.
>
> Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> ---
> docs/interop/qemu-ga.rst | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/docs/interop/qemu-ga.rst b/docs/interop/qemu-ga.rst
> index 72fb75a6f5..dd4245ece8 100644
> --- a/docs/interop/qemu-ga.rst
> +++ b/docs/interop/qemu-ga.rst
> @@ -131,6 +131,7 @@ fsfreeze-hook string
> statedir string
> verbose boolean
> block-rpcs string list
> +allow-rpcs string list
> ============= ===========
>
> See also
> --
> 2.39.2
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1589 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-19 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-18 14:04 [PATCH] guest-agent: document allow-rpcs in config file section Thomas Lamprecht
2024-07-19 8:51 ` Konstantin Kostiuk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).