From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD0FBEB64D9 for ; Fri, 7 Jul 2023 20:23:45 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHrz4-0005ym-GP; Fri, 07 Jul 2023 16:23:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHrz2-0005yI-Ge for qemu-devel@nongnu.org; Fri, 07 Jul 2023 16:23:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHryz-0001JM-1M for qemu-devel@nongnu.org; Fri, 07 Jul 2023 16:23:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688761390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JDJ9ne9feNzIW3Wt7j6c8KuXI69NFBJoLnPXs02zqrM=; b=AIJOWBKsSzEP3p4nHiOWkinoqEzFRl75sHZFDxSvEf8ThCn1mksNYPisJpxAQQ+mh2E7C0 UBBfF0SSOZbMbjn24QfoZTqWWdQ0rxDmjaWRbwNo5gHdp6VZ4829+T+UvAUnh0dGAEO18W uaM1wYQwFwnVmYrvWPK1kKzzXLJA+9w= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-4mQs3H0dPVi_BZ4XEt3Dlg-1; Fri, 07 Jul 2023 16:23:07 -0400 X-MC-Unique: 4mQs3H0dPVi_BZ4XEt3Dlg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b6fdb7eeafso22059811fa.2 for ; Fri, 07 Jul 2023 13:23:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688761386; x=1691353386; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JDJ9ne9feNzIW3Wt7j6c8KuXI69NFBJoLnPXs02zqrM=; b=UZz4K5u9alKJZm9JCrrGqoKbzWiLCqY3wNp+CSOPdTzsvULhMlHYlLWFKTVCq/86jf /uCaTpQzxoqg9RdkQkV1c9FF7VG+kwKnHoxU3a49x9v28r81oaqv87n1lZLPibVkKXtn EWsh4w+wQaaxSngahIz9NzI6kRuYeaXi4wsyCw/0L1qNerANz4qJMobsCXVPEwabVJh5 8Le/d6UPfUL2IyiHuJOJGH2JLLJpHrrJDxRWk1ic1H/Zj+s2lahyHFRNqJWRGClgsvcq m3FxeS43221lQzLEFn9GHh9g6NmcHUcYgZ4v2JMNrCf8hwtlDn+Uz7UeqsZpV/rEqNqP /2uA== X-Gm-Message-State: ABy/qLbFVYQGA2SRPkJ4kusE+JBtSvR2Po/qTSGMj0ADRGuJkCREcS5V gySYT8UDyqZTNhvfTqtmPKRIfjorL5HUEh1+MM49FbFKV+v1V3z7C/WFJ0voeXnJsbb2w3vXv5e fJ93JwzhhO0eog7wF7ZEo/d6XE3zw5Mo= X-Received: by 2002:a2e:99c8:0:b0:2b6:d48a:5dc3 with SMTP id l8-20020a2e99c8000000b002b6d48a5dc3mr4395886ljj.39.1688761385914; Fri, 07 Jul 2023 13:23:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlEAi/eevINkT2WAW3IhwVJqiXageSbX9ItqYy8rbB9+JItg5rVZm/URzd2G9TG4o26+5kFsayEKdSymPKHdR30= X-Received: by 2002:a2e:99c8:0:b0:2b6:d48a:5dc3 with SMTP id l8-20020a2e99c8000000b002b6d48a5dc3mr4395877ljj.39.1688761385608; Fri, 07 Jul 2023 13:23:05 -0700 (PDT) MIME-Version: 1.0 References: <20230707092258.768420-1-kkostiuk@redhat.com> <20230707092258.768420-2-kkostiuk@redhat.com> <20f5fded-a486-c184-9ee0-1e91c178d5fd@linaro.org> In-Reply-To: <20f5fded-a486-c184-9ee0-1e91c178d5fd@linaro.org> From: Konstantin Kostiuk Date: Fri, 7 Jul 2023 23:22:54 +0300 Message-ID: Subject: Re: [PATCH v3 1/4] QGA VSS: Add wrapper to send log to debugger and stderr To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Cc: qemu-devel@nongnu.org, =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Michael Roth , Eric Blake , Richard Henderson , Thomas Huth Content-Type: multipart/alternative; boundary="00000000000080015205ffeb663c" Received-SPF: pass client-ip=170.10.129.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --00000000000080015205ffeb663c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 7, 2023 at 6:36=E2=80=AFPM Philippe Mathieu-Daud=C3=A9 wrote: > On 7/7/23 16:24, Konstantin Kostiuk wrote: > > > > > > On Fri, Jul 7, 2023 at 1:33=E2=80=AFPM Philippe Mathieu-Daud=C3=A9 > > wrote: > > > > On 7/7/23 11:22, Konstantin Kostiuk wrote: > > > Signed-off-by: Konstantin Kostiuk > > > > > --- > > > qga/vss-win32/meson.build | 2 +- > > > qga/vss-win32/vss-debug.cpp | 31 +++++++++++++++++++++++++++++= ++ > > > qga/vss-win32/vss-debug.h | 25 +++++++++++++++++++++++++ > > > 3 files changed, 57 insertions(+), 1 deletion(-) > > > create mode 100644 qga/vss-win32/vss-debug.cpp > > > create mode 100644 qga/vss-win32/vss-debug.h > > > > > > > diff --git a/qga/vss-win32/vss-debug.cpp > > b/qga/vss-win32/vss-debug.cpp > > > new file mode 100644 > > > index 0000000000..5d6f37944b > > > --- /dev/null > > > +++ b/qga/vss-win32/vss-debug.cpp > > > @@ -0,0 +1,31 @@ > > > +/* > > > + * QEMU Guest Agent VSS debug declarations > > > + * > > > + * Copyright (C) 2023 Red Hat Inc > > > + * > > > + * Authors: > > > + * Konstantin Kostiuk > > > > > + * > > > + * This work is licensed under the terms of the GNU GPL, versio= n > > 2 or later. > > > + * See the COPYING file in the top-level directory. > > > + */ > > > + > > > +#include "qemu/osdep.h" > > > +#include "vss-debug.h" > > > +#include "vss-common.h" > > > + > > > +void qga_debug_internal(const char *funcname, const char *fmt, > > ...) { > > > + char user_sting[512] =3D {0}; > > > > "user_string" > > > > > + char full_string[640] =3D {0}; > > > + > > > + va_list args; > > > + va_start(args, fmt); > > > + vsnprintf(user_sting, 512, fmt, args); > > > > ARRAY_SIZE(user_string) > > > > > > I have a problem with ARRAY_SIZE define. > > > > ../qga/vss-win32/vss-debug.cpp: In function 'void > > qga_debug_internal(const char*, const char*, ...)': > > /src/include/qemu/compiler.h:70:12: error: types may not be defined in > > 'sizeof' expressions > > 70 | struct { \ > > | ^ > > /src/include/qemu/compiler.h:78:43: note: in expansion of macro > > 'QEMU_BUILD_BUG_ON_STRUCT' > > 78 | #define QEMU_BUILD_BUG_ON_ZERO(x) > > (sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)) - \ > > | > ^~~~~~~~~~~~~~~~~~~~~~~~ > > /src/include/qemu/osdep.h:474:24: note: in expansion of macro > > 'QEMU_BUILD_BUG_ON_ZERO' > > 474 | > QEMU_BUILD_BUG_ON_ZERO(!QEMU_IS_ARRAY(x))) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > ../qga/vss-win32/vss-debug.cpp:23:32: note: in expansion of macro > > 'ARRAY_SIZE' > > 23 | if (vsnprintf(user_string, ARRAY_SIZE(user_string), fmt, > > args) <=3D 0) { > > | ^~~~~~~~~~ > > /src/include/qemu/osdep.h:470:57: error: expected primary-expression > > before 'typeof' > > 470 | #define QEMU_IS_ARRAY(x) > > (!__builtin_types_compatible_p(typeof(x), \ > > | ^~~~~~ > > /src/include/qemu/compiler.h:71:14: note: in definition of macro > > 'QEMU_BUILD_BUG_ON_STRUCT' > > 71 | int:(x) ? -1 : 1; \ > > | ^ > > /src/include/qemu/osdep.h:474:24: note: in expansion of macro > > 'QEMU_BUILD_BUG_ON_ZERO' > > 474 | > QEMU_BUILD_BUG_ON_ZERO(!QEMU_IS_ARRAY(x))) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > /src/include/qemu/osdep.h:474:48: note: in expansion of macro > > 'QEMU_IS_ARRAY' > > 474 | > QEMU_BUILD_BUG_ON_ZERO(!QEMU_IS_ARRAY(x))) > > > > Can you help with this? > > Eh no clue, maybe not C++ compliant? > > Fall back to sizeof() =C2=AF\_(=E3=83=84)_/=C2=AF > > You are right, When I rename the file to vss-debug.c the error disappears. What is the better solution: 1) use vss-debug.c and extern "C" { #include "vss-debug.h" } in CPP files 2) just use sizeof() in CPP > > > > > > > + va_end(args); > > > + > > > + snprintf(full_string, 640, QGA_PROVIDER_NAME "[%lu]: %s > %s\n", > > > + GetCurrentThreadId(), funcname, user_sting); > > > > if (snprintf() <=3D 0) { return; } > > > > > + > > > + OutputDebugString(full_string); > > > + fprintf(stderr, "%s", full_string); > > > > Format unused: > > > > fputs(full_string, stderr); > > > > > +} > > > > With the changes: > > Reviewed-by: Philippe Mathieu-Daud=C3=A9 > > > > > > --00000000000080015205ffeb663c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Fri, Jul 7, 2023 at 6:36=E2=80=AFP= M Philippe Mathieu-Daud=C3=A9 <phil= md@linaro.org> wrote:
On 7/7/23 16:24, Konstantin Kostiuk wrote:
>
>
> On Fri, Jul 7, 2023 at 1:33=E2=80=AFPM Philippe Mathieu-Daud=C3=A9 <= ;philmd@linaro.org
> <mailto:phil= md@linaro.org>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0On 7/7/23 11:22, Konstantin Kostiuk wrote:
>=C2=A0 =C2=A0 =C2=A0 > Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com >=C2=A0 =C2=A0 =C2=A0<mailto:kkostiuk@redhat.com>>
>=C2=A0 =C2=A0 =C2=A0 > ---
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0qga/vss-win32/meson.build=C2=A0 = =C2=A0|=C2=A0 2 +-
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0qga/vss-win32/vss-debug.cpp | 31 = +++++++++++++++++++++++++++++++
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0qga/vss-win32/vss-debug.h=C2=A0 = =C2=A0| 25 +++++++++++++++++++++++++
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A03 files changed, 57 insertions(+)= , 1 deletion(-)
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0create mode 100644 qga/vss-win32/= vss-debug.cpp
>=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0create mode 100644 qga/vss-win32/= vss-debug.h
>
>
>=C2=A0 =C2=A0 =C2=A0 > diff --git a/qga/vss-win32/vss-debug.cpp
>=C2=A0 =C2=A0 =C2=A0b/qga/vss-win32/vss-debug.cpp
>=C2=A0 =C2=A0 =C2=A0 > new file mode 100644
>=C2=A0 =C2=A0 =C2=A0 > index 0000000000..5d6f37944b
>=C2=A0 =C2=A0 =C2=A0 > --- /dev/null
>=C2=A0 =C2=A0 =C2=A0 > +++ b/qga/vss-win32/vss-debug.cpp
>=C2=A0 =C2=A0 =C2=A0 > @@ -0,0 +1,31 @@
>=C2=A0 =C2=A0 =C2=A0 > +/*
>=C2=A0 =C2=A0 =C2=A0 > + * QEMU Guest Agent VSS debug declarations >=C2=A0 =C2=A0 =C2=A0 > + *
>=C2=A0 =C2=A0 =C2=A0 > + * Copyright (C) 2023 Red Hat Inc
>=C2=A0 =C2=A0 =C2=A0 > + *
>=C2=A0 =C2=A0 =C2=A0 > + * Authors:
>=C2=A0 =C2=A0 =C2=A0 > + *=C2=A0 Konstantin Kostiuk <kkostiuk@redhat.com
>=C2=A0 =C2=A0 =C2=A0<mailto:kkostiuk@redhat.com>>
>=C2=A0 =C2=A0 =C2=A0 > + *
>=C2=A0 =C2=A0 =C2=A0 > + * This work is licensed under the terms of = the GNU GPL, version
>=C2=A0 =C2=A0 =C2=A02 or later.
>=C2=A0 =C2=A0 =C2=A0 > + * See the COPYING file in the top-level dir= ectory.
>=C2=A0 =C2=A0 =C2=A0 > + */
>=C2=A0 =C2=A0 =C2=A0 > +
>=C2=A0 =C2=A0 =C2=A0 > +#include "qemu/osdep.h"
>=C2=A0 =C2=A0 =C2=A0 > +#include "vss-debug.h"
>=C2=A0 =C2=A0 =C2=A0 > +#include "vss-common.h"
>=C2=A0 =C2=A0 =C2=A0 > +
>=C2=A0 =C2=A0 =C2=A0 > +void qga_debug_internal(const char *funcname= , const char *fmt,
>=C2=A0 =C2=A0 =C2=A0...)=C2=A0 {
>=C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 char user_sting[512] =3D {0};<= br> >
>=C2=A0 =C2=A0 =C2=A0"user_string"
>
>=C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 char full_string[640] =3D {0};=
>=C2=A0 =C2=A0 =C2=A0 > +
>=C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 va_list args;
>=C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 va_start(args, fmt);
>=C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 vsnprintf(user_sting, 512, fmt= , args);
>
>=C2=A0 =C2=A0 =C2=A0ARRAY_SIZE(user_string)
>
>
> I have a problem with ARRAY_SIZE define.
>
> ../qga/vss-win32/vss-debug.cpp: In function 'void
> qga_debug_internal(const char*, const char*, ...)':
> /src/include/qemu/compiler.h:70:12: error: types may not be defined in=
> 'sizeof' expressions
>=C2=A0 =C2=A0 =C2=A070 | =C2=A0 =C2=A0 struct { \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= ^
> /src/include/qemu/compiler.h:78:43: note: in expansion of macro
> 'QEMU_BUILD_BUG_ON_STRUCT'
>=C2=A0 =C2=A0 =C2=A078 | #define QEMU_BUILD_BUG_ON_ZERO(x)
> (sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)) - \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~~~~~~~~~~~~~~~~~
> /src/include/qemu/osdep.h:474:24: note: in expansion of macro
> 'QEMU_BUILD_BUG_ON_ZERO'
>=C2=A0 =C2=A0 474 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0QEMU_BUILD_BUG_ON_ZERO(!QEMU_IS_ARRAY(x))= )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~~~~~~~
> ../qga/vss-win32/vss-debug.cpp:23:32: note: in expansion of macro
> 'ARRAY_SIZE'
>=C2=A0 =C2=A0 =C2=A023 | =C2=A0 =C2=A0 if (vsnprintf(user_string, ARRAY= _SIZE(user_string), fmt,
> args) <=3D 0) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~= ~~~~~
> /src/include/qemu/osdep.h:470:57: error: expected primary-expression <= br> > before 'typeof'
>=C2=A0 =C2=A0 470 | #define QEMU_IS_ARRAY(x)
> (!__builtin_types_compatible_p(typeof(x), \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 ^~~~~~
> /src/include/qemu/compiler.h:71:14: note: in definition of macro
> 'QEMU_BUILD_BUG_ON_STRUCT'
>=C2=A0 =C2=A0 =C2=A071 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 int:(x) ? -1 : 1; = \
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0^
> /src/include/qemu/osdep.h:474:24: note: in expansion of macro
> 'QEMU_BUILD_BUG_ON_ZERO'
>=C2=A0 =C2=A0 474 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0QEMU_BUILD_BUG_ON_ZERO(!QEMU_IS_ARRAY(x))= )
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~~~~~~~
> /src/include/qemu/osdep.h:474:48: note: in expansion of macro
> 'QEMU_IS_ARRAY'
>=C2=A0 =C2=A0 474 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0QEMU_BUILD_BUG_ON_ZERO(!QEMU_IS_ARRAY(x))= )
>
> Can you help with this?

Eh no clue, maybe not C++ compliant?

Fall back to sizeof() =C2=AF\_(=E3=83=84)_/=C2=AF


You are right, When I rename the file = to vss-debug.c the error disappears.
What is the better solution:=
1) use vss-debug.c and extern "C" { #include "= ;vss-debug.h" } in CPP files
2) just use sizeof() in CPP=
=C2=A0
philmd@linaro.org
>=C2=A0 =C2=A0 =C2=A0<mailto:philmd@linaro.org>>
>

--00000000000080015205ffeb663c--