From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C68C433E7 for ; Thu, 8 Oct 2020 09:23:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18F4C215A4 for ; Thu, 8 Oct 2020 09:23:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HfILuJMd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18F4C215A4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQS9M-0000Py-NB for qemu-devel@archiver.kernel.org; Thu, 08 Oct 2020 05:23:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQS8M-0008Bh-GE; Thu, 08 Oct 2020 05:22:46 -0400 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]:39482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQS8K-0004cT-Du; Thu, 08 Oct 2020 05:22:46 -0400 Received: by mail-il1-x144.google.com with SMTP id q1so5041347ilt.6; Thu, 08 Oct 2020 02:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3kQmNNinowxqs25Y82Hf1yjNnmYqEqa8fStyGACofeg=; b=HfILuJMd/XPU77x+99VbiReeXuOEHQBji4cfNLbyi3nchL0Ni0FZRZ6R0xWyGCfVMb V1FoJGZC1739S0n+cYIFxW3W5JUHe9QOoIbrTrqHgkAUnW7iTbDDQmXfaEPQI2Tov5SY ZtN1OxB/Tus9ZeDhlAWaw5UsRWjLxBrTo69BniLLf1/KVT4dfdsw/bS9D/L3UT4gMDUA rUbPXIuzE2wacn/5Mb6LYNfm3lm38v/b1l1s5y/uCdmLr9lU/aRTh7ZHrnWHf4FPZldN nAClFHmj5K+VjpFn9PPRGGPfsp1Yyo/GuiZ8/LQphuwtA0BIYMCv2+QwpjUCHfbJWJaI WICA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3kQmNNinowxqs25Y82Hf1yjNnmYqEqa8fStyGACofeg=; b=nKQMTPuC1FQWSpIkLgBF/xyIy77zISqfmExmuek7yTQqukCpp/dBlSdvpT9jQa6+8d LSdtC3dBfRHKlNBMQh3djbIaJcR9AVwKvYYwCkkAkjNyv+8L6cdjhZ7P0iu4hpsEvSOu h5o1b7C6vmjOIRSvV7HyP4Jp9jsx6AC09tWQ4AGwsmD06gmoDZN0fG6RLiqD0E97PxZy 4rxwaV0VlLD5iy7I1ib182QjodWjYfGiD1cuSE71JbMupng/4pWRL86CM8Y8XS4Sf7OV H8Q0eqAZ586ceAnbYZeJEQXtrinihZdxVwoCg6qMHZ5s4vc97KL7FAyKlCLs6iajFQDl HOEg== X-Gm-Message-State: AOAM530vBJsKR6zWsEQnLkmXs8kqZbWocfb4PD4udlTLzTkzwSkVXCYr JAWA/7N3zaBgtK7RXUHA/jz1lZLk055s12opcFc= X-Google-Smtp-Source: ABdhPJxCTyU6M9IxoilO4P8zkbVVtjd/ALpPR0j56WV8qwHq2FzBO7oqoOShmrMBrKVyfbePDGR88RLJMU6y8Y0W9O8= X-Received: by 2002:a05:6e02:ca2:: with SMTP id 2mr5943870ilg.51.1602148963119; Thu, 08 Oct 2020 02:22:43 -0700 (PDT) MIME-Version: 1.0 References: <20201008060528.68579-1-chetan4windows@gmail.com> <1c24b564-9870-10f9-ac37-c4ebfacc74f0@redhat.com> In-Reply-To: <1c24b564-9870-10f9-ac37-c4ebfacc74f0@redhat.com> From: Chetan Date: Thu, 8 Oct 2020 14:52:30 +0530 Message-ID: Subject: Re: [PATCH] Fixing LGPL version number To: Thomas Huth Content-Type: multipart/alternative; boundary="000000000000d2f51c05b1255fd3" Received-SPF: pass client-ip=2607:f8b0:4864:20::144; envelope-from=chetan4windows@gmail.com; helo=mail-il1-x144.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000d2f51c05b1255fd3 Content-Type: text/plain; charset="UTF-8" On Thu, Oct 8, 2020 at 2:18 PM Thomas Huth wrote: >I'm also not sure whether it's legally possible to replace the license text >without agreement of all authors of the file ... so better don't do a global >patch for that right now, start with one subsystem instead and see whether >it gets accepted... or maybe we should only add the SPDX tags, without >removing the license text? ... this all might require some more discussions >first ... I'll put those changes on hold then, for now. On Thu, Oct 8, 2020 at 2:34 PM Thomas Huth wrote: >Phew, that's a pretty huge patch, could you maybe split it by subsystem / >folder so that it is easier to review? Sorry about that. Sure, I'll split the patch in different versions folder wise. >I'm not sure whether we should update the version in the files that just say >"LGPL" (and do not mention "Lesser") ... they could also refer to the GNU >*Library* GPL instead, which was available as version 2 (in the sense of 2.0). >Could you please drop the hunks for the files that only mention LGPL for now? Ok. I'll exclude the files which mention just LGPL in the revision. Chetan. On Thu, Oct 8, 2020 at 2:34 PM Thomas Huth wrote: > On 08/10/2020 08.05, Chetan Pant wrote: > > There is no "version 2" of the "Lesser" General Public License. It is > > either "GPL version 2.0" or "LGPL version 2.1". This patch replaces all > > occurrences of "LGPL version 2" with "LGPL version 2.1" in comment > section. > > > > Signed-off-by: Chetan Pant > > Phew, that's a pretty huge patch, could you maybe split it by subsystem / > folder so that it is easier to review? > > [...] > > diff --git a/net/hub.h b/net/hub.h > > index ce45f7b..83e33e4 100644 > > --- a/net/hub.h > > +++ b/net/hub.h > > @@ -7,7 +7,7 @@ > > * Stefan Hajnoczi > > * Zhi Yong Wu > > * > > - * This work is licensed under the terms of the GNU LGPL, version 2 or > later. > > + * This work is licensed under the terms of the GNU LGPL, version 2.1 > or later. > > * See the COPYING.LIB file in the top-level directory. > > * > > */ > > I'm not sure whether we should update the version in the files that just > say > "LGPL" (and do not mention "Lesser") ... they could also refer to the GNU > *Library* GPL instead, which was available as version 2 (in the sense of > 2.0). > Could you please drop the hunks for the files that only mention LGPL for > now? > > > diff --git a/target/i386/hvf/x86_emu.c b/target/i386/hvf/x86_emu.c > > index d3e289e..da570e3 100644 > > --- a/target/i386/hvf/x86_emu.c > > +++ b/target/i386/hvf/x86_emu.c > > @@ -5,7 +5,7 @@ > > * This program is free software; you can redistribute it and/or > > * modify it under the terms of the GNU Lesser General Public > > * License as published by the Free Software Foundation; either > > - * version 2 of the License, or (at your option) any later version. > > + * version 2.1 of the License, or (at your option) any later version. > > * > > * This program is distributed in the hope that it will be useful, > > * but WITHOUT ANY WARRANTY; without even the implied warranty of > > @@ -23,7 +23,7 @@ > > // This library is free software; you can redistribute it and/or > > // modify it under the terms of the GNU Lesser General Public > > // License as published by the Free Software Foundation; either > > -// version 2 of the License, or (at your option) any later version. > > +// version 2.1 of the License, or (at your option) any later version. > > // > > // This library is distributed in the hope that it will be useful, > > // but WITHOUT ANY WARRANTY; without even the implied warranty of > > That's an interesting file - the license text shows up twice here... I > wonder whether we could scratch one of the two... but that's also something > for a separate patch, I think. > > Thomas > > --000000000000d2f51c05b1255fd3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu= , Oct 8, 2020 at 2:18 PM Thomas Huth <thuth@redhat.com> wrote:
>I'm also not sure whether it's legally possible to replace the = license text
>without agreement of all authors of the file ... so better don't do= a global
>patch for that right now, start with one subsystem instead and see whet= her
>it gets accepted... or maybe we should only add the SPDX tags, without<= br> >removing the license text? ... this all might require some more discuss= ions
>first ...

I'll put those changes on hold then, for now.=

On Thu, Oct 8, 2020 at 2:34 PM Thomas Huth <thuth@redhat.com> wrote:
>Phew, that's a pretty h= uge patch, could you maybe split it by subsystem /
>folder so that it is easier to review?

Sorry about that. Sure, I'll split the patch = in different versions folder wise.

>I'm not sure whether we should update the version in the files that= just say
>"LGPL" (and do not mention "Lesser") ... they could= also refer to the GNU
>*Library* GPL instead, which was available as version 2 (in the sense o= f 2.0).
>Could you please drop the hunks for the files that only mention LGPL fo= r now?

Ok. I'll exclude the files which mention just= LGPL in the revision.

Chetan.

<= /div>
On Th= u, Oct 8, 2020 at 2:34 PM Thomas Huth <thuth@redhat.com> wrote:
On 08/10/2020 08.05, Chetan Pant wrote:
> There is no "version 2" of the "Lesser" General Pu= blic License. It is
> either "GPL version 2.0" or "LGPL version 2.1". Th= is patch replaces all
> occurrences of "LGPL version 2" with "LGPL version 2.1&= quot; in comment section.
>
> Signed-off-by: Chetan Pant <chetan4windows@gmail.com>

Phew, that's a pretty huge patch, could you maybe split it by subsystem= /
folder so that it is easier to review?

[...]
> diff --git a/net/hub.h b/net/hub.h
> index ce45f7b..83e33e4 100644
> --- a/net/hub.h
> +++ b/net/hub.h
> @@ -7,7 +7,7 @@
>=C2=A0 =C2=A0*=C2=A0 Stefan Hajnoczi=C2=A0 =C2=A0<stefanha@linux.vnet.ibm.com<= /a>>
>=C2=A0 =C2=A0*=C2=A0 Zhi Yong Wu=C2=A0 =C2=A0 =C2=A0 =C2=A0<wuzhy@linux.vnet.ibm= .com>
>=C2=A0 =C2=A0*
> - * This work is licensed under the terms of the GNU LGPL, version 2 o= r later.
> + * This work is licensed under the terms of the GNU LGPL, version 2.1= or later.
>=C2=A0 =C2=A0* See the COPYING.LIB file in the top-level directory.
>=C2=A0 =C2=A0*
>=C2=A0 =C2=A0*/

I'm not sure whether we should update the version in the files that jus= t say
"LGPL" (and do not mention "Lesser") ... they could als= o refer to the GNU
*Library* GPL instead, which was available as version 2 (in the sense of 2.= 0).
Could you please drop the hunks for the files that only mention LGPL for no= w?

> diff --git a/target/i386/hvf/x86_emu.c b/target/i386/hvf/x86_emu.c
> index d3e289e..da570e3 100644
> --- a/target/i386/hvf/x86_emu.c
> +++ b/target/i386/hvf/x86_emu.c
> @@ -5,7 +5,7 @@
>=C2=A0 =C2=A0* This program is free software; you can redistribute it a= nd/or
>=C2=A0 =C2=A0* modify it under the terms of the GNU Lesser General Publ= ic
>=C2=A0 =C2=A0* License as published by the Free Software Foundation; ei= ther
> - * version 2 of the License, or (at your option) any later version. > + * version 2.1 of the License, or (at your option) any later version.=
>=C2=A0 =C2=A0*
>=C2=A0 =C2=A0* This program is distributed in the hope that it will be = useful,
>=C2=A0 =C2=A0* but WITHOUT ANY WARRANTY; without even the implied warra= nty of
> @@ -23,7 +23,7 @@
>=C2=A0 //=C2=A0 This library is free software; you can redistribute it = and/or
>=C2=A0 //=C2=A0 modify it under the terms of the GNU Lesser General Pub= lic
>=C2=A0 //=C2=A0 License as published by the Free Software Foundation; e= ither
> -//=C2=A0 version 2 of the License, or (at your option) any later vers= ion.
> +//=C2=A0 version 2.1 of the License, or (at your option) any later ve= rsion.
>=C2=A0 //
>=C2=A0 //=C2=A0 This library is distributed in the hope that it will be= useful,
>=C2=A0 //=C2=A0 but WITHOUT ANY WARRANTY; without even the implied warr= anty of

That's an interesting file - the license text shows up twice here... I<= br> wonder whether we could scratch one of the two... but that's also somet= hing
for a separate patch, I think.

=C2=A0Thomas

--000000000000d2f51c05b1255fd3--