qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Carlo Arenas <carenas@gmail.com>
To: Huacai Chen <zltjiangshi@gmail.com>
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Huacai Chen" <chenhuacai@gmail.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	qemu-devel@nongnu.org,
	"Aleksandar Markovic" <aleksandar.qemu.devel@gmail.com>,
	"Huacai Chen" <chenhc@lemote.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH V10 2/8] target/mips: Fix PageMask with variable page size
Date: Tue, 22 Sep 2020 01:00:34 -0700	[thread overview]
Message-ID: <CAPUEspjsv09JhMgurc+rS-ds0drn9ZviN6UBmo+mmPUDH3j7Cw@mail.gmail.com> (raw)
In-Reply-To: <1600742967-12933-3-git-send-email-chenhc@lemote.com>

On Mon, Sep 21, 2020 at 7:53 PM Huacai Chen <zltjiangshi@gmail.com> wrote:
> was just added to mips target and that's nolonger true.
s/nolonger/no longer/

IMHO might be worth also mentioning that it was added with ee3863b9d4
(target/mips: Support variable page size, 2020-04-08) to give a little
more context.

some other typos below might have been raised earlier as well.

> +     * When invalid, ensure the value is bigger tan or equel to

s/bigger tan or equel/bigger than or equal

> +     * the minimal but smaller than or equel to the maxium.

s/equel to the maxium/equal to the maximum

Carlo


  reply	other threads:[~2020-09-22  8:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  2:49 [PATCH V10 0/8] mips: Add Loongson-3 machine support Huacai Chen
2020-09-22  2:49 ` [PATCH V10 1/8] linux-headers: Update MIPS KVM type defintition Huacai Chen
2020-09-22  2:49 ` [PATCH V10 2/8] target/mips: Fix PageMask with variable page size Huacai Chen
2020-09-22  8:00   ` Carlo Arenas [this message]
2020-09-22 11:27     ` Huacai Chen
2020-09-22  2:49 ` [PATCH V10 3/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 1) Huacai Chen
2020-09-22  2:49 ` [PATCH V10 4/8] target/mips: Add loongson-ext lswc2 group of instructions (Part 2) Huacai Chen
2020-09-22  2:49 ` [PATCH V10 5/8] target/mips: Add loongson-ext lsdc2 group of instructions Huacai Chen
2020-09-22  2:49 ` [PATCH V10 6/8] hw/mips: Implement fw_cfg_arch_key_name() Huacai Chen
2020-09-22  7:55   ` Philippe Mathieu-Daudé
2020-09-22  2:49 ` [PATCH V10 7/8] hw/mips: Add Loongson-3 machine support Huacai Chen
2020-09-22  2:49 ` [PATCH V10 8/8] docs/system: Update MIPS machine documentation Huacai Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPUEspjsv09JhMgurc+rS-ds0drn9ZviN6UBmo+mmPUDH3j7Cw@mail.gmail.com \
    --to=carenas@gmail.com \
    --cc=aleksandar.qemu.devel@gmail.com \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=chenhc@lemote.com \
    --cc=chenhuacai@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zltjiangshi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).