From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6CWF-0000n6-E3 for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:21:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6CWE-0005sX-6p for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:21:35 -0500 Received: from mail-it0-x235.google.com ([2607:f8b0:4001:c0b::235]:37527) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c6CWD-0005s7-RD for qemu-devel@nongnu.org; Mon, 14 Nov 2016 03:21:34 -0500 Received: by mail-it0-x235.google.com with SMTP id b123so18471332itb.0 for ; Mon, 14 Nov 2016 00:21:32 -0800 (PST) MIME-Version: 1.0 Sender: vpalatin@google.com In-Reply-To: <147900720399.226.10800365976960745863@9040ca97f87d> References: <147900720399.226.10800365976960745863@9040ca97f87d> From: Vincent Palatin Date: Mon, 14 Nov 2016 09:21:09 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 Subject: Re: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: famz@redhat.com Cc: qemu-devel On Sun, Nov 13, 2016 at 4:20 AM, wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v2 0/5] [RFC] Add HAX support > Message-id: cover.1478863621.git.vpalatin@chromium.org > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > # Useful git options > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > Switched to a new branch 'test' > b9d801a Plumb the HAXM-based hardware acceleration support > c855846 hax: simplify init > 577d188 hax: remove non UG code > edf12f7 target-i386: Add Intel HAX files > cfebedf kvm: move cpu synchronization code > > === OUTPUT BEGIN === > fatal: unrecognized argument: --no-patch > Checking PATCH 1/5: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 2/5: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 3/5: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 4/5: ... > fatal: unrecognized argument: --no-patch > Checking PATCH 5/5: ... > ERROR: spaces required around that '-' (ctx:WxV) > #158: FILE: cpus.c:1276: > + if (SuspendThread(cpu->hThread) == (DWORD) -1) { > ^ > > ERROR: spaces required around that '-' (ctx:WxV) > #176: FILE: cpus.c:1294: > + if (ResumeThread(cpu->hThread) == (DWORD) -1) { > ^ > Apparently I missed this couple of warnings when I did my final checkpatch pass. At the same time, I have no idea how to solve this one, can anybody enlighten me ? Having a space on both sides of a unary minus doesn't seem what we want, so I imagine something else is wrong and confuse a bit checkpatch.pl. > total: 2 errors, 0 warnings, 349 lines checked > > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > === OUTPUT END === > > Test command exited with code: 1 > > > --- > Email generated automatically by Patchew [http://patchew.org/]. > Please send your feedback to patchew-devel@freelists.org