From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42931)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vpalatin@google.com>) id 1c59yN-0006jC-7g
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 06:26:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vpalatin@google.com>) id 1c59yM-0000kn-AU
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 06:26:19 -0500
Received: from mail-it0-x232.google.com ([2607:f8b0:4001:c0b::232]:36165)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <vpalatin@google.com>) id 1c59yM-0000kT-4M
	for qemu-devel@nongnu.org; Fri, 11 Nov 2016 06:26:18 -0500
Received: by mail-it0-x232.google.com with SMTP id q124so304810296itd.1
	for <qemu-devel@nongnu.org>; Fri, 11 Nov 2016 03:26:17 -0800 (PST)
MIME-Version: 1.0
Sender: vpalatin@google.com
In-Reply-To: <4392fa15-865d-2424-88a6-c422d62a4fb1@redhat.com>
References: <cover.1478619442.git.vpalatin@chromium.org>
	<3d8be595c30d0009464ce16e90ee8fb5451e5605.1478619442.git.vpalatin@chromium.org>
	<bc896db9-1f73-d50b-b3b0-f5b8d4014d4f@redhat.com>
	<CAP_ceTx7CA0soaA-sabf-tAOzm_MpCMhe3tm5yMDdr13R2PjbA@mail.gmail.com>
	<4392fa15-865d-2424-88a6-c422d62a4fb1@redhat.com>
From: Vincent Palatin <vpalatin@chromium.org>
Date: Fri, 11 Nov 2016 12:25:56 +0100
Message-ID: <CAP_ceTxXcs_EhLZ1cF8g7eH_BEhdCM=sXh55=8OqDXeWf=ouAQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 3/3] Plumb the HAXM-based hardware
 acceleration support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, Nov 9, 2016 at 6:32 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>
> On 09/11/2016 18:19, Vincent Palatin wrote:
>>> > Please try removing this block and instead starting QEMU with
>>> > -mem-prealloc.  If it works, remove hax_populate_ram and just set
>>> > mem_prealloc to 1 in hax_accel_init.
>> it's not working, later hax_set_ram() is unhappy about what it is
>> finding the mappings.
>> By the way, even if it had worked at startup, under memory pressure,
>> Windows might have evicted the physical pages (which is not supported
>> by the HAXM kernel module)
>>
>> I can try to move this in os_mem_prealloc() if you feel it's cleaner.
>
> Yes, that would work!

Actually, os_mem_prealloc seems mostly no-op in the win32 version,
I have postponed this change for after my v2 patchset.

-- 
Vincent