From: Niek Linnenbank <nieklinnenbank@gmail.com>
To: qianfanguijin@163.com
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 09/11] hw: arm: allwinner-sramc: Add SRAM Controller support for R40
Date: Mon, 15 May 2023 22:05:15 +0200 [thread overview]
Message-ID: <CAPan3WrL72uH+2rA8eBE50V31ZfYSEDH22yABfC3+LGY0UnL_Q@mail.gmail.com> (raw)
In-Reply-To: <20230510103004.30015-10-qianfanguijin@163.com>
[-- Attachment #1: Type: text/plain, Size: 14604 bytes --]
On Wed, May 10, 2023 at 12:30 PM <qianfanguijin@163.com> wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
> Only a few important registers are added, especially the SRAM_VER
> register.
>
> Signed-off-by: qianfan Zhao <qianfanguijin@163.com>
>
Reviewed-by: Niek Linnenbank <nieklinnenbank@gmail.com>
> ---
> hw/arm/Kconfig | 1 +
> hw/arm/allwinner-r40.c | 7 +-
> hw/misc/Kconfig | 3 +
> hw/misc/allwinner-sramc.c | 184 ++++++++++++++++++++++++++++++
> hw/misc/meson.build | 1 +
> hw/misc/trace-events | 4 +
> include/hw/arm/allwinner-r40.h | 3 +
> include/hw/misc/allwinner-sramc.h | 69 +++++++++++
> 8 files changed, 271 insertions(+), 1 deletion(-)
> create mode 100644 hw/misc/allwinner-sramc.c
> create mode 100644 include/hw/misc/allwinner-sramc.h
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index bad4ea158c..ae6f3911c5 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -377,6 +377,7 @@ config ALLWINNER_H3
> config ALLWINNER_R40
> bool
> default y if TCG && ARM
> + select ALLWINNER_SRAMC
> select ALLWINNER_A10_PIT
> select AXP2XX_PMU
> select SERIAL
> diff --git a/hw/arm/allwinner-r40.c b/hw/arm/allwinner-r40.c
> index c018ad231a..7d29eb224f 100644
> --- a/hw/arm/allwinner-r40.c
> +++ b/hw/arm/allwinner-r40.c
> @@ -39,6 +39,7 @@ const hwaddr allwinner_r40_memmap[] = {
> [AW_R40_DEV_SRAM_A2] = 0x00004000,
> [AW_R40_DEV_SRAM_A3] = 0x00008000,
> [AW_R40_DEV_SRAM_A4] = 0x0000b400,
> + [AW_R40_DEV_SRAMC] = 0x01c00000,
> [AW_R40_DEV_EMAC] = 0x01c0b000,
> [AW_R40_DEV_MMC0] = 0x01c0f000,
> [AW_R40_DEV_MMC1] = 0x01c10000,
> @@ -76,7 +77,6 @@ struct AwR40Unimplemented {
> static struct AwR40Unimplemented r40_unimplemented[] = {
> { "d-engine", 0x01000000, 4 * MiB },
> { "d-inter", 0x01400000, 128 * KiB },
> - { "sram-c", 0x01c00000, 4 * KiB },
> { "dma", 0x01c02000, 4 * KiB },
> { "nfdc", 0x01c03000, 4 * KiB },
> { "ts", 0x01c04000, 4 * KiB },
> @@ -288,6 +288,8 @@ static void allwinner_r40_init(Object *obj)
> "ram-addr");
> object_property_add_alias(obj, "ram-size", OBJECT(&s->dramc),
> "ram-size");
> +
> + object_initialize_child(obj, "sramc", &s->sramc,
> TYPE_AW_SRAMC_SUN8I_R40);
> }
>
> static void allwinner_r40_realize(DeviceState *dev, Error **errp)
> @@ -382,6 +384,9 @@ static void allwinner_r40_realize(DeviceState *dev,
> Error **errp)
> AW_R40_GIC_SPI_TIMER1));
>
> /* SRAM */
> + sysbus_realize(SYS_BUS_DEVICE(&s->sramc), &error_fatal);
> + sysbus_mmio_map(SYS_BUS_DEVICE(&s->sramc), 0,
> s->memmap[AW_R40_DEV_SRAMC]);
> +
> memory_region_init_ram(&s->sram_a1, OBJECT(dev), "sram A1",
> 16 * KiB, &error_abort);
> memory_region_init_ram(&s->sram_a2, OBJECT(dev), "sram A2",
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> index efeb430a6c..e4c2149175 100644
> --- a/hw/misc/Kconfig
> +++ b/hw/misc/Kconfig
> @@ -170,6 +170,9 @@ config VIRT_CTRL
> config LASI
> bool
>
> +config ALLWINNER_SRAMC
> + bool
> +
> config ALLWINNER_A10_CCM
> bool
>
> diff --git a/hw/misc/allwinner-sramc.c b/hw/misc/allwinner-sramc.c
> new file mode 100644
> index 0000000000..a8b731f8f2
> --- /dev/null
> +++ b/hw/misc/allwinner-sramc.c
> @@ -0,0 +1,184 @@
> +/*
> + * Allwinner R40 SRAM controller emulation
> + *
> + * Copyright (C) 2023 qianfan Zhao <qianfanguijin@163.com>
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include "qemu/osdep.h"
> +#include "qemu/units.h"
> +#include "hw/sysbus.h"
> +#include "migration/vmstate.h"
> +#include "qemu/log.h"
> +#include "qemu/module.h"
> +#include "qapi/error.h"
> +#include "hw/qdev-properties.h"
> +#include "hw/qdev-properties-system.h"
> +#include "hw/misc/allwinner-sramc.h"
> +#include "trace.h"
> +
> +/*
> + * register offsets
> + * https://linux-sunxi.org/SRAM_Controller_Register_Guide
> + */
> +enum {
> + REG_SRAM_CTL1_CFG = 0x04, /* SRAM Control register 1 */
> + REG_SRAM_VER = 0x24, /* SRAM Version register */
> + REG_SRAM_R40_SOFT_ENTRY_REG0 = 0xbc,
> +};
> +
> +/* REG_SRAMC_VERSION bit defines */
> +#define SRAM_VER_READ_ENABLE (1 << 15)
> +#define SRAM_VER_VERSION_SHIFT 16
> +#define SRAM_VERSION_SUN8I_R40 0x1701
> +
> +static uint64_t allwinner_sramc_read(void *opaque, hwaddr offset,
> + unsigned size)
> +{
> + AwSRAMCState *s = AW_SRAMC(opaque);
> + AwSRAMCClass *sc = AW_SRAMC_GET_CLASS(s);
> + uint64_t val = 0;
> +
> + switch (offset) {
> + case REG_SRAM_CTL1_CFG:
> + val = s->sram_ctl1;
> + break;
> + case REG_SRAM_VER:
> + /* bit15: lock bit, set this bit before reading this register */
> + if (s->sram_ver & SRAM_VER_READ_ENABLE) {
> + val = SRAM_VER_READ_ENABLE |
> + (sc->sram_version_code << SRAM_VER_VERSION_SHIFT);
> + }
> + break;
> + case REG_SRAM_R40_SOFT_ENTRY_REG0:
> + val = s->sram_soft_entry_reg0;
> + break;
> + default:
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: out-of-bounds offset
> 0x%04x\n",
> + __func__, (uint32_t)offset);
> + return 0;
> + }
> +
> + trace_allwinner_sramc_read(offset, val);
> +
> + return val;
> +}
> +
> +static void allwinner_sramc_write(void *opaque, hwaddr offset,
> + uint64_t val, unsigned size)
> +{
> + AwSRAMCState *s = AW_SRAMC(opaque);
> +
> + trace_allwinner_sramc_write(offset, val);
> +
> + switch (offset) {
> + case REG_SRAM_CTL1_CFG:
> + s->sram_ctl1 = val;
> + break;
> + case REG_SRAM_VER:
> + /* Only the READ_ENABLE bit is writeable */
> + s->sram_ver = val & SRAM_VER_READ_ENABLE;
> + break;
> + case REG_SRAM_R40_SOFT_ENTRY_REG0:
> + s->sram_soft_entry_reg0 = val;
> + break;
> + default:
> + qemu_log_mask(LOG_GUEST_ERROR, "%s: out-of-bounds offset
> 0x%04x\n",
> + __func__, (uint32_t)offset);
> + break;
> + }
> +}
> +
> +static const MemoryRegionOps allwinner_sramc_ops = {
> + .read = allwinner_sramc_read,
> + .write = allwinner_sramc_write,
> + .endianness = DEVICE_NATIVE_ENDIAN,
> + .valid = {
> + .min_access_size = 4,
> + .max_access_size = 4,
> + },
> + .impl.min_access_size = 4,
> +};
> +
> +static const VMStateDescription allwinner_sramc_vmstate = {
> + .name = "allwinner-sramc",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT32(sram_ver, AwSRAMCState),
> + VMSTATE_UINT32(sram_soft_entry_reg0, AwSRAMCState),
> + VMSTATE_END_OF_LIST()
> + }
> +};
> +
> +static void allwinner_sramc_reset(DeviceState *dev)
> +{
> + AwSRAMCState *s = AW_SRAMC(dev);
> + AwSRAMCClass *sc = AW_SRAMC_GET_CLASS(s);
> +
> + switch (sc->sram_version_code) {
> + case SRAM_VERSION_SUN8I_R40:
> + s->sram_ctl1 = 0x1300;
> + break;
> + }
> +}
> +
> +static void allwinner_sramc_class_init(ObjectClass *klass, void *data)
> +{
> + DeviceClass *dc = DEVICE_CLASS(klass);
> +
> + dc->reset = allwinner_sramc_reset;
> + dc->vmsd = &allwinner_sramc_vmstate;
> +}
> +
> +static void allwinner_sramc_init(Object *obj)
> +{
> + SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
> + AwSRAMCState *s = AW_SRAMC(obj);
> +
> + /* Memory mapping */
> + memory_region_init_io(&s->iomem, OBJECT(s), &allwinner_sramc_ops, s,
> + TYPE_AW_SRAMC, 1 * KiB);
> + sysbus_init_mmio(sbd, &s->iomem);
> +}
> +
> +static const TypeInfo allwinner_sramc_info = {
> + .name = TYPE_AW_SRAMC,
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .instance_init = allwinner_sramc_init,
> + .instance_size = sizeof(AwSRAMCState),
> + .class_init = allwinner_sramc_class_init,
> +};
> +
> +static void allwinner_r40_sramc_class_init(ObjectClass *klass, void *data)
> +{
> + AwSRAMCClass *sc = AW_SRAMC_CLASS(klass);
> +
> + sc->sram_version_code = SRAM_VERSION_SUN8I_R40;
> +}
> +
> +static const TypeInfo allwinner_r40_sramc_info = {
> + .name = TYPE_AW_SRAMC_SUN8I_R40,
> + .parent = TYPE_AW_SRAMC,
> + .class_init = allwinner_r40_sramc_class_init,
> +};
> +
> +static void allwinner_sramc_register(void)
> +{
> + type_register_static(&allwinner_sramc_info);
> + type_register_static(&allwinner_r40_sramc_info);
> +}
> +
> +type_init(allwinner_sramc_register)
> diff --git a/hw/misc/meson.build b/hw/misc/meson.build
> index b04d43e05a..78ca857c9d 100644
> --- a/hw/misc/meson.build
> +++ b/hw/misc/meson.build
> @@ -37,6 +37,7 @@ subdir('macio')
>
> softmmu_ss.add(when: 'CONFIG_IVSHMEM_DEVICE', if_true: files('ivshmem.c'))
>
> +softmmu_ss.add(when: 'CONFIG_ALLWINNER_SRAMC', if_true:
> files('allwinner-sramc.c'))
> softmmu_ss.add(when: 'CONFIG_ALLWINNER_A10_CCM', if_true:
> files('allwinner-a10-ccm.c'))
> softmmu_ss.add(when: 'CONFIG_ALLWINNER_A10_DRAMC', if_true:
> files('allwinner-a10-dramc.c'))
> softmmu_ss.add(when: 'CONFIG_ALLWINNER_H3', if_true:
> files('allwinner-h3-ccu.c'))
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index 8b68f07765..4d1a0e17af 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -33,6 +33,10 @@ allwinner_r40_dramphy_write(uint64_t offset, uint64_t
> data, unsigned size) "writ
> allwinner_sid_read(uint64_t offset, uint64_t data, unsigned size) "offset
> 0x%" PRIx64 " data 0x%" PRIx64 " size %" PRIu32
> allwinner_sid_write(uint64_t offset, uint64_t data, unsigned size)
> "offset 0x%" PRIx64 " data 0x%" PRIx64 " size %" PRIu32
>
> +# allwinner-sramc.c
> +allwinner_sramc_read(uint64_t offset, uint64_t data) "offset 0x%" PRIx64
> " data 0x%" PRIx64
> +allwinner_sramc_write(uint64_t offset, uint64_t data) "offset 0x%" PRIx64
> " data 0x%" PRIx64
> +
> # avr_power.c
> avr_power_read(uint8_t value) "power_reduc read value:%u"
> avr_power_write(uint8_t value) "power_reduc write value:%u"
> diff --git a/include/hw/arm/allwinner-r40.h
> b/include/hw/arm/allwinner-r40.h
> index 5f2d08489e..72710d3edc 100644
> --- a/include/hw/arm/allwinner-r40.h
> +++ b/include/hw/arm/allwinner-r40.h
> @@ -27,6 +27,7 @@
> #include "hw/sd/allwinner-sdhost.h"
> #include "hw/misc/allwinner-r40-ccu.h"
> #include "hw/misc/allwinner-r40-dramc.h"
> +#include "hw/misc/allwinner-sramc.h"
> #include "hw/i2c/allwinner-i2c.h"
> #include "hw/net/allwinner_emac.h"
> #include "hw/net/allwinner-sun8i-emac.h"
> @@ -38,6 +39,7 @@ enum {
> AW_R40_DEV_SRAM_A2,
> AW_R40_DEV_SRAM_A3,
> AW_R40_DEV_SRAM_A4,
> + AW_R40_DEV_SRAMC,
> AW_R40_DEV_EMAC,
> AW_R40_DEV_MMC0,
> AW_R40_DEV_MMC1,
> @@ -102,6 +104,7 @@ struct AwR40State {
>
> ARMCPU cpus[AW_R40_NUM_CPUS];
> const hwaddr *memmap;
> + AwSRAMCState sramc;
> AwA10PITState timer;
> AwSdHostState mmc[AW_R40_NUM_MMCS];
> AwR40ClockCtlState ccu;
> diff --git a/include/hw/misc/allwinner-sramc.h
> b/include/hw/misc/allwinner-sramc.h
> new file mode 100644
> index 0000000000..66b01b8d04
> --- /dev/null
> +++ b/include/hw/misc/allwinner-sramc.h
> @@ -0,0 +1,69 @@
> +/*
> + * Allwinner SRAM controller emulation
> + *
> + * Copyright (C) 2023 qianfan Zhao <qianfanguijin@163.com>
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#ifndef HW_MISC_ALLWINNER_SRAMC_H
> +#define HW_MISC_ALLWINNER_SRAMC_H
> +
> +#include "qom/object.h"
> +#include "hw/sysbus.h"
> +#include "qemu/uuid.h"
> +
> +/**
> + * Object model
> + * @{
> + */
> +#define TYPE_AW_SRAMC "allwinner-sramc"
> +#define TYPE_AW_SRAMC_SUN8I_R40 TYPE_AW_SRAMC "-sun8i-r40"
> +OBJECT_DECLARE_TYPE(AwSRAMCState, AwSRAMCClass, AW_SRAMC)
> +
> +/** @} */
> +
> +/**
> + * Allwinner SRAMC object instance state
> + */
> +struct AwSRAMCState {
> + /*< private >*/
> + SysBusDevice parent_obj;
> + /*< public >*/
> +
> + /** Maps I/O registers in physical memory */
> + MemoryRegion iomem;
> +
> + /* registers */
> + uint32_t sram_ctl1;
> + uint32_t sram_ver;
> + uint32_t sram_soft_entry_reg0;
> +};
> +
> +/**
> + * Allwinner SRAM Controller class-level struct.
> + *
> + * This struct is filled by each sunxi device specific code
> + * such that the generic code can use this struct to support
> + * all devices.
> + */
> +struct AwSRAMCClass {
> + /*< private >*/
> + SysBusDeviceClass parent_class;
> + /*< public >*/
> +
> + uint32_t sram_version_code;
> +};
> +
> +#endif /* HW_MISC_ALLWINNER_SRAMC_H */
> --
> 2.25.1
>
>
--
Niek Linnenbank
[-- Attachment #2: Type: text/html, Size: 18044 bytes --]
next prev parent reply other threads:[~2023-05-15 20:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 10:29 [PATCH v4 00/11] *** Add allwinner r40 support *** qianfanguijin
2023-05-10 10:29 ` [PATCH v4 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support qianfanguijin
2023-05-14 18:38 ` Niek Linnenbank
2023-05-14 18:50 ` Niek Linnenbank
2023-05-23 1:21 ` qianfan
2023-05-10 10:29 ` [PATCH v4 02/11] hw/arm/allwinner-r40: add Clock Control Unit qianfanguijin
2023-05-14 18:40 ` Niek Linnenbank
2023-05-10 10:29 ` [PATCH v4 03/11] hw: allwinner-r40: Complete uart devices qianfanguijin
2023-05-14 18:55 ` Niek Linnenbank
2023-05-23 1:24 ` qianfan
2023-05-23 3:00 ` qianfan
2023-05-10 10:29 ` [PATCH v4 04/11] hw: arm: allwinner-r40: Add i2c0 device qianfanguijin
2023-05-14 18:57 ` Niek Linnenbank
2023-05-10 10:29 ` [PATCH v4 05/11] hw/misc: Rename axp209 to axp22x and add support AXP221 PMU qianfanguijin
2023-05-15 19:29 ` Niek Linnenbank
2023-05-23 0:40 ` qianfan
2023-05-10 10:29 ` [PATCH v4 06/11] hw/arm/allwinner-r40: add SDRAM controller device qianfanguijin
2023-05-15 19:47 ` Niek Linnenbank
2023-05-23 0:53 ` qianfan
2023-05-10 10:30 ` [PATCH v4 07/11] hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support qianfanguijin
2023-05-15 19:54 ` Niek Linnenbank
2023-05-23 0:53 ` qianfan
2023-05-10 10:30 ` [PATCH v4 08/11] hw: arm: allwinner-r40: Add emac and gmac support qianfanguijin
2023-05-15 19:58 ` Niek Linnenbank
2023-05-23 1:01 ` qianfan
2023-05-10 10:30 ` [PATCH v4 09/11] hw: arm: allwinner-sramc: Add SRAM Controller support for R40 qianfanguijin
2023-05-15 20:05 ` Niek Linnenbank [this message]
2023-05-10 10:30 ` [PATCH v4 10/11] tests: avocado: boot_linux_console: Add test case for bpim2u qianfanguijin
2023-05-15 20:09 ` Niek Linnenbank
2023-05-15 20:25 ` [PATCH v4 00/11] *** Add allwinner r40 support *** Niek Linnenbank
2023-05-25 9:48 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPan3WrL72uH+2rA8eBE50V31ZfYSEDH22yABfC3+LGY0UnL_Q@mail.gmail.com \
--to=nieklinnenbank@gmail.com \
--cc=b.galvani@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qianfanguijin@163.com \
--cc=strahinja.p.jankovic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).