From: Niek Linnenbank <nieklinnenbank@gmail.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [RFC PATCH 6/6] hw/arm/cubieboard: Disable unsupported M-USB in device tree blob
Date: Mon, 30 Dec 2019 21:05:19 +0100 [thread overview]
Message-ID: <CAPan3Wre4wsx+-CUBrkkDK_nwCkA-52OT0W3wS8-eM3bs7DaDQ@mail.gmail.com> (raw)
In-Reply-To: <9cdbe625-fe29-cb91-2ed4-1231953b3148@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1639 bytes --]
Hey Philippe,
I took a second look at this and, it seems my previous suggestion was only
partly valid.
The kernel error you reported came from the driver in
drivers/usb/musb/sunxi.c. Apparently, this
is an Allwinner specific driver for M-USB. And I don't see it documented in
the A10 user manual.
On the other hand, the USB host interfaces EHCI/OHCI do apply for the A10
SoC and this board.
Linux has them defined in the DTB in arch/arm/boot/dts/sun4i-a10.dtsi
(ehci0/1, ohci0/1).
But probably that is for another patch/commit.
Regards,
Niek
On Mon, Dec 30, 2019 at 2:56 PM Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> On 12/30/19 12:33 PM, Niek Linnenbank wrote:
> > Hello Philippe,
> >
> > I have a suggestion: probably you can apply (almost) the same patch to
> > get USB
> > working for A10 as I did in the Allwinner H3, in patch #4 "add USB host
> > controller" [1]
> > That way you can avoid the DTB modifications and with low effort get USB
> > working as well for this board.
> > As far as I can see, in Section 21.1 in the A10 user manual [2] has the
> > same description
> > as for the H3. It basically has the standard EHCI and OHCI interfaces.
>
> Oh good news. I guess in the long term we want a AllwinnerSoc parent
> class where all common blocks are mapped, and A10/H3 children with the
> differences. But we'll worry about that after your H3 series get merged.
>
> > [1] https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg03266.html
> > [2] https://linux-sunxi.org/File:Allwinner_A10_User_manual_V1.5.pdf
> >
> > Regards,
> > Niek
>
>
--
Niek Linnenbank
[-- Attachment #2: Type: text/html, Size: 2507 bytes --]
next prev parent reply other threads:[~2019-12-30 20:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 11:09 [PATCH 0/6] hw/arm/cubieboard: Few cleanups, add acceptance tests Philippe Mathieu-Daudé
2019-12-30 11:09 ` [PATCH 1/6] tests/boot_linux_console: Add initrd test for the CubieBoard Philippe Mathieu-Daudé
2019-12-30 20:52 ` Wainer dos Santos Moschetta
2019-12-31 11:41 ` Philippe Mathieu-Daudé
2020-01-03 13:31 ` Wainer dos Santos Moschetta
2019-12-30 11:09 ` [PATCH 2/6] tests/boot_linux_console: Add a SD card " Philippe Mathieu-Daudé
2019-12-30 11:09 ` [PATCH 3/6] hw/arm/allwinner-a10: Move SoC definitions out of header Philippe Mathieu-Daudé
2020-01-06 15:59 ` Peter Maydell
2019-12-30 11:09 ` [PATCH 4/6] hw/arm/allwinner-a10: Simplify by passing IRQs with qdev_pass_gpios() Philippe Mathieu-Daudé
2020-01-06 16:01 ` Peter Maydell
2019-12-30 11:09 ` [PATCH 5/6] hw/arm/allwinner-a10: Remove local qemu_irq variables Philippe Mathieu-Daudé
2020-01-06 16:01 ` Peter Maydell
2019-12-30 11:09 ` [RFC PATCH 6/6] hw/arm/cubieboard: Disable unsupported M-USB in device tree blob Philippe Mathieu-Daudé
2019-12-30 11:33 ` Niek Linnenbank
2019-12-30 13:55 ` Philippe Mathieu-Daudé
2019-12-30 20:05 ` Niek Linnenbank [this message]
2020-01-06 16:07 ` Peter Maydell
2020-01-06 16:36 ` Philippe Mathieu-Daudé
2020-01-06 16:24 ` [PATCH 0/6] hw/arm/cubieboard: Few cleanups, add acceptance tests Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPan3Wre4wsx+-CUBrkkDK_nwCkA-52OT0W3wS8-eM3bs7DaDQ@mail.gmail.com \
--to=nieklinnenbank@gmail.com \
--cc=b.galvani@gmail.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).