From: Niek Linnenbank <nieklinnenbank@gmail.com>
To: qianfanguijin@163.com
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v4 00/11] *** Add allwinner r40 support ***
Date: Mon, 15 May 2023 22:25:38 +0200 [thread overview]
Message-ID: <CAPan3WrukRx7NSBsCFkgfaRwbGD4j1P_SZpNiUJk5T3030aKug@mail.gmail.com> (raw)
In-Reply-To: <20230510103004.30015-1-qianfanguijin@163.com>
[-- Attachment #1: Type: text/plain, Size: 4246 bytes --]
Hi Qianfan,
Thanks for sending the v4. I've reviewed all patches and replied to each
individual patch.
Great work so far!
One thing I wanted to mention is that when you receive a 'Reviewed-by:' or
'Tested-by:' line from a reviewer,
please feel free to include it in the commit message on the next version of
that patch. This helps you and reviewers
to keep track on what has been reviewed and what not.
For more details on this and the review process, also see this page:
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#proper-use-of-reviewed-by-tags-can-aid-review
Kind regards,
Niek
On Wed, May 10, 2023 at 12:30 PM <qianfanguijin@163.com> wrote:
> From: qianfan Zhao <qianfanguijin@163.com>
>
>
> *** history ***
>
> # v1: 2023-03-21
>
> The first version which add allwinner-r40 support, supported features:
>
> + ccu
> + dram controller
> + uart
> + i2c and pmic(axp221)
> + sdcard
> + emac/gmac
>
> Also provide a test case under avocado, running quickly test:
>
> $ AVOCADO_ALLOW_LARGE_STORAGE=yes tests/venv/bin/avocado \
> --verbose --show=app,console run -t machine:bpim2u \
> ../tests/avocado/boot_linux_console.py
>
> # v2: 2023-03-28
>
> 1. Fix the waring and error reported by checkpatch.pl
> 2. Remove the other i2c controllers except that i2c0
> 3. Use an array to register mmc and uart devices
> 4. Rename axp209 to axp22x and add axp221 support
> 5. Add a basic SRAM controller
>
> # v3: 2023-04-18
>
> 1. Update some commit messages
> 2. Squash those two commit about sdcard
> hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support
> hw: arm: allwinner-r40: Fix the mmc controller's type
>
> # v4: 2023-05-10
>
> 1. Rebase to master
>
> qianfan Zhao (11):
> hw: arm: Add bananapi M2-Ultra and allwinner-r40 support
> hw/arm/allwinner-r40: add Clock Control Unit
> hw: allwinner-r40: Complete uart devices
> hw: arm: allwinner-r40: Add i2c0 device
> hw/misc: Rename axp209 to axp22x and add support AXP221 PMU
> hw/arm/allwinner-r40: add SDRAM controller device
> hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support
> hw: arm: allwinner-r40: Add emac and gmac support
> hw: arm: allwinner-sramc: Add SRAM Controller support for R40
> tests: avocado: boot_linux_console: Add test case for bpim2u
> docs: system: arm: Introduce bananapi_m2u
>
> docs/system/arm/bananapi_m2u.rst | 138 +++++++
> hw/arm/Kconfig | 14 +-
> hw/arm/allwinner-r40.c | 526 ++++++++++++++++++++++++++
> hw/arm/bananapi_m2u.c | 145 +++++++
> hw/arm/meson.build | 1 +
> hw/misc/Kconfig | 5 +-
> hw/misc/allwinner-r40-ccu.c | 209 ++++++++++
> hw/misc/allwinner-r40-dramc.c | 513 +++++++++++++++++++++++++
> hw/misc/allwinner-sramc.c | 184 +++++++++
> hw/misc/axp209.c | 238 ------------
> hw/misc/axp2xx.c | 283 ++++++++++++++
> hw/misc/meson.build | 5 +-
> hw/misc/trace-events | 26 +-
> hw/sd/allwinner-sdhost.c | 70 +++-
> include/hw/arm/allwinner-r40.h | 143 +++++++
> include/hw/misc/allwinner-r40-ccu.h | 65 ++++
> include/hw/misc/allwinner-r40-dramc.h | 108 ++++++
> include/hw/misc/allwinner-sramc.h | 69 ++++
> include/hw/sd/allwinner-sdhost.h | 9 +
> tests/avocado/boot_linux_console.py | 176 +++++++++
> 20 files changed, 2679 insertions(+), 248 deletions(-)
> create mode 100644 docs/system/arm/bananapi_m2u.rst
> create mode 100644 hw/arm/allwinner-r40.c
> create mode 100644 hw/arm/bananapi_m2u.c
> create mode 100644 hw/misc/allwinner-r40-ccu.c
> create mode 100644 hw/misc/allwinner-r40-dramc.c
> create mode 100644 hw/misc/allwinner-sramc.c
> delete mode 100644 hw/misc/axp209.c
> create mode 100644 hw/misc/axp2xx.c
> create mode 100644 include/hw/arm/allwinner-r40.h
> create mode 100644 include/hw/misc/allwinner-r40-ccu.h
> create mode 100644 include/hw/misc/allwinner-r40-dramc.h
> create mode 100644 include/hw/misc/allwinner-sramc.h
>
> --
> 2.25.1
>
>
--
Niek Linnenbank
[-- Attachment #2: Type: text/html, Size: 5508 bytes --]
next prev parent reply other threads:[~2023-05-15 20:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 10:29 [PATCH v4 00/11] *** Add allwinner r40 support *** qianfanguijin
2023-05-10 10:29 ` [PATCH v4 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support qianfanguijin
2023-05-14 18:38 ` Niek Linnenbank
2023-05-14 18:50 ` Niek Linnenbank
2023-05-23 1:21 ` qianfan
2023-05-10 10:29 ` [PATCH v4 02/11] hw/arm/allwinner-r40: add Clock Control Unit qianfanguijin
2023-05-14 18:40 ` Niek Linnenbank
2023-05-10 10:29 ` [PATCH v4 03/11] hw: allwinner-r40: Complete uart devices qianfanguijin
2023-05-14 18:55 ` Niek Linnenbank
2023-05-23 1:24 ` qianfan
2023-05-23 3:00 ` qianfan
2023-05-10 10:29 ` [PATCH v4 04/11] hw: arm: allwinner-r40: Add i2c0 device qianfanguijin
2023-05-14 18:57 ` Niek Linnenbank
2023-05-10 10:29 ` [PATCH v4 05/11] hw/misc: Rename axp209 to axp22x and add support AXP221 PMU qianfanguijin
2023-05-15 19:29 ` Niek Linnenbank
2023-05-23 0:40 ` qianfan
2023-05-10 10:29 ` [PATCH v4 06/11] hw/arm/allwinner-r40: add SDRAM controller device qianfanguijin
2023-05-15 19:47 ` Niek Linnenbank
2023-05-23 0:53 ` qianfan
2023-05-10 10:30 ` [PATCH v4 07/11] hw: sd: allwinner-sdhost: Add sun50i-a64 SoC support qianfanguijin
2023-05-15 19:54 ` Niek Linnenbank
2023-05-23 0:53 ` qianfan
2023-05-10 10:30 ` [PATCH v4 08/11] hw: arm: allwinner-r40: Add emac and gmac support qianfanguijin
2023-05-15 19:58 ` Niek Linnenbank
2023-05-23 1:01 ` qianfan
2023-05-10 10:30 ` [PATCH v4 09/11] hw: arm: allwinner-sramc: Add SRAM Controller support for R40 qianfanguijin
2023-05-15 20:05 ` Niek Linnenbank
2023-05-10 10:30 ` [PATCH v4 10/11] tests: avocado: boot_linux_console: Add test case for bpim2u qianfanguijin
2023-05-15 20:09 ` Niek Linnenbank
2023-05-15 20:25 ` Niek Linnenbank [this message]
2023-05-25 9:48 ` [PATCH v4 00/11] *** Add allwinner r40 support *** Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPan3WrukRx7NSBsCFkgfaRwbGD4j1P_SZpNiUJk5T3030aKug@mail.gmail.com \
--to=nieklinnenbank@gmail.com \
--cc=b.galvani@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qianfanguijin@163.com \
--cc=strahinja.p.jankovic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).