From: Dan Williams <dan.j.williams@intel.com>
To: Eric Blake <eblake@redhat.com>
Cc: linux-nvdimm <linux-nvdimm@ml01.01.org>,
Vishal L Verma <vishal.l.verma@intel.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support
Date: Wed, 19 Oct 2016 14:29:29 -0700 [thread overview]
Message-ID: <CAPcyv4h3_OAef5n=tQ2vDXw=sntkZPTnyoeFdRQN6BKKx3q6SA@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4gbRE-ALJM6EHv6fM3Kq02HeZFMLF5T63J5qaJmHWvQCg@mail.gmail.com>
On Wed, Oct 19, 2016 at 12:41 PM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Wed, Oct 19, 2016 at 11:42 AM, Eric Blake <eblake@redhat.com> wrote:
>> On 10/19/2016 11:47 AM, Dan Williams wrote:
>>> The 4.9 kernel added support for sub-dividing PMEM. With this kernel
>>> patch [1] on top of that baseline, the PMEM-sub-division support can be
>>> enabled for QEMU-KVM and any other platforms that advertise both un-aliased
>>> PMEM regions and support for the label DSM commands [2].
>>>
>>> Given this increasing need to perform a label management operation
>>> across a set of DIMMs this update also adds glob(3) support. For
>>> example you can now write commands like:
>>>
>>> ndctl zero-labels nmem[2-4]
>>
>> This is slightly scary, as it depends on the user not having any file
>> named nmem2, nmem3, or nmem4 in the current working directory. Your
>> example should probably encourage proper shell quoting, as in:
>>
>> ndctl zero-labels 'nmem[2-4]'
>
> True. Although, the glob is run against the list of present device
> names in the system, so local files named nmem should change the
> operation of the command.
s/should/shouldn't/
In any event I don't see the danger in leaving it in, and my fingers
default to [2-4] vs {2..4}.
next prev parent reply other threads:[~2016-10-19 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 16:47 [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support Dan Williams
2016-10-19 16:48 ` [Qemu-devel] [ndctl PATCH 7/8] ndctl: init-labels command Dan Williams
2016-10-19 18:42 ` [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support Eric Blake
2016-10-19 19:41 ` Dan Williams
2016-10-19 21:29 ` Dan Williams [this message]
2016-10-19 23:46 ` Eric Blake
2016-10-19 23:56 ` Dan Williams
2016-10-20 19:32 ` Vishal Verma
2016-10-20 20:06 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4h3_OAef5n=tQ2vDXw=sntkZPTnyoeFdRQN6BKKx3q6SA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=eblake@redhat.com \
--cc=linux-nvdimm@ml01.01.org \
--cc=qemu-devel@nongnu.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).