From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37423)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1agbrK-0001mI-2f
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 13:37:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1agbrJ-0002MF-8x
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 13:37:18 -0400
Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:32987)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1agbrJ-0002Lc-1m
	for qemu-devel@nongnu.org; Thu, 17 Mar 2016 13:37:17 -0400
Received: by mail-wm0-x234.google.com with SMTP id l68so36489472wml.0
	for <qemu-devel@nongnu.org>; Thu, 17 Mar 2016 10:37:16 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1456128205-5092-10-git-send-email-marcin.krzeminski@nokia.com>
References: <1456128205-5092-1-git-send-email-marcin.krzeminski@nokia.com>
	<1456128205-5092-10-git-send-email-marcin.krzeminski@nokia.com>
Date: Thu, 17 Mar 2016 10:37:16 -0700
Message-ID: <CAPokK=o1X0A6AvRP3GV99oTYcqo2VidbaJNQQMf4xiacafJhsA@mail.gmail.com>
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH v4 09/11] block: m25p80: Implemented FSR
	register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Krzeminski, Marcin (Nokia - PL/Wroclaw)" <marcin.krzeminski@nokia.com>
Cc: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@fr.ibm.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, pawel.lenkow@itlen.com

On Mon, Feb 22, 2016 at 12:03 AM,  <marcin.krzeminski@nokia.com> wrote:
> From: Marcin Krzeminski <marcin.krzeminski@nokia.com>
>
> Implements FSR register, it is used for busy waits.
>
> Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com>
> ---
>  hw/block/m25p80.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 4acc79a..bc0dadb 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -222,6 +222,7 @@ typedef enum {
>      WREN = 0x6,
>      JEDEC_READ = 0x9f,
>      BULK_ERASE = 0xc7,
> +    READ_FSR = 0x70,
>
>      READ = 0x3,
>      READ4 = 0x13,
> @@ -678,6 +679,16 @@ static void decode_new_cmd(Flash *s, uint32_t value)
>          s->state = STATE_READING_DATA;
>          break;
>
> +    case READ_FSR:
> +        s->data[0] = (1 << 7); /*Indicates flash is ready */
> +        if (s->four_bytes_address_mode) {
> +            s->data[0] |= 0x1;
> +        }
> +        s->pos = 0;
> +        s->len = 1;
> +        s->state = STATE_READING_DATA;
> +        break;
> +

To be consistent with recommendation on CFG register macros it should
be done here too.

Otherwise:

Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>

>      case JEDEC_READ:
>          DB_PRINT_L(0, "populated jedec code\n");
>          s->data[0] = (s->pi->jedec >> 16) & 0xff;
> --
> 2.5.0
>