From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: "Sai Pavan Boddu" <saipava@xilinx.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Edgar Iglesias" <edgar.iglesias@xilinx.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type
Date: Sat, 15 Aug 2015 14:22:53 -0700 [thread overview]
Message-ID: <CAPokK=oKHTKuPBh3ntTMO7uM4zUWSju0Z=qTmq4z6w4OG5-Vsg@mail.gmail.com> (raw)
In-Reply-To: <76f0a328e53daa4a2303fe17d3bbe157d7b40d03.1437699224.git.alistair.francis@xilinx.com>
On Mon, Jul 27, 2015 at 11:37 AM, Alistair Francis
<alistair.francis@xilinx.com> wrote:
> If the ObjectClass has no type return NULL instead of trying to compare
> the type name.
>
What was the issue?
Regards,
Peter
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Sai Pavan Boddu <saipava@xilinx.com>
> ---
> qom/object.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index eea8edf..2d6d715 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -603,7 +603,7 @@ ObjectClass *object_class_dynamic_cast(ObjectClass *class,
> TypeImpl *target_type;
> TypeImpl *type;
>
> - if (!class) {
> + if (!class || !class->type) {
> return NULL;
> }
>
> --
> 1.7.1
>
>
next prev parent reply other threads:[~2015-08-15 21:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 18:37 [Qemu-devel] [PATCH v1 0/3] xlnx-zynqmp: Connect the AHCI SATA device Alistair Francis
2015-07-27 18:37 ` [Qemu-devel] [PATCH v1 1/3] ahci: Separate the AHCI state structure into the header Alistair Francis
2015-07-29 22:21 ` John Snow
2015-07-30 0:12 ` Alistair Francis
2015-08-15 21:18 ` Peter Crosthwaite
2015-08-15 21:57 ` Peter Maydell
2015-08-15 21:21 ` Peter Crosthwaite
2015-08-15 21:25 ` Peter Crosthwaite
2015-08-17 22:31 ` Alistair Francis
2015-07-27 18:37 ` [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type Alistair Francis
2015-08-15 21:22 ` Peter Crosthwaite [this message]
2015-08-17 22:24 ` Alistair Francis
2015-08-17 22:33 ` Andreas Färber
2015-08-17 23:37 ` Peter Crosthwaite
2015-08-24 23:36 ` Alistair Francis
2015-08-25 7:43 ` Peter Crosthwaite
2015-08-26 20:36 ` Alistair Francis
2015-08-26 21:02 ` Peter Crosthwaite
2015-08-26 21:46 ` John Snow
2015-08-26 22:15 ` Peter Crosthwaite
2015-08-26 22:39 ` Peter Maydell
2015-08-26 23:11 ` John Snow
2015-08-27 18:56 ` Alistair Francis
2015-07-27 18:37 ` [Qemu-devel] [PATCH v1 3/3] xlnx-zynqmp: Connect the sysbus AHCI to ZynqMP Alistair Francis
2015-08-15 21:29 ` Peter Crosthwaite
2015-08-17 22:38 ` Alistair Francis
2015-08-14 17:24 ` [Qemu-devel] [PATCH v1 0/3] xlnx-zynqmp: Connect the AHCI SATA device Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPokK=oKHTKuPBh3ntTMO7uM4zUWSju0Z=qTmq4z6w4OG5-Vsg@mail.gmail.com' \
--to=crosthwaitepeter@gmail.com \
--cc=afaerber@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=edgar.iglesias@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=saipava@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).