From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1ZgGnu-0003LT-K7
	for qemu-devel@nongnu.org; Sun, 27 Sep 2015 14:36:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1ZgGnt-0004Cq-Ta
	for qemu-devel@nongnu.org; Sun, 27 Sep 2015 14:36:06 -0400
Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:38224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1ZgGnt-0004CV-OY
	for qemu-devel@nongnu.org; Sun, 27 Sep 2015 14:36:05 -0400
Received: by wiclk2 with SMTP id lk2so74928782wic.1
	for <qemu-devel@nongnu.org>; Sun, 27 Sep 2015 11:36:05 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <CAMo8Bf+XsA5CupQ50vFLwN4Ptj6Pr2f5SeqMVpTofjexVOhT5A@mail.gmail.com>
References: <1443374214-27149-1-git-send-email-jcmvbkbc@gmail.com>
	<1443374214-27149-3-git-send-email-jcmvbkbc@gmail.com>
	<CAPokK=o-vHm0-tGBXUpZn6zSatk7eftuVjHxx0uqW5-DmbC1wg@mail.gmail.com>
	<CAMo8Bf+XsA5CupQ50vFLwN4Ptj6Pr2f5SeqMVpTofjexVOhT5A@mail.gmail.com>
Date: Sun, 27 Sep 2015 11:36:05 -0700
Message-ID: <CAPokK=oSaX30TDi9A2Fm3kT3GiTw-WR2so9Mr4fKqeiUwGwjbg@mail.gmail.com>
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 2/3] target-xtensa: xtfpga: attach FLASH to
 system IO
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On Sun, Sep 27, 2015 at 11:01 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> On Sun, Sep 27, 2015 at 8:42 PM, Peter Crosthwaite
> <crosthwaitepeter@gmail.com> wrote:
>> On Sun, Sep 27, 2015 at 10:16 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>>> XTFPGA FLASH is tied to XTFPGA system IO block. It's not very important
>>> for systems with MMU where system IO block is visible at single
>>> location,
>>
>> Are your relying on a matching change in the guest for MMU setup here?
>>
>> Can you explain a little more how the MMU allows a physical address
>> remap of the underlying hardware as this looks like a non
>> backwards-compatible board design rev.
>
> No change is needed as this change doesn't affect memory map.
> It only detaches FLASH from the system memory and attaches it
> to the system IO region, at the same physical address as before.
>

Ok I get it now :). Commit message confused me a little with the MMU
stuff but reading it again it makes sense. Change looks good. I'll
wait for resolution on P1 before putting an RB.

Regards,
Peter

> --
> Thanks.
> -- Max