From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43686)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1aAz38-0003nG-J2
	for qemu-devel@nongnu.org; Mon, 21 Dec 2015 06:54:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1aAz37-00010F-Ip
	for qemu-devel@nongnu.org; Mon, 21 Dec 2015 06:54:46 -0500
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36913)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1aAz37-0000zH-CU
	for qemu-devel@nongnu.org; Mon, 21 Dec 2015 06:54:45 -0500
Received: by mail-wm0-x22c.google.com with SMTP id p187so66063652wmp.0
	for <qemu-devel@nongnu.org>; Mon, 21 Dec 2015 03:54:45 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <1450270635-27080-13-git-send-email-marcin.krzeminski@nokia.com>
References: <1450270635-27080-1-git-send-email-marcin.krzeminski@nokia.com>
	<1450270635-27080-13-git-send-email-marcin.krzeminski@nokia.com>
Date: Mon, 21 Dec 2015 03:54:44 -0800
Message-ID: <CAPokK=qShhcWN_DOMsk=bARGboxiEQp8SaZ2ff3vTk3LLLJGqg@mail.gmail.com>
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH 12/12] Read flag status register command
 support added.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Krzeminski, Marcin (Nokia - PL/Wroclaw)" <marcin.krzeminski@nokia.com>
Cc: pawel.lenkow@nokia.com, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

Subsystem prefix needed and reverse commit subject to start with verb:

"block: m25p80: Add Read Flag Status command"

On Wed, Dec 16, 2015 at 4:57 AM,  <marcin.krzeminski@nokia.com> wrote:
> From: Marcin Krzeminski <marcin.krzeminski@nokia.com>
>
> Signed-off-by: Marcin Krzeminski <marcin.krzeminski@nokia.com>

Otherwise:

Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>

Thanks to you and Pawel for this work.

Regards,
Peter

> ---
>  hw/block/m25p80.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index fadd6ec..ef05ad3 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -258,6 +258,7 @@ typedef enum {
>      WREN = 0x6,
>      JEDEC_READ = 0x9f,
>      BULK_ERASE = 0xc7,
> +    READ_FSR = 0x70,
>
>      READ = 0x3,
>      READ4 = 0x13,
> @@ -667,6 +668,13 @@ static void decode_new_cmd(Flash *s, uint32_t value)
>          s->state = STATE_READING_DATA;
>          break;
>
> +    case READ_FSR:
> +        s->data[0] = (1<<7); /*Indicates flash is ready */
> +        s->pos = 0;
> +        s->len = 1;
> +        s->state = STATE_READING_DATA;
> +        break;
> +
>      case JEDEC_READ:
>          DB_PRINT_L(0, "populated jedec code\n");
>          for (i = 0; i < s->pi->id_len; i++) {
> --
> 2.5.0
>
>