From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1ZkPBO-0001qw-Fg
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 00:21:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1ZkPBN-0007wK-Lx
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 00:21:26 -0400
Received: from mail-wi0-x241.google.com ([2a00:1450:400c:c05::241]:35048)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <crosthwaitepeter@gmail.com>) id 1ZkPBN-0007wG-FU
	for qemu-devel@nongnu.org; Fri, 09 Oct 2015 00:21:25 -0400
Received: by wicxq10 with SMTP id xq10so9121244wic.2
	for <qemu-devel@nongnu.org>; Thu, 08 Oct 2015 21:21:24 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <56171740.2000809@gmail.com>
References: <cover.1444318183.git.mdavidsaver@gmail.com>
	<CAPokK=pUch7OjFoCBjrt9o2moDywbPtg+mn0xj2RbBO8Dq+zaQ@mail.gmail.com>
	<56171740.2000809@gmail.com>
Date: Thu, 8 Oct 2015 21:21:24 -0700
Message-ID: <CAPokK=r+HjMQtRjFFgdZTCGc8d=f=UOJF-k5=J47cZyKG5G=pA@mail.gmail.com>
From: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [Qemu-devel] [PATCH] Exit on reset for armv7-m
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Davidsaver <mdavidsaver@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>

On Thu, Oct 8, 2015 at 6:24 PM, Michael Davidsaver
<mdavidsaver@gmail.com> wrote:
> On 10/08/2015 04:09 PM, Peter Crosthwaite wrote:
>> On Thu, Oct 8, 2015 at 8:40 AM, Michael Davidsaver
>> <mdavidsaver@gmail.com> wrote:
>>> Implement the SYSRESETREQ bit of the AIRCR register
>>> for armv7-m (ie. cortex-m3).
>>>
>>
>> This would serve better as the commit message to the patch (which I
>> notice is missing a commit blurb).
>
> Does this warrant sending an updated patch?  I would have no objection to whomever applies the patch simply changing the commit message.
>

I would resend as a single. But I am yet to get around to a proper
review of the patch proper, as I need to dig out relavent docs. So if
you want a day or two I might have more comments.

Regards,
Peter

>>> A small patch to see if I have the submission process figured out.
>>>
>>
>> It is usual for the cover and patches to be enumerated together with
>> the cover being patch 0, e.g. the subject would read [PATCH 0/1]. the
>> --cover-letter switch of git format-patch does this for you.
>
> Alas in this case it did not.  Probably because I omitted '--numbered'.
>
>>> Michael Davidsaver (1):
>>
>> When sending a single, a cover is not required. You could just send
>> the patch on it's own. This will all be useful when you come to send
>> multi-patch series however.
>
> Noted.
>
> Thanks for the feedback Peter.
>
>
> Michael