From: Programmingkid <programmingkidx@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X
Date: Mon, 29 Jun 2015 14:04:38 -0400 [thread overview]
Message-ID: <CC33EED0-0B9C-4AEF-81EF-5EA76178CC13@gmail.com> (raw)
In-Reply-To: <CAFEAcA8o1rDne5CS-h3vFd9482neKeucS9BsrDPqWeDktfXjxA@mail.gmail.com>
On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote:
> On 29 June 2015 at 17:54, Programmingkid <programmingkidx@gmail.com> wrote:
>> @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device = {
>> .bdrv_ioctl = hdev_ioctl,
>> .bdrv_aio_ioctl = hdev_aio_ioctl,
>> #endif
>> +
>> +#ifdef __APPLE__
>> + .bdrv_is_inserted = cdrom_is_inserted,
>> +#endif
>
> Why isn't this handled by having a bdrv_host_cdrom,
> like Linux and FreeBSD do for their CDROM support?
That would involve a lot of unnecessary work and modifications. This small change is all that is needed.
next prev parent reply other threads:[~2015-06-29 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-29 16:54 [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted() implementation for Mac OS X Programmingkid
2015-06-29 17:11 ` Peter Maydell
2015-06-29 18:04 ` Programmingkid [this message]
2015-06-29 18:16 ` Peter Maydell
2015-06-29 18:37 ` Programmingkid
2015-06-29 20:43 ` Laurent Vivier
2015-06-29 20:55 ` Programmingkid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CC33EED0-0B9C-4AEF-81EF-5EA76178CC13@gmail.com \
--to=programmingkidx@gmail.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).