From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44124)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1Z9dQI-0006BN-EL
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 14:04:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <programmingkidx@gmail.com>) id 1Z9dQH-0004e6-Bo
	for qemu-devel@nongnu.org; Mon, 29 Jun 2015 14:04:50 -0400
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Programmingkid <programmingkidx@gmail.com>
In-Reply-To: <CAFEAcA8o1rDne5CS-h3vFd9482neKeucS9BsrDPqWeDktfXjxA@mail.gmail.com>
Date: Mon, 29 Jun 2015 14:04:38 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <CC33EED0-0B9C-4AEF-81EF-5EA76178CC13@gmail.com>
References: <C3D7DD34-3469-4A16-B6AA-63673CA30810@gmail.com>
	<CAFEAcA8o1rDne5CS-h3vFd9482neKeucS9BsrDPqWeDktfXjxA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] raw-posix.c: cd_is_inserted()
	implementation for Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Qemu-block <qemu-block@nongnu.org>


On Jun 29, 2015, at 1:11 PM, Peter Maydell wrote:

> On 29 June 2015 at 17:54, Programmingkid <programmingkidx@gmail.com> =
wrote:
>> @@ -2365,6 +2384,10 @@ static BlockDriver bdrv_host_device =3D {
>>     .bdrv_ioctl         =3D hdev_ioctl,
>>     .bdrv_aio_ioctl     =3D hdev_aio_ioctl,
>> #endif
>> +
>> +#ifdef __APPLE__
>> +    .bdrv_is_inserted   =3D cdrom_is_inserted,
>> +#endif
>=20
> Why isn't this handled by having a bdrv_host_cdrom,
> like Linux and FreeBSD do for their CDROM support?

That would involve a lot of unnecessary work and modifications. This =
small change is all that is needed.=